X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=E2Manager%2Fmanagers%2Fran_setup_manager_test.go;h=4178062ed1d0171952cbd3e50b4fc2c87f79b77e;hb=refs%2Fchanges%2F01%2F2101%2F1;hp=f10e929bd7f64cae1fea2bb4f88d2aa759145b17;hpb=3f9a67b3d8e15bc725f2f66adf499617ffc0d2fc;p=ric-plt%2Fe2mgr.git diff --git a/E2Manager/managers/ran_setup_manager_test.go b/E2Manager/managers/ran_setup_manager_test.go index f10e929..4178062 100644 --- a/E2Manager/managers/ran_setup_manager_test.go +++ b/E2Manager/managers/ran_setup_manager_test.go @@ -13,17 +13,21 @@ // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. -// + +// This source code is part of the near-RT RIC (RAN Intelligent Controller) +// platform project (RICP). + package managers import ( + "e2mgr/configuration" "e2mgr/e2managererrors" "e2mgr/e2pdus" "e2mgr/logger" "e2mgr/mocks" - "e2mgr/rNibWriter" "e2mgr/rmrCgo" + "e2mgr/services" "fmt" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities" @@ -32,15 +36,29 @@ import ( "testing" ) -func TestExecuteSetupConnectingX2Setup(t *testing.T) { - log := initLog(t) +func initRanSetupManagerTest(t *testing.T) (*mocks.RmrMessengerMock, *mocks.RnibWriterMock, *RanSetupManager) { + logger, err := logger.InitLogger(logger.DebugLevel) + if err != nil { + t.Errorf("#... - failed to initialize logger, error: %s", err) + } + config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: 3} - ranName := "test1" + rmrMessengerMock := &mocks.RmrMessengerMock{} + rmrSender := initRmrSender(rmrMessengerMock, logger) + + readerMock := &mocks.RnibReaderMock{} writerMock := &mocks.RnibWriterMock{} - writerProvider := func() rNibWriter.RNibWriter { - return writerMock - } + + rnibDataService := services.NewRnibDataService(logger, config, readerMock, writerMock) + ranSetupManager := NewRanSetupManager(logger, rmrSender, rnibDataService) + return rmrMessengerMock, writerMock, ranSetupManager +} + +func TestExecuteSetupConnectingX2Setup(t *testing.T) { + rmrMessengerMock, writerMock, mgr := initRanSetupManagerTest(t) + + ranName := "test1" var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST} var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1} @@ -50,12 +68,9 @@ func TestExecuteSetupConnectingX2Setup(t *testing.T) { payload := e2pdus.PackedX2setupRequest xaction := []byte(ranName) msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ranName, &payload, &xaction) - rmrMessengerMock := &mocks.RmrMessengerMock{} - rmrMessengerMock.On("SendMsg", mock.Anything, mock.Anything).Return(msg, nil) - rmrService := getRmrService(rmrMessengerMock, log) + rmrMessengerMock.On("SendMsg", mock.Anything, true).Return(msg, nil) - mgr := NewRanSetupManager(log, rmrService, writerProvider) - if err := mgr.ExecuteSetup(initialNodeb); err != nil { + if err := mgr.ExecuteSetup(initialNodeb, entities.ConnectionStatus_CONNECTING); err != nil { t.Errorf("want: success, got: error: %s", err) } @@ -64,16 +79,11 @@ func TestExecuteSetupConnectingX2Setup(t *testing.T) { } func TestExecuteSetupConnectingEndcX2Setup(t *testing.T) { - log := initLog(t) + rmrMessengerMock, writerMock, mgr := initRanSetupManagerTest(t) ranName := "test1" - writerMock := &mocks.RnibWriterMock{} - writerProvider := func() rNibWriter.RNibWriter { - return writerMock - } - - var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_ENDC_X2_SETUP_REQUEST} + var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_ENDC_X2_SETUP_REQUEST} var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_ENDC_X2_SETUP_REQUEST, ConnectionAttempts: 1} var rnibErr error writerMock.On("UpdateNodebInfo", argNodeb).Return(rnibErr) @@ -81,12 +91,9 @@ func TestExecuteSetupConnectingEndcX2Setup(t *testing.T) { payload := e2pdus.PackedEndcX2setupRequest xaction := []byte(ranName) msg := rmrCgo.NewMBuf(rmrCgo.RIC_ENDC_X2_SETUP_REQ, len(payload), ranName, &payload, &xaction) - rmrMessengerMock := &mocks.RmrMessengerMock{} - rmrMessengerMock.On("SendMsg", mock.Anything, mock.Anything).Return(msg, nil) - rmrService := getRmrService(rmrMessengerMock, log) + rmrMessengerMock.On("SendMsg", mock.Anything, true).Return(msg, nil) - mgr := NewRanSetupManager(log, rmrService, writerProvider) - if err := mgr.ExecuteSetup(initialNodeb); err != nil { + if err := mgr.ExecuteSetup(initialNodeb, entities.ConnectionStatus_CONNECTING); err != nil { t.Errorf("want: success, got: error: %s", err) } @@ -95,15 +102,10 @@ func TestExecuteSetupConnectingEndcX2Setup(t *testing.T) { } func TestExecuteSetupDisconnected(t *testing.T) { - log := initLog(t) + rmrMessengerMock, writerMock, mgr := initRanSetupManagerTest(t) ranName := "test1" - writerMock := &mocks.RnibWriterMock{} - writerProvider := func() rNibWriter.RNibWriter { - return writerMock - } - var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST} var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1} var argNodebDisconnected = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 0} @@ -114,12 +116,9 @@ func TestExecuteSetupDisconnected(t *testing.T) { payload := []byte{0} xaction := []byte(ranName) msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ranName, &payload, &xaction) - rmrMessengerMock := &mocks.RmrMessengerMock{} - rmrMessengerMock.On("SendMsg", mock.Anything, mock.Anything).Return(msg, fmt.Errorf("send failure")) - rmrService := getRmrService(rmrMessengerMock, log) + rmrMessengerMock.On("SendMsg", mock.Anything, true).Return(msg, fmt.Errorf("send failure")) - mgr := NewRanSetupManager(log, rmrService, writerProvider) - if err := mgr.ExecuteSetup(initialNodeb); err == nil { + if err := mgr.ExecuteSetup(initialNodeb, entities.ConnectionStatus_CONNECTING); err == nil { t.Errorf("want: failure, got: success") } @@ -128,15 +127,10 @@ func TestExecuteSetupDisconnected(t *testing.T) { } func TestExecuteSetupConnectingRnibError(t *testing.T) { - log := initLog(t) + rmrMessengerMock, writerMock, mgr := initRanSetupManagerTest(t) ranName := "test1" - writerMock := &mocks.RnibWriterMock{} - writerProvider := func() rNibWriter.RNibWriter { - return writerMock - } - var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST} var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1} var argNodebDisconnected = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 0} @@ -147,12 +141,9 @@ func TestExecuteSetupConnectingRnibError(t *testing.T) { payload := []byte{0} xaction := []byte(ranName) msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ranName, &payload, &xaction) - rmrMessengerMock := &mocks.RmrMessengerMock{} - rmrMessengerMock.On("SendMsg", mock.Anything, mock.Anything).Return(msg, fmt.Errorf("send failure")) - rmrService := getRmrService(rmrMessengerMock, log) + rmrMessengerMock.On("SendMsg", mock.Anything, true).Return(msg, fmt.Errorf("send failure")) - mgr := NewRanSetupManager(log, rmrService, writerProvider) - if err := mgr.ExecuteSetup(initialNodeb); err == nil { + if err := mgr.ExecuteSetup(initialNodeb, entities.ConnectionStatus_CONNECTING); err == nil { t.Errorf("want: failure, got: success") } else { assert.IsType(t, e2managererrors.NewRnibDbError(), err) @@ -163,15 +154,10 @@ func TestExecuteSetupConnectingRnibError(t *testing.T) { } func TestExecuteSetupDisconnectedRnibError(t *testing.T) { - log := initLog(t) + rmrMessengerMock, writerMock, mgr := initRanSetupManagerTest(t) ranName := "test1" - writerMock := &mocks.RnibWriterMock{} - writerProvider := func() rNibWriter.RNibWriter { - return writerMock - } - var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST} var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1} var argNodebDisconnected = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 0} @@ -182,12 +168,9 @@ func TestExecuteSetupDisconnectedRnibError(t *testing.T) { payload := []byte{0} xaction := []byte(ranName) msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ranName, &payload, &xaction) - rmrMessengerMock := &mocks.RmrMessengerMock{} - rmrMessengerMock.On("SendMsg", mock.Anything, mock.Anything).Return(msg, fmt.Errorf("send failure")) - rmrService := getRmrService(rmrMessengerMock, log) + rmrMessengerMock.On("SendMsg", mock.Anything, true).Return(msg, fmt.Errorf("send failure")) - mgr := NewRanSetupManager(log, rmrService, writerProvider) - if err := mgr.ExecuteSetup(initialNodeb); err == nil { + if err := mgr.ExecuteSetup(initialNodeb, entities.ConnectionStatus_CONNECTING); err == nil { t.Errorf("want: failure, got: success") } else { assert.IsType(t, e2managererrors.NewRnibDbError(), err) @@ -198,15 +181,10 @@ func TestExecuteSetupDisconnectedRnibError(t *testing.T) { } func TestExecuteSetupUnsupportedProtocol(t *testing.T) { - log := initLog(t) + rmrMessengerMock, writerMock, mgr := initRanSetupManagerTest(t) ranName := "test1" - writerMock := &mocks.RnibWriterMock{} - writerProvider := func() rNibWriter.RNibWriter { - return writerMock - } - var initialNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_UNKNOWN_E2_APPLICATION_PROTOCOL} var argNodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_UNKNOWN_E2_APPLICATION_PROTOCOL, ConnectionAttempts: 1} var rnibErr error @@ -215,12 +193,9 @@ func TestExecuteSetupUnsupportedProtocol(t *testing.T) { payload := e2pdus.PackedX2setupRequest xaction := []byte(ranName) msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ranName, &payload, &xaction) - rmrMessengerMock := &mocks.RmrMessengerMock{} - rmrMessengerMock.On("SendMsg", mock.Anything, mock.Anything).Return(msg, nil) - rmrService := getRmrService(rmrMessengerMock, log) + rmrMessengerMock.On("SendMsg", mock.Anything, true).Return(msg, nil) - mgr := NewRanSetupManager(log, rmrService, writerProvider) - if err := mgr.ExecuteSetup(initialNodeb); err == nil { + if err := mgr.ExecuteSetup(initialNodeb, entities.ConnectionStatus_CONNECTING); err == nil { t.Errorf("want: error, got: success") }