X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=E2Manager%2Fhttpserver%2Fhttp_server_test.go;h=bbbdb141961e6416dc6df42523f91f797d9514ac;hb=3d2b421d8ff9e2a6de7c7e64d51b9e292b05e7c2;hp=e6e1ef5b5ed965eae13ffec07548e07442f16f79;hpb=efcb4528362460aa2249d319c9752b63bb720fe2;p=ric-plt%2Fe2mgr.git diff --git a/E2Manager/httpserver/http_server_test.go b/E2Manager/httpserver/http_server_test.go old mode 100644 new mode 100755 index e6e1ef5..bbbdb14 --- a/E2Manager/httpserver/http_server_test.go +++ b/E2Manager/httpserver/http_server_test.go @@ -1,6 +1,7 @@ // // Copyright 2019 AT&T Intellectual Property // Copyright 2019 Nokia +// Copyright (c) 2020 Samsung Electronics Co., Ltd. All Rights Reserved. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. @@ -17,7 +18,6 @@ // This source code is part of the near-RT RIC (RAN Intelligent Controller) // platform project (RICP). - package httpserver import ( @@ -31,68 +31,61 @@ import ( "time" ) -func setupRouterAndMocks() (*mux.Router, *mocks.RootControllerMock, *mocks.NodebControllerMock, *mocks.E2TControllerMock) { +func setupRouterAndMocks() (*mux.Router, *mocks.RootControllerMock, *mocks.NodebControllerMock, *mocks.E2TControllerMock, *mocks.SymptomdataControllerMock) { rootControllerMock := &mocks.RootControllerMock{} rootControllerMock.On("HandleHealthCheckRequest").Return(nil) nodebControllerMock := &mocks.NodebControllerMock{} nodebControllerMock.On("Shutdown").Return(nil) - nodebControllerMock.On("X2Reset").Return(nil) - nodebControllerMock.On("X2Setup").Return(nil) - nodebControllerMock.On("EndcSetup").Return(nil) nodebControllerMock.On("GetNodeb").Return(nil) nodebControllerMock.On("GetNodebIdList").Return(nil) + nodebControllerMock.On("GetNodebId").Return(nil) + nodebControllerMock.On("SetGeneralConfiguration").Return(nil) + nodebControllerMock.On("DeleteEnb").Return(nil) + nodebControllerMock.On("AddEnb").Return(nil) + nodebControllerMock.On("UpdateEnb").Return(nil) + nodebControllerMock.On("HealthCheckRequest").Return(nil) e2tControllerMock := &mocks.E2TControllerMock{} - e2tControllerMock.On("GetE2TInstances").Return(nil) - router := mux.NewRouter() - initializeRoutes(router, rootControllerMock, nodebControllerMock, e2tControllerMock) - return router, rootControllerMock, nodebControllerMock, e2tControllerMock -} - -func TestRoutePostEndcSetup(t *testing.T) { - router, _, nodebControllerMock, _ := setupRouterAndMocks() - - req, err := http.NewRequest("POST", "/v1/nodeb/endc-setup", nil) - if err != nil { - t.Fatal(err) - } - rr := httptest.NewRecorder() - router.ServeHTTP(rr, req) + symptomdataControllerMock := &mocks.SymptomdataControllerMock{} + symptomdataControllerMock.On("GetSymptomData").Return(nil) - nodebControllerMock.AssertNumberOfCalls(t, "EndcSetup", 1) + router := mux.NewRouter() + initializeRoutes(router, rootControllerMock, nodebControllerMock, e2tControllerMock, symptomdataControllerMock) + return router, rootControllerMock, nodebControllerMock, e2tControllerMock, symptomdataControllerMock } -func TestRoutePostX2Setup(t *testing.T) { - router, _, nodebControllerMock, _ := setupRouterAndMocks() +func TestRouteGetNodebIdList(t *testing.T) { + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() - req, err := http.NewRequest("POST", "/v1/nodeb/x2-setup", nil) + req, err := http.NewRequest("GET", "/v1/nodeb/states", nil) if err != nil { t.Fatal(err) } rr := httptest.NewRecorder() router.ServeHTTP(rr, req) - nodebControllerMock.AssertNumberOfCalls(t, "X2Setup", 1) + nodebControllerMock.AssertNumberOfCalls(t, "GetNodebIdList", 1) } -func TestRouteGetNodebIds(t *testing.T) { - router, _, nodebControllerMock, _ := setupRouterAndMocks() +func TestRouteGetNodebId(t *testing.T) { + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() - req, err := http.NewRequest("GET", "/v1/nodeb/ids", nil) + req, err := http.NewRequest("GET", "/v1/nodeb/states/ran1", nil) if err != nil { t.Fatal(err) } rr := httptest.NewRecorder() router.ServeHTTP(rr, req) - nodebControllerMock.AssertNumberOfCalls(t, "GetNodebIdList", 1) + assert.Equal(t, http.StatusOK, rr.Code, "handler returned wrong status code") + nodebControllerMock.AssertNumberOfCalls(t, "GetNodebId", 1) } func TestRouteGetNodebRanName(t *testing.T) { - router, _, nodebControllerMock, _ := setupRouterAndMocks() + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() req, err := http.NewRequest("GET", "/v1/nodeb/ran1", nil) if err != nil { @@ -107,7 +100,7 @@ func TestRouteGetNodebRanName(t *testing.T) { } func TestRouteGetHealth(t *testing.T) { - router, rootControllerMock, _, _ := setupRouterAndMocks() + router, rootControllerMock, _, _, _ := setupRouterAndMocks() req, err := http.NewRequest("GET", "/v1/health", nil) if err != nil { @@ -120,7 +113,7 @@ func TestRouteGetHealth(t *testing.T) { } func TestRoutePutNodebShutdown(t *testing.T) { - router, _, nodebControllerMock, _ := setupRouterAndMocks() + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() req, err := http.NewRequest("PUT", "/v1/nodeb/shutdown", nil) if err != nil { @@ -132,23 +125,48 @@ func TestRoutePutNodebShutdown(t *testing.T) { nodebControllerMock.AssertNumberOfCalls(t, "Shutdown", 1) } -func TestRoutePutNodebResetRanName(t *testing.T) { - router, _, nodebControllerMock, _ := setupRouterAndMocks() +func TestHealthCheckRequest(t *testing.T) { + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() - req, err := http.NewRequest("PUT", "/v1/nodeb/ran1/reset", nil) + req, err := http.NewRequest("PUT", "/v1/nodeb/health", nil) if err != nil { t.Fatal(err) } rr := httptest.NewRecorder() router.ServeHTTP(rr, req) - assert.Equal(t, http.StatusOK, rr.Code, "handler returned wrong status code") - assert.Equal(t, "ran1", rr.Body.String(), "handler returned wrong body") - nodebControllerMock.AssertNumberOfCalls(t, "X2Reset", 1) + assert.Equal(t, http.StatusAccepted, rr.Code, "handler returned wrong status code") + nodebControllerMock.AssertNumberOfCalls(t, "HealthCheckRequest", 1) +} + +func TestRoutePutNodebSetGeneralConfiguration(t *testing.T) { + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() + + req, err := http.NewRequest("PUT", "/v1/nodeb/parameters", nil) + if err != nil { + t.Fatal(err) + } + rr := httptest.NewRecorder() + router.ServeHTTP(rr, req) + + nodebControllerMock.AssertNumberOfCalls(t, "SetGeneralConfiguration", 1) +} + +func TestRoutePutUpdateEnb(t *testing.T) { + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() + + req, err := http.NewRequest("PUT", "/v1/nodeb/enb/ran1", nil) + if err != nil { + t.Fatal(err) + } + rr := httptest.NewRecorder() + router.ServeHTTP(rr, req) + + nodebControllerMock.AssertNumberOfCalls(t, "UpdateEnb", 1) } func TestRouteNotFound(t *testing.T) { - router, _, _,_ := setupRouterAndMocks() + router, _, _, _, _ := setupRouterAndMocks() req, err := http.NewRequest("GET", "/v1/no/such/route", nil) if err != nil { @@ -162,14 +180,14 @@ func TestRouteNotFound(t *testing.T) { func TestRunError(t *testing.T) { log := initLog(t) - err := Run(log, 1234567, &mocks.RootControllerMock{}, &mocks.NodebControllerMock{}, &mocks.E2TControllerMock{}) + err := Run(log, 1234567, &mocks.RootControllerMock{}, &mocks.NodebControllerMock{}, &mocks.E2TControllerMock{}, &mocks.SymptomdataControllerMock{}) assert.NotNil(t, err) } func TestRun(t *testing.T) { log := initLog(t) - _, rootControllerMock, nodebControllerMock, e2tControllerMock := setupRouterAndMocks() - go Run(log, 11223, rootControllerMock, nodebControllerMock, e2tControllerMock) + _, rootControllerMock, nodebControllerMock, e2tControllerMock, symptomdataControllerMock := setupRouterAndMocks() + go Run(log, 11223, rootControllerMock, nodebControllerMock, e2tControllerMock, symptomdataControllerMock) time.Sleep(time.Millisecond * 100) resp, err := http.Get("http://localhost:11223/v1/health") @@ -179,6 +197,34 @@ func TestRun(t *testing.T) { assert.Equal(t, 200, resp.StatusCode) } +func TestRouteAddEnb(t *testing.T) { + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() + + req, err := http.NewRequest("POST", "/v1/nodeb/enb", nil) + if err != nil { + t.Fatal(err) + } + rr := httptest.NewRecorder() + router.ServeHTTP(rr, req) + + assert.Equal(t, http.StatusCreated, rr.Code, "handler returned wrong status code") + nodebControllerMock.AssertNumberOfCalls(t, "AddEnb", 1) +} + +func TestRouteDeleteEnb(t *testing.T) { + router, _, nodebControllerMock, _, _ := setupRouterAndMocks() + + req, err := http.NewRequest("DELETE", "/v1/nodeb/enb/ran1", nil) + if err != nil { + t.Fatal(err) + } + rr := httptest.NewRecorder() + router.ServeHTTP(rr, req) + + assert.Equal(t, http.StatusNoContent, rr.Code, "handler returned wrong status code") + nodebControllerMock.AssertNumberOfCalls(t, "DeleteEnb", 1) +} + func initLog(t *testing.T) *logger.Logger { log, err := logger.InitLogger(logger.InfoLevel) if err != nil {