X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=E2Manager%2Fcontrollers%2Fnodeb_controller_test.go;h=a2acacdb6bd3545fb13166f7ef17e7a86c1924c7;hb=d1972d0d82bd0f231a66b39adccd20d8e4829729;hp=f6a9e54bade1c08a0e9ede43f69edae3e746ad5a;hpb=966f2102168cad95b8aa1bc83241b4b6730ab1e2;p=ric-plt%2Fe2mgr.git diff --git a/E2Manager/controllers/nodeb_controller_test.go b/E2Manager/controllers/nodeb_controller_test.go index f6a9e54..a2acacd 100644 --- a/E2Manager/controllers/nodeb_controller_test.go +++ b/E2Manager/controllers/nodeb_controller_test.go @@ -18,354 +18,460 @@ package controllers import ( + "bytes" + "e2mgr/configuration" + "e2mgr/e2managererrors" + //"e2mgr/e2pdus" "e2mgr/logger" + "e2mgr/managers" "e2mgr/mocks" "e2mgr/models" - "e2mgr/rNibWriter" + "e2mgr/providers/httpmsghandlerprovider" "e2mgr/rmrCgo" "e2mgr/services" - "e2mgr/sessions" + "e2mgr/services/rmrsender" "e2mgr/tests" + "encoding/json" "fmt" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities" - "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/reader" - "github.com/julienschmidt/httprouter" + "github.com/gorilla/mux" "github.com/pkg/errors" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/mock" + "io" "io/ioutil" "net/http" "net/http/httptest" + "strings" "testing" ) -const x2SetupMessageType = "x2-setup" - -func TestNewRequestController(t *testing.T) { - rnibReaderProvider := func() reader.RNibReader { - return &mocks.RnibReaderMock{} - } - rnibWriterProvider := func() rNibWriter.RNibWriter { - return &mocks.RnibWriterMock{} - } - - assert.NotNil(t, NewNodebController(&logger.Logger{}, &services.RmrService{}, rnibReaderProvider, rnibWriterProvider)) +type controllerGetNodebTestContext struct { + ranName string + nodebInfo *entities.NodebInfo + rnibError error + expectedStatusCode int + expectedJsonResponse string } -func TestHandleRequestSuccess(t *testing.T) { - log, err := logger.InitLogger(logger.InfoLevel) - if err != nil { - t.Errorf("#nodeb_controller_test.TestHandleRequestSuccess - failed to initialize logger, error: %s", err) - } +type controllerGetNodebIdListTestContext struct { + nodebIdList []*entities.NbIdentity + rnibError error + expectedStatusCode int + expectedJsonResponse string +} - rmrMessengerMock :=&mocks.RmrMessengerMock{} - mbuf := rmrCgo.NewMBuf(tests.MessageType, tests.MaxMsgSize,"RanName", &tests.DummyPayload, &tests.DummyXAction) +func setupControllerTest(t *testing.T) (*NodebController, *mocks.RnibReaderMock, *mocks.RnibWriterMock, *mocks.RmrMessengerMock) { + log := initLog(t) + config := configuration.ParseConfiguration() - rmrMessengerMock.On("SendMsg", - mock.AnythingOfType(fmt.Sprintf("%T", mbuf)), - tests.MaxMsgSize).Return(mbuf, nil) + rmrMessengerMock := &mocks.RmrMessengerMock{} + readerMock := &mocks.RnibReaderMock{} - writer := httptest.NewRecorder() + writerMock := &mocks.RnibWriterMock{} - handleRequest(writer, log, rmrMessengerMock, tests.GetHttpRequest(), x2SetupMessageType) - assert.Equal(t, writer.Result().StatusCode, http.StatusOK) + rnibDataService := services.NewRnibDataService(log, config, readerMock, writerMock) + rmrSender := getRmrSender(rmrMessengerMock, log) + ranSetupManager := managers.NewRanSetupManager(log, rmrSender, rnibDataService) + e2tInstancesManager := managers.NewE2TInstancesManager(rnibDataService, log) + handlerProvider := httpmsghandlerprovider.NewIncomingRequestHandlerProvider(log, rmrSender, config, rnibDataService, ranSetupManager, e2tInstancesManager) + controller := NewNodebController(log, handlerProvider) + return controller, readerMock, writerMock, rmrMessengerMock } -func TestHandleRequestFailure_InvalidRequestDetails(t *testing.T) { - log, err := logger.InitLogger(logger.InfoLevel) - if err != nil { - t.Errorf("#nodeb_controller_test.TestHandleRequestFailure - failed to initialize logger, error: %s", err) - } +func TestX2SetupInvalidBody(t *testing.T) { - rmrMessengerMock := &mocks.RmrMessengerMock{} - var mbuf *rmrCgo.MBuf + controller, _, _, _ := setupControllerTest(t) - rmrMessengerMock.On("SendMsg", - mock.AnythingOfType(fmt.Sprintf("%T", mbuf)), - tests.MaxMsgSize).Return(mbuf, errors.New("test failure")) + header := http.Header{} + header.Set("Content-Type", "application/json") + httpRequest, _ := http.NewRequest("POST", "http://localhost:3800/v1/nodeb/x2-setup", strings.NewReader("{}{}")) + httpRequest.Header = header writer := httptest.NewRecorder() + controller.X2Setup(writer, httpRequest) + + var errorResponse = parseJsonRequest(t, writer.Body) - handleRequest(writer, log, rmrMessengerMock, tests.GetInvalidRequestDetails(), x2SetupMessageType) assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) + assert.Equal(t, e2managererrors.NewInvalidJsonError().Code, errorResponse.Code) } -func TestHandleRequestFailure_InvalidMessageType(t *testing.T) { - log, err := logger.InitLogger(logger.InfoLevel) - if err != nil { - t.Errorf("#nodeb_controller_test.TestHandleRequestFailure - failed to initialize logger, error: %s", err) - } +//func TestX2SetupSuccess(t *testing.T) { +// +// controller, readerMock, writerMock, rmrMessengerMock := setupControllerTest(t) +// +// ranName := "test" +// nb := &entities.NodebInfo{RanName: ranName, ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST} +// readerMock.On("GetNodeb", ranName).Return(nb, nil) +// +// var nbUpdated = &entities.NodebInfo{RanName: ranName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_X2_SETUP_REQUEST, ConnectionAttempts: 1} +// writerMock.On("UpdateNodebInfo", nbUpdated).Return(nil) +// +// payload := e2pdus.PackedX2setupRequest +// var xAction[]byte +// msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_SETUP_REQ, len(payload), ranName, &payload, &xAction) +// +// rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg, nil) +// +// header := http.Header{} +// header.Set("Content-Type", "application/json") +// httpRequest := tests.GetHttpRequest() +// httpRequest.Header = header +// +// writer := httptest.NewRecorder() +// controller.X2Setup(writer, httpRequest) +// +// assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) +//} +// +//func TestEndcSetupSuccess(t *testing.T) { +// +// controller, readerMock, writerMock, rmrMessengerMock := setupControllerTest(t) +// +// ranName := "test" +// nb := &entities.NodebInfo{RanName: ranName, ConnectionStatus: entities.ConnectionStatus_DISCONNECTED, E2ApplicationProtocol: entities.E2ApplicationProtocol_ENDC_X2_SETUP_REQUEST} +// readerMock.On("GetNodeb", ranName).Return(nb, nil) +// +// var nbUpdated = &entities.NodebInfo{RanName: ranName, ConnectionStatus: entities.ConnectionStatus_CONNECTING, E2ApplicationProtocol: entities.E2ApplicationProtocol_ENDC_X2_SETUP_REQUEST, ConnectionAttempts: 1} +// writerMock.On("UpdateNodebInfo", nbUpdated).Return(nil) +// +// payload := e2pdus.PackedEndcX2setupRequest +// var xAction[]byte +// msg := rmrCgo.NewMBuf(rmrCgo.RIC_ENDC_X2_SETUP_REQ, len(payload), ranName, &payload, &xAction) +// +// rmrMessengerMock.On("SendMsg", mock.Anything).Return(msg, nil) +// +// header := http.Header{} +// header.Set("Content-Type", "application/json") +// httpRequest := tests.GetHttpRequest() +// httpRequest.Header = header +// +// writer := httptest.NewRecorder() +// controller.EndcSetup(writer, httpRequest) +// +// assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) +//} - rmrMessengerMock := &mocks.RmrMessengerMock{} - var mbuf *rmrCgo.MBuf +func TestShutdownHandlerRnibError(t *testing.T) { + controller, readerMock, _, _ := setupControllerTest(t) - rmrMessengerMock.On("SendMsg", - mock.AnythingOfType(fmt.Sprintf("%T", mbuf)), - tests.MaxMsgSize).Return(mbuf, errors.New("test failure")) + rnibErr := &common.ResourceNotFoundError{} + var nbIdentityList []*entities.NbIdentity + readerMock.On("GetListNodebIds").Return(nbIdentityList, rnibErr) writer := httptest.NewRecorder() - handleRequest(writer, log, rmrMessengerMock, tests.GetInvalidMessageType(), "dummy") - assert.Equal(t, http.StatusNotFound, writer.Result().StatusCode) + controller.Shutdown(writer, tests.GetHttpRequest()) + + var errorResponse = parseJsonRequest(t, writer.Body) + + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) + assert.Equal(t, errorResponse.Code, e2managererrors.NewRnibDbError().Code) } -func TestHandleHealthCheckRequest(t *testing.T) { - rc := NewNodebController(nil, nil, nil, nil) +func controllerGetNodebTestExecuter(t *testing.T, context *controllerGetNodebTestContext) { + controller, readerMock, _, _ := setupControllerTest(t) writer := httptest.NewRecorder() - rc.HandleHealthCheckRequest(writer, nil, nil) - assert.Equal(t, writer.Result().StatusCode, http.StatusOK) + readerMock.On("GetNodeb", context.ranName).Return(context.nodebInfo, context.rnibError) + req, _ := http.NewRequest("GET", "/nodeb", nil) + req = mux.SetURLVars(req, map[string]string{"ranName": context.ranName}) + controller.GetNodeb(writer, req) + assert.Equal(t, context.expectedStatusCode, writer.Result().StatusCode) + bodyBytes, _ := ioutil.ReadAll(writer.Body) + assert.Equal(t, context.expectedJsonResponse, string(bodyBytes)) } -func handleRequest(writer *httptest.ResponseRecorder, log *logger.Logger, rmrMessengerMock *mocks.RmrMessengerMock, - request *http.Request, messageType string) { - rmrService := getRmrService(rmrMessengerMock, log) - params := []httprouter.Param{{Key: "messageType", Value: messageType}} +func controllerGetNodebIdListTestExecuter(t *testing.T, context *controllerGetNodebIdListTestContext) { + controller, readerMock, _, _ := setupControllerTest(t) + writer := httptest.NewRecorder() + readerMock.On("GetListNodebIds").Return(context.nodebIdList, context.rnibError) + req, _ := http.NewRequest("GET", "/nodeb/ids", nil) + controller.GetNodebIdList(writer, req) + assert.Equal(t, context.expectedStatusCode, writer.Result().StatusCode) + bodyBytes, _ := ioutil.ReadAll(writer.Body) + assert.Equal(t, context.expectedJsonResponse, string(bodyBytes)) +} - var nodebInfo *entities.NodebInfo - var nbIdentity *entities.NbIdentity +func TestControllerGetNodebSuccess(t *testing.T) { + ranName := "test" + var rnibError error + context := controllerGetNodebTestContext{ + ranName: ranName, + nodebInfo: &entities.NodebInfo{RanName: ranName, Ip: "10.0.2.15", Port: 1234}, + rnibError: rnibError, + expectedStatusCode: http.StatusOK, + expectedJsonResponse: fmt.Sprintf("{\"ranName\":\"%s\",\"ip\":\"10.0.2.15\",\"port\":1234}", ranName), + } - rnibWriterMock := mocks.RnibWriterMock{} - rnibWriterMock.On("SaveNodeb", - mock.AnythingOfType(fmt.Sprintf("%T", nbIdentity)), - mock.AnythingOfType(fmt.Sprintf("%T", nodebInfo))).Return(nil) + controllerGetNodebTestExecuter(t, &context) +} - rnibReaderProvider := func() reader.RNibReader { - return &mocks.RnibReaderMock{} - } +func TestControllerGetNodebNotFound(t *testing.T) { - rnibWriterProvider := func() rNibWriter.RNibWriter { - return &rnibWriterMock + ranName := "test" + var nodebInfo *entities.NodebInfo + context := controllerGetNodebTestContext{ + ranName: ranName, + nodebInfo: nodebInfo, + rnibError: common.NewResourceNotFoundError("#reader.GetNodeb - Not found Error"), + expectedStatusCode: http.StatusNotFound, + expectedJsonResponse: "{\"errorCode\":404,\"errorMessage\":\"Resource not found\"}", } - NewNodebController(log, rmrService, rnibReaderProvider, rnibWriterProvider).HandleRequest(writer, request, params) + controllerGetNodebTestExecuter(t, &context) } -func getRmrService(rmrMessengerMock *mocks.RmrMessengerMock, log *logger.Logger) *services.RmrService { - rmrMessenger := rmrCgo.RmrMessenger(rmrMessengerMock) - messageChannel := make(chan *models.NotificationResponse) - rmrMessengerMock.On("Init", tests.GetPort(), tests.MaxMsgSize, tests.Flags, log).Return(&rmrMessenger) - return services.NewRmrService(services.NewRmrConfig(tests.Port, tests.MaxMsgSize, tests.Flags, log), rmrMessenger, make(sessions.E2Sessions), messageChannel) -} +func TestControllerGetNodebInternal(t *testing.T) { + ranName := "test" + var nodebInfo *entities.NodebInfo + context := controllerGetNodebTestContext{ + ranName: ranName, + nodebInfo: nodebInfo, + rnibError: common.NewInternalError(errors.New("#reader.GetNodeb - Internal Error")), + expectedStatusCode: http.StatusInternalServerError, + expectedJsonResponse: "{\"errorCode\":500,\"errorMessage\":\"RNIB error\"}", + } + controllerGetNodebTestExecuter(t, &context) +} -func executeGetNodeb(logger *logger.Logger, writer *httptest.ResponseRecorder, rnibReaderProvider func() reader.RNibReader) { - req, _ := http.NewRequest("GET", "/nodeb", nil) +func TestControllerGetNodebIdListSuccess(t *testing.T) { + var rnibError error + nodebIdList := []*entities.NbIdentity{ + {InventoryName: "test1", GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId1", NbId: "nbId1"}}, + {InventoryName: "test2", GlobalNbId: &entities.GlobalNbId{PlmnId: "plmnId2", NbId: "nbId2"}}, + } - params := []httprouter.Param{{Key: "ranName", Value: "testNode"}} + context := controllerGetNodebIdListTestContext{ + nodebIdList: nodebIdList, + rnibError: rnibError, + expectedStatusCode: http.StatusOK, + expectedJsonResponse: "[{\"inventoryName\":\"test1\",\"globalNbId\":{\"plmnId\":\"plmnId1\",\"nbId\":\"nbId1\"}},{\"inventoryName\":\"test2\",\"globalNbId\":{\"plmnId\":\"plmnId2\",\"nbId\":\"nbId2\"}}]", + } - NewNodebController(logger, nil, rnibReaderProvider, nil).GetNodeb(writer, req, params) + controllerGetNodebIdListTestExecuter(t, &context) } -func TestNodebController_GetNodeb_Success(t *testing.T) { - log, err := logger.InitLogger(logger.InfoLevel) +func TestControllerGetNodebIdListEmptySuccess(t *testing.T) { + var rnibError error + nodebIdList := []*entities.NbIdentity{} - if err != nil { - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodeb_Success - failed to initialize logger, error: %s", err) + context := controllerGetNodebIdListTestContext{ + nodebIdList: nodebIdList, + rnibError: rnibError, + expectedStatusCode: http.StatusOK, + expectedJsonResponse: "[]", } - writer := httptest.NewRecorder() - - rnibReaderMock := mocks.RnibReaderMock{} - - var rnibError common.IRNibError - rnibReaderMock.On("GetNodeb", "testNode").Return(&entities.NodebInfo{}, rnibError) + controllerGetNodebIdListTestExecuter(t, &context) +} - rnibReaderProvider := func() reader.RNibReader { - return &rnibReaderMock +func TestControllerGetNodebIdListInternal(t *testing.T) { + var nodebIdList []*entities.NbIdentity + context := controllerGetNodebIdListTestContext{ + nodebIdList: nodebIdList, + rnibError: common.NewInternalError(errors.New("#reader.GetNodeb - Internal Error")), + expectedStatusCode: http.StatusInternalServerError, + expectedJsonResponse: "{\"errorCode\":500,\"errorMessage\":\"RNIB error\"}", } - executeGetNodeb(log, writer, rnibReaderProvider) - - assert.Equal(t, writer.Result().StatusCode, http.StatusOK) + controllerGetNodebIdListTestExecuter(t, &context) } -func TestNodebController_GetNodeb_NotFound(t *testing.T) { - log, err := logger.InitLogger(logger.InfoLevel) - - if err != nil { - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodeb_NotFound - failed to initialize logger, error: %s", err) - } +func TestHeaderValidationFailed(t *testing.T) { + controller, _, _, _ := setupControllerTest(t) writer := httptest.NewRecorder() - rnibReaderMock := mocks.RnibReaderMock{} - rnibError := common.NewResourceNotFoundError(errors.Errorf("#reader.GetNodeb - responding node %s not found", "testNode")) - var nodebInfo *entities.NodebInfo - rnibReaderMock.On("GetNodeb", "testNode").Return(nodebInfo, rnibError) + header := &http.Header{} - rnibReaderProvider := func() reader.RNibReader { - return &rnibReaderMock - } + controller.handleRequest(writer, header, httpmsghandlerprovider.ShutdownRequest, nil, true) + + var errorResponse = parseJsonRequest(t, writer.Body) + err := e2managererrors.NewHeaderValidationError() - executeGetNodeb(log, writer, rnibReaderProvider) - assert.Equal(t, writer.Result().StatusCode, http.StatusNotFound) + assert.Equal(t, http.StatusUnsupportedMediaType, writer.Result().StatusCode) + assert.Equal(t, errorResponse.Code, err.Code) + assert.Equal(t, errorResponse.Message, err.Message) } -func TestNodebController_GetNodeb_InternalError(t *testing.T) { - log, err := logger.InitLogger(logger.InfoLevel) +func TestShutdownStatusNoContent(t *testing.T) { + controller, readerMock, _, _ := setupControllerTest(t) - if err != nil { - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodeb_InternalError - failed to initialize logger, error: %s", err) - } + var rnibError error + nbIdentityList := []*entities.NbIdentity{} + readerMock.On("GetListNodebIds").Return(nbIdentityList, rnibError) writer := httptest.NewRecorder() + controller.Shutdown(writer, tests.GetHttpRequest()) - rnibReaderMock := mocks.RnibReaderMock{} + assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) +} - rnibError := common.NewInternalError(errors.New("#reader.GetNodeb - Internal Error")) - var nodebInfo *entities.NodebInfo - rnibReaderMock.On("GetNodeb", "testNode").Return(nodebInfo, rnibError) +func TestHandleInternalError(t *testing.T) { + controller, _, _, _ := setupControllerTest(t) - rnibReaderProvider := func() reader.RNibReader { - return &rnibReaderMock - } + writer := httptest.NewRecorder() + err := e2managererrors.NewInternalError() - executeGetNodeb(log, writer, rnibReaderProvider) - assert.Equal(t, writer.Result().StatusCode, http.StatusInternalServerError) -} + controller.handleErrorResponse(err, writer) + var errorResponse = parseJsonRequest(t, writer.Body) -func executeGetNodebIdList(logger *logger.Logger, writer *httptest.ResponseRecorder, rnibReaderProvider func() reader.RNibReader) { - req, _ := http.NewRequest("GET", "/nodeb-ids", nil) - NewNodebController(logger, nil, rnibReaderProvider, nil ).GetNodebIdList(writer,req,nil) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) + assert.Equal(t, errorResponse.Code, err.Code) + assert.Equal(t, errorResponse.Message, err.Message) } -func TestNodebController_GetNodebIdList_Success(t *testing.T) { - logger, err := logger.InitLogger(logger.InfoLevel) +func TestHandleCommandAlreadyInProgressError(t *testing.T) { + controller, _, _, _ := setupControllerTest(t) + writer := httptest.NewRecorder() + err := e2managererrors.NewCommandAlreadyInProgressError() - if err!=nil{ - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodebIdList_Success - failed to initialize logger, error: %s", err) - } + controller.handleErrorResponse(err, writer) + var errorResponse = parseJsonRequest(t, writer.Body) - writer := httptest.NewRecorder() + assert.Equal(t, http.StatusMethodNotAllowed, writer.Result().StatusCode) + assert.Equal(t, errorResponse.Code, err.Code) + assert.Equal(t, errorResponse.Message, err.Message) +} - rnibReaderMock := mocks.RnibReaderMock{} - var rnibError common.IRNibError +func TestValidateHeaders(t *testing.T) { + controller, _, _, _ := setupControllerTest(t) - enbList := []*entities.NbIdentity{&entities.NbIdentity{InventoryName:"test1", GlobalNbId: &entities.GlobalNbId{PlmnId:"plmnId1",NbId: "nbId1"}}} - gnbList := []*entities.NbIdentity{&entities.NbIdentity{InventoryName:"test2", GlobalNbId: &entities.GlobalNbId{PlmnId:"plmnId2",NbId: "nbId2"}}} + header := http.Header{} + header.Set("Content-Type", "application/json") + result := controller.validateRequestHeader(&header) - rnibReaderMock.On("GetListEnbIds").Return(&enbList, rnibError) - rnibReaderMock.On("GetListGnbIds").Return(&gnbList, rnibError) + assert.Nil(t, result) +} +func parseJsonRequest(t *testing.T, r io.Reader) models.ErrorResponse { - rnibReaderProvider:= func() reader.RNibReader { - return &rnibReaderMock + var errorResponse models.ErrorResponse + body, err := ioutil.ReadAll(r) + if err != nil { + t.Errorf("Error cannot deserialize json request") } + json.Unmarshal(body, &errorResponse) - executeGetNodebIdList(logger, writer, rnibReaderProvider) - assert.Equal(t, writer.Result().StatusCode, http.StatusOK) - bodyBytes, err := ioutil.ReadAll(writer.Body) - assert.Equal(t, "[{\"inventoryName\":\"test1\",\"globalNbId\":{\"plmnId\":\"plmnId1\",\"nbId\":\"nbId1\"}},{\"inventoryName\":\"test2\",\"globalNbId\":{\"plmnId\":\"plmnId2\",\"nbId\":\"nbId2\"}}]",string(bodyBytes) ) + return errorResponse } -func TestNodebController_GetNodebIdList_EmptyList(t *testing.T) { +func initLog(t *testing.T) *logger.Logger { log, err := logger.InitLogger(logger.InfoLevel) - - if err!=nil{ - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodebIdList_EmptyList - failed to initialize logger, error: %s", err) + if err != nil { + t.Errorf("#delete_all_request_handler_test.TestHandleSuccessFlow - failed to initialize logger, error: %s", err) } + return log +} - writer := httptest.NewRecorder() - - rnibReaderMock := mocks.RnibReaderMock{} +func TestX2ResetHandleSuccessfulRequestedCause(t *testing.T) { + controller, readerMock, _, rmrMessengerMock := setupControllerTest(t) - var rnibError common.IRNibError - enbList := []*entities.NbIdentity{} - gnbList := []*entities.NbIdentity{} + ranName := "test1" + payload := []byte{0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x05, 0x40, 0x01, 0x40} + var xAction[]byte + msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_RESET, len(payload), ranName, &payload, &xAction) + rmrMessengerMock.On("SendMsg", msg, mock.Anything).Return(msg, nil) - rnibReaderMock.On("GetListEnbIds").Return(&enbList, rnibError) - rnibReaderMock.On("GetListGnbIds").Return(&gnbList, rnibError) + writer := httptest.NewRecorder() + var nodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED} + readerMock.On("GetNodeb", ranName).Return(nodeb, nil) - rnibReaderProvider:= func() reader.RNibReader { - return &rnibReaderMock - } + data4Req := map[string]interface{}{"cause": "protocol:transfer-syntax-error"} + b := new(bytes.Buffer) + _ = json.NewEncoder(b).Encode(data4Req) + req, _ := http.NewRequest("PUT", "https://localhost:3800/nodeb-reset", b) + req = mux.SetURLVars(req, map[string]string{"ranName": ranName}) - executeGetNodebIdList(log, writer, rnibReaderProvider) + controller.X2Reset(writer, req) + assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) - assert.Equal(t, writer.Result().StatusCode, http.StatusOK) - bodyBytes, err := ioutil.ReadAll(writer.Body) - assert.Equal(t, "[]", string(bodyBytes)) } -func TestNodebController_GetNodebIdList_InternalError(t *testing.T) { - logger, err := logger.InitLogger(logger.InfoLevel) +func TestX2ResetHandleSuccessfulRequestedDefault(t *testing.T) { + controller, readerMock, _, rmrMessengerMock := setupControllerTest(t) - if err != nil { - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodebIdList_InternalError - failed to initialize logger, error: %s", err) - } + ranName := "test1" + // o&m intervention + payload := []byte{0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x05, 0x40, 0x01, 0x64} + var xAction[]byte + msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_RESET, len(payload), ranName, &payload, &xAction) + rmrMessengerMock.On("SendMsg", msg).Return(msg, nil) writer := httptest.NewRecorder() - rnibReaderMock := mocks.RnibReaderMock{} + var nodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED} + readerMock.On("GetNodeb", ranName).Return(nodeb, nil) - rnibError := common.NewInternalError(errors.New("#reader.GetEnbIdList - Internal Error")) - var enbList *[]*entities.NbIdentity - rnibReaderMock.On("GetListEnbIds").Return(enbList, rnibError) + // no body + b := new(bytes.Buffer) + req, _ := http.NewRequest("PUT", "https://localhost:3800/nodeb-reset", b) + req = mux.SetURLVars(req, map[string]string{"ranName": ranName}) - rnibReaderProvider := func() reader.RNibReader { - return &rnibReaderMock - } + controller.X2Reset(writer, req) + assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) - executeGetNodebIdList(logger, writer, rnibReaderProvider) - assert.Equal(t, writer.Result().StatusCode, http.StatusInternalServerError) } -func TestNodebController_GetNodebIdList_Success_One(t *testing.T) { - logger, err := logger.InitLogger(logger.InfoLevel) +func TestX2ResetHandleFailureInvalidBody(t *testing.T) { + controller, _, _, _ := setupControllerTest(t) - if err!=nil{ - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodebIdList_Success - failed to initialize logger, error: %s", err) - } + ranName := "test1" writer := httptest.NewRecorder() - rnibReaderMock := mocks.RnibReaderMock{} - var rnibError common.IRNibError - - enbList := []*entities.NbIdentity{} - gnbList := []*entities.NbIdentity{&entities.NbIdentity{InventoryName:"test2", GlobalNbId: &entities.GlobalNbId{PlmnId:"plmnId2",NbId: "nbId2"}}} - - rnibReaderMock.On("GetListEnbIds").Return(&enbList, rnibError) - rnibReaderMock.On("GetListGnbIds").Return(&gnbList, rnibError) - + // Invalid json: attribute name without quotes (should be "cause":). + b := strings.NewReader("{cause:\"protocol:transfer-syntax-error\"") + req, _ := http.NewRequest("PUT", "https://localhost:3800/nodeb-reset", b) + req = mux.SetURLVars(req, map[string]string{"ranName": ranName}) - rnibReaderProvider:= func() reader.RNibReader { - return &rnibReaderMock - } + controller.X2Reset(writer, req) + assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) - executeGetNodebIdList(logger, writer, rnibReaderProvider) - assert.Equal(t, writer.Result().StatusCode, http.StatusOK) - bodyBytes, err := ioutil.ReadAll(writer.Body) - assert.Equal(t, "[{\"inventoryName\":\"test2\",\"globalNbId\":{\"plmnId\":\"plmnId2\",\"nbId\":\"nbId2\"}}]",string(bodyBytes) ) } -func TestNodebController_GetNodebIdList_Success_Many(t *testing.T) { - logger, err := logger.InitLogger(logger.InfoLevel) - - if err!=nil{ - t.Errorf("#nodeb_controller_test.TestNodebController_GetNodebIdList_Success - failed to initialize logger, error: %s", err) - } +func TestHandleErrorResponse(t *testing.T) { + controller, _, _, _ := setupControllerTest(t) writer := httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewRnibDbError(), writer) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) - rnibReaderMock := mocks.RnibReaderMock{} - var rnibError common.IRNibError + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewCommandAlreadyInProgressError(), writer) + assert.Equal(t, http.StatusMethodNotAllowed, writer.Result().StatusCode) - enbList := []*entities.NbIdentity{&entities.NbIdentity{InventoryName:"test1", GlobalNbId: &entities.GlobalNbId{PlmnId:"plmnId1",NbId: "nbId1"}}} - gnbList := []*entities.NbIdentity{&entities.NbIdentity{InventoryName:"test2", GlobalNbId: &entities.GlobalNbId{PlmnId:"plmnId2",NbId: "nbId2"}}, {InventoryName:"test3", GlobalNbId: &entities.GlobalNbId{PlmnId:"plmnId3",NbId: "nbId3"}}} + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewHeaderValidationError(), writer) + assert.Equal(t, http.StatusUnsupportedMediaType, writer.Result().StatusCode) - rnibReaderMock.On("GetListEnbIds").Return(&enbList, rnibError) - rnibReaderMock.On("GetListGnbIds").Return(&gnbList, rnibError) + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewWrongStateError("", ""), writer) + assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewRequestValidationError(), writer) + assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) - rnibReaderProvider:= func() reader.RNibReader { - return &rnibReaderMock - } + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewRmrError(), writer) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) - executeGetNodebIdList(logger, writer, rnibReaderProvider) - assert.Equal(t, writer.Result().StatusCode, http.StatusOK) - bodyBytes, err := ioutil.ReadAll(writer.Body) - assert.Equal(t, "[{\"inventoryName\":\"test1\",\"globalNbId\":{\"plmnId\":\"plmnId1\",\"nbId\":\"nbId1\"}},{\"inventoryName\":\"test2\",\"globalNbId\":{\"plmnId\":\"plmnId2\",\"nbId\":\"nbId2\"}},{\"inventoryName\":\"test3\",\"globalNbId\":{\"plmnId\":\"plmnId3\",\"nbId\":\"nbId3\"}}]",string(bodyBytes) ) -} \ No newline at end of file + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewResourceNotFoundError(), writer) + assert.Equal(t, http.StatusNotFound, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(fmt.Errorf("ErrorError"), writer) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) +} + +func getRmrSender(rmrMessengerMock *mocks.RmrMessengerMock, log *logger.Logger) *rmrsender.RmrSender { + rmrMessenger := rmrCgo.RmrMessenger(rmrMessengerMock) + rmrMessengerMock.On("Init", tests.GetPort(), tests.MaxMsgSize, tests.Flags, log).Return(&rmrMessenger) + return rmrsender.NewRmrSender(log, rmrMessenger) +}