X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;f=E2Manager%2Fcontrollers%2Fcontroller_test.go;h=69dbfdae81b96977b3f826691707958afc7d378c;hb=3f9a67b3d8e15bc725f2f66adf499617ffc0d2fc;hp=6b9e7aed3ac9807cdacbbf7d89e0f592f29c7c5a;hpb=f9e31bbb0a80ae78cf72eabea8303c28abcdb2e8;p=ric-plt%2Fe2mgr.git diff --git a/E2Manager/controllers/controller_test.go b/E2Manager/controllers/controller_test.go index 6b9e7ae..69dbfda 100644 --- a/E2Manager/controllers/controller_test.go +++ b/E2Manager/controllers/controller_test.go @@ -18,23 +18,29 @@ package controllers import ( + "bytes" "e2mgr/configuration" "e2mgr/e2managererrors" "e2mgr/logger" "e2mgr/mocks" "e2mgr/models" - "e2mgr/providers" + "e2mgr/providers/httpmsghandlerprovider" "e2mgr/rNibWriter" + "e2mgr/rmrCgo" "e2mgr/tests" "encoding/json" + "fmt" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities" "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/reader" + "github.com/gorilla/mux" "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/mock" "io" "io/ioutil" "net/http" "net/http/httptest" + "strings" "testing" ) @@ -51,20 +57,19 @@ func TestShutdownHandlerRnibError(t *testing.T) { writerProvider := func() rNibWriter.RNibWriter { return writerMock } - var messageChannel chan<- *models.NotificationResponse - rnibErr := &common.RNibError{} + rnibErr := &common.ResourceNotFoundError{} var nbIdentityList []*entities.NbIdentity readerMock.On("GetListNodebIds").Return(nbIdentityList, rnibErr) writer := httptest.NewRecorder() - controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config, messageChannel) - controller.ShutdownHandler(writer, tests.GetHttpRequest(), nil) + controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config) + controller.ShutdownHandler(writer, tests.GetHttpRequest()) var errorResponse = parseJsonRequest(t, writer.Body) assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) - assert.Equal(t, errorResponse.Code, e2managererrors.NewRnibDbError().Err.Code) + assert.Equal(t, errorResponse.Code, e2managererrors.NewRnibDbError().Code) } func TestHeaderValidationFailed(t *testing.T) { @@ -80,25 +85,24 @@ func TestHeaderValidationFailed(t *testing.T) { writerProvider := func() rNibWriter.RNibWriter { return writerMock } - var messageChannel chan<- *models.NotificationResponse writer := httptest.NewRecorder() - controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config, messageChannel) + controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config) header := &http.Header{} - controller.handleRequest(writer, header, providers.ShutdownRequest, nil, true, http.StatusNoContent) + controller.handleRequest(writer, header, httpmsghandlerprovider.ShutdownRequest, nil, true, http.StatusNoContent) var errorResponse = parseJsonRequest(t, writer.Body) err := e2managererrors.NewHeaderValidationError() assert.Equal(t, http.StatusUnsupportedMediaType, writer.Result().StatusCode) - assert.Equal(t, errorResponse.Code, err.Err.Code) - assert.Equal(t, errorResponse.Message, err.Err.Message) + assert.Equal(t, errorResponse.Code, err.Code) + assert.Equal(t, errorResponse.Message, err.Message) } -func TestShutdownStatusNoContent(t *testing.T){ +func TestShutdownStatusNoContent(t *testing.T) { log := initLog(t) rmrMessengerMock := &mocks.RmrMessengerMock{} @@ -111,15 +115,14 @@ func TestShutdownStatusNoContent(t *testing.T){ return writerMock } config := configuration.ParseConfiguration() - var messageChannel chan<- *models.NotificationResponse - var rnibError common.IRNibError + var rnibError error nbIdentityList := []*entities.NbIdentity{} readerMock.On("GetListNodebIds").Return(nbIdentityList, rnibError) writer := httptest.NewRecorder() - controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config, messageChannel) - controller.ShutdownHandler(writer, tests.GetHttpRequest(), nil) + controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config) + controller.ShutdownHandler(writer, tests.GetHttpRequest()) assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) } @@ -137,18 +140,17 @@ func TestHandleInternalError(t *testing.T) { writerProvider := func() rNibWriter.RNibWriter { return writerMock } - var messageChannel chan<- *models.NotificationResponse writer := httptest.NewRecorder() - controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config, messageChannel) + controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config) err := e2managererrors.NewInternalError() controller.handleErrorResponse(err, writer) var errorResponse = parseJsonRequest(t, writer.Body) assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) - assert.Equal(t, errorResponse.Code, err.Err.Code) - assert.Equal(t, errorResponse.Message, err.Err.Message) + assert.Equal(t, errorResponse.Code, err.Code) + assert.Equal(t, errorResponse.Message, err.Message) } func TestHandleCommandAlreadyInProgressError(t *testing.T) { @@ -164,20 +166,19 @@ func TestHandleCommandAlreadyInProgressError(t *testing.T) { writerProvider := func() rNibWriter.RNibWriter { return writerMock } - var messageChannel chan<- *models.NotificationResponse writer := httptest.NewRecorder() - controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config, messageChannel) + controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config) err := e2managererrors.NewCommandAlreadyInProgressError() controller.handleErrorResponse(err, writer) var errorResponse = parseJsonRequest(t, writer.Body) assert.Equal(t, http.StatusMethodNotAllowed, writer.Result().StatusCode) - assert.Equal(t, errorResponse.Code, err.Err.Code) - assert.Equal(t, errorResponse.Message, err.Err.Message) + assert.Equal(t, errorResponse.Code, err.Code) + assert.Equal(t, errorResponse.Message, err.Message) } -func TestValidateHeaders(t *testing.T){ +func TestValidateHeaders(t *testing.T) { log := initLog(t) rmrMessengerMock := &mocks.RmrMessengerMock{} @@ -190,9 +191,8 @@ func TestValidateHeaders(t *testing.T){ return writerMock } config := configuration.ParseConfiguration() - var messageChannel chan<- *models.NotificationResponse - controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config, messageChannel) + controller := NewController(log, getRmrService(rmrMessengerMock, log), readerProvider, writerProvider, config) header := http.Header{} header.Set("Content-Type", "application/json") @@ -220,3 +220,166 @@ func initLog(t *testing.T) *logger.Logger { } return log } + +func TestX2ResetHandleSuccessfulRequestedCause(t *testing.T) { + log := initLog(t) + + ranName := "test1" + + readerMock := &mocks.RnibReaderMock{} + readerProvider := func() reader.RNibReader { + return readerMock + } + writerMock := &mocks.RnibWriterMock{} + writerProvider := func() rNibWriter.RNibWriter { + return writerMock + } + payload := []byte{0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x05, 0x40, 0x01, 0x40} + xaction := []byte(ranName) + msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_RESET, len(payload), ranName, &payload, &xaction) + rmrMessengerMock := &mocks.RmrMessengerMock{} + rmrMessengerMock.On("SendMsg", msg, mock.Anything).Return(msg, nil) + + config := configuration.ParseConfiguration() + rmrService := getRmrService(rmrMessengerMock, log) + + writer := httptest.NewRecorder() + controller := NewController(log, rmrService, readerProvider, writerProvider, config) + + var nodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED} + readerMock.On("GetNodeb", ranName).Return(nodeb, nil) + + data4Req := map[string]interface{}{"cause": "protocol:transfer-syntax-error"} + b := new(bytes.Buffer) + _ = json.NewEncoder(b).Encode(data4Req) + req, _ := http.NewRequest("PUT", "https://localhost:3800/nodeb-reset", b) + req = mux.SetURLVars(req, map[string]string{"ranName": ranName}) + + controller.X2ResetHandler(writer, req) + assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) + +} + +func TestX2ResetHandleSuccessfulRequestedDefault(t *testing.T) { + log := initLog(t) + + ranName := "test1" + + readerMock := &mocks.RnibReaderMock{} + readerProvider := func() reader.RNibReader { + return readerMock + } + writerMock := &mocks.RnibWriterMock{} + writerProvider := func() rNibWriter.RNibWriter { + return writerMock + } + // o&m intervention + payload := []byte{0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x01, 0x00, 0x05, 0x40, 0x01, 0x64} + xaction := []byte(ranName) + msg := rmrCgo.NewMBuf(rmrCgo.RIC_X2_RESET, len(payload), ranName, &payload, &xaction) + rmrMessengerMock := &mocks.RmrMessengerMock{} + rmrMessengerMock.On("SendMsg", msg, mock.Anything).Return(msg, nil) + + config := configuration.ParseConfiguration() + rmrService := getRmrService(rmrMessengerMock, log) + + writer := httptest.NewRecorder() + controller := NewController(log, rmrService, readerProvider, writerProvider, config) + + var nodeb = &entities.NodebInfo{ConnectionStatus: entities.ConnectionStatus_CONNECTED} + readerMock.On("GetNodeb", ranName).Return(nodeb, nil) + + // no body + b := new(bytes.Buffer) + req, _ := http.NewRequest("PUT", "https://localhost:3800/nodeb-reset", b) + req = mux.SetURLVars(req, map[string]string{"ranName": ranName}) + + controller.X2ResetHandler(writer, req) + assert.Equal(t, http.StatusNoContent, writer.Result().StatusCode) + +} + +func TestX2ResetHandleFailureInvalidBody(t *testing.T) { + log := initLog(t) + + ranName := "test1" + + readerMock := &mocks.RnibReaderMock{} + readerProvider := func() reader.RNibReader { + return readerMock + } + writerMock := &mocks.RnibWriterMock{} + writerProvider := func() rNibWriter.RNibWriter { + return writerMock + } + rmrMessengerMock := &mocks.RmrMessengerMock{} + + config := configuration.ParseConfiguration() + rmrService := getRmrService(rmrMessengerMock, log) + + writer := httptest.NewRecorder() + controller := NewController(log, rmrService, readerProvider, writerProvider, config) + + // Invalid json: attribute name without quotes (should be "cause":). + b := strings.NewReader("{cause:\"protocol:transfer-syntax-error\"") + req, _ := http.NewRequest("PUT", "https://localhost:3800/nodeb-reset", b) + req = mux.SetURLVars(req, map[string]string{"ranName": ranName}) + + controller.X2ResetHandler(writer, req) + assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) + + _, ok := rmrService.E2sessions[ranName] + assert.False(t, ok) + +} + +func TestHandleErrorResponse(t *testing.T) { + log := initLog(t) + + readerMock := &mocks.RnibReaderMock{} + readerProvider := func() reader.RNibReader { + return readerMock + } + writerMock := &mocks.RnibWriterMock{} + writerProvider := func() rNibWriter.RNibWriter { + return writerMock + } + rmrMessengerMock := &mocks.RmrMessengerMock{} + + config := configuration.ParseConfiguration() + rmrService := getRmrService(rmrMessengerMock, log) + + controller := NewController(log, rmrService, readerProvider, writerProvider, config) + + writer := httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewRnibDbError(), writer) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewCommandAlreadyInProgressError(), writer) + assert.Equal(t, http.StatusMethodNotAllowed, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewHeaderValidationError(), writer) + assert.Equal(t, http.StatusUnsupportedMediaType, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewWrongStateError("", ""), writer) + assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewRequestValidationError(), writer) + assert.Equal(t, http.StatusBadRequest, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewRmrError(), writer) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(e2managererrors.NewResourceNotFoundError(), writer) + assert.Equal(t, http.StatusNotFound, writer.Result().StatusCode) + + writer = httptest.NewRecorder() + controller.handleErrorResponse(fmt.Errorf("ErrorError"), writer) + assert.Equal(t, http.StatusInternalServerError, writer.Result().StatusCode) +}