X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=webapp-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Foransc%2Fric%2Fportal%2Fdashboard%2Fportalapi%2FPortalAuthManager.java;h=2cf55a8780218dd7cc00289082d749573975e26c;hb=09a0d3c769ba83727fe454093cd6054eca77cfdf;hp=451539000ce808047bb3a0e8d53a1d888ff0bafc;hpb=2ab4c976427eb13105d8dd03dda3f040a94a1ec1;p=portal%2Fric-dashboard.git

diff --git a/webapp-backend/src/main/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManager.java b/webapp-backend/src/main/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManager.java
index 45153900..2cf55a87 100644
--- a/webapp-backend/src/main/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManager.java
+++ b/webapp-backend/src/main/java/org/oransc/ric/portal/dashboard/portalapi/PortalAuthManager.java
@@ -2,7 +2,7 @@
  * ========================LICENSE_START=================================
  * O-RAN-SC
  * %%
- * Copyright (C) 2019 AT&T Intellectual Property and Nokia
+ * Copyright (C) 2019 AT&T Intellectual Property
  * %%
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@ import java.util.Map;
 import javax.servlet.http.Cookie;
 import javax.servlet.http.HttpServletRequest;
 
+import org.onap.portalsdk.core.onboarding.crossapi.IPortalRestCentralService;
 import org.onap.portalsdk.core.onboarding.exception.CipherUtilException;
 import org.onap.portalsdk.core.onboarding.util.PortalApiConstants;
 import org.slf4j.Logger;
@@ -44,14 +45,12 @@ public class PortalAuthManager {
 	private final String userIdCookieName;
 
 	public PortalAuthManager(final String appName, final String username, final String password,
-			final String decryptorClassName, final String userCookie)
-			throws ClassNotFoundException, InstantiationException, IllegalAccessException, IllegalArgumentException,
-			InvocationTargetException, NoSuchMethodException, SecurityException {
+			final String decryptorClassName, final String userCookie) throws ClassNotFoundException,
+			InstantiationException, IllegalAccessException, InvocationTargetException, NoSuchMethodException {
 		credentialsMap = new HashMap<>();
-		// The map keys are hardcoded in EPSDK-FW, no constants are defined :(
-		credentialsMap.put("appName", appName);
-		credentialsMap.put("username", username);
-		credentialsMap.put("password", password);
+		credentialsMap.put(IPortalRestCentralService.CREDENTIALS_APP, appName);
+		credentialsMap.put(IPortalRestCentralService.CREDENTIALS_USER, username);
+		credentialsMap.put(IPortalRestCentralService.CREDENTIALS_PASS, password);
 		this.userIdCookieName = userCookie;
 		// Instantiate here so configuration errors are detected at app-start time
 		logger.debug("ctor: using decryptor class {}", decryptorClassName);
@@ -94,17 +93,17 @@ public class PortalAuthManager {
 	 * @return User ID if the ECOMP cookie is present and the sign-on process
 	 *         established a user ID; else null.
 	 */
-	public String valdiateEcompSso(HttpServletRequest request) {
+	public String validateEcompSso(HttpServletRequest request) {
 		// Check ECOMP Portal cookie
 		Cookie ep = getCookie(request, PortalApiConstants.EP_SERVICE);
 		if (ep == null) {
-			logger.debug("valdiateEcompSso: cookie not found: {}", PortalApiConstants.EP_SERVICE);
+			logger.debug("validateEcompSso: cookie not found: {}", PortalApiConstants.EP_SERVICE);
 			return null;
 		}
 		logger.trace("validateEcompSso: found cookie {}", PortalApiConstants.EP_SERVICE);
 		Cookie user = getCookie(request, userIdCookieName);
 		if (user == null) {
-			logger.debug("valdiateEcompSso: cookie not found: {}", userIdCookieName);
+			logger.debug("validateEcompSso: cookie not found: {}", userIdCookieName);
 			return null;
 		}
 		logger.trace("validateEcompSso: user cookie {}", userIdCookieName);
@@ -112,7 +111,7 @@ public class PortalAuthManager {
 		try {
 			userid = portalSdkDecryptor.decrypt(user.getValue());
 		} catch (CipherUtilException e) {
-			throw new IllegalArgumentException("valdiateEcompSso failed", e);
+			throw new IllegalArgumentException("validateEcompSso failed", e);
 		}
 		return userid;
 	}