X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=test%2Flogging_test.c;h=de183851cbd617c25637b208fbc7b79a2f8fa865;hb=353bafbe34c601eda6649ea7dcfdcf285d796d5a;hp=4ef975e6a251d5357048f8b7566758fe70aadb2d;hpb=fc5c77b3d78988aa407118235d7f5978642df753;p=ric-plt%2Flib%2Frmr.git

diff --git a/test/logging_test.c b/test/logging_test.c
index 4ef975e..de18385 100644
--- a/test/logging_test.c
+++ b/test/logging_test.c
@@ -20,10 +20,8 @@
 
 
 /*
-	Mnemonic:	symtab_test.c
-	Abstract:	This is the unit test module that will drive tests against
-				the symbol table portion of RMr.  Run with:
-					ksh unit_test.ksh symtab_test.c
+	Mnemonic:	logging_test.c
+	Abstract:	This test drives logging related tests.
 	Date:		1 April 2019
 	Author: 	E. Scott Daniels
 */
@@ -46,7 +44,7 @@ int main( ) {
 	setenv( "RMR_HR_LOG", "1", 1 );			// drive for coverage in init
 	setenv( "RMR_LOG_VLEVEL", "90", 1 );	// force test for out of range during init
 
-	rmr_vlog( RMR_VL_CRIT, "debug message should not be written\n" );		// force coverage with init call 
+	rmr_vlog( RMR_VL_CRIT, "crit message should be written\n" );		// force coverage; should drive init
 
 	llevel = rmr_vlog_init( );
 	errors += fail_if_equal( llevel, 99, "llevel was not reset by vlog init" );
@@ -59,20 +57,26 @@ int main( ) {
 	errors += fail_if_equal( llevel, -10, "vlog init did not catch out of range (neg) vlog" );
 
 	rmr_set_vlevel( 2 );
-	
+
+	/*
+		The remainder of these tests can be validated only by looking at the stderr
+		for the process. If any "should not be written" messages appear, then the
+		test should be marked as a failure. In a similar vein, the number of
+		expected "should be written" messages should be found.
+	*/
 	rmr_vlog( RMR_VL_DEBUG, "debug message should not be written\n" );
 	rmr_vlog( RMR_VL_INFO, "info message should not be written\n" );
 	rmr_vlog( RMR_VL_WARN, "warn message should not be written\n" );
 	rmr_vlog( RMR_VL_ERR, "error message should be written\n" );
 	rmr_vlog( RMR_VL_CRIT, "crit message should be written\n" );
-	
+
 	rmr_set_vlevel( 5 );
 	rmr_vlog( RMR_VL_DEBUG, "debug message should be written\n" );
 	rmr_vlog( RMR_VL_INFO, "info message should be written\n" );
 	rmr_vlog( RMR_VL_WARN, "warn message should be written\n" );
 	rmr_vlog( RMR_VL_ERR, "error message should be written\n" );
 	rmr_vlog( RMR_VL_CRIT, "crit message should be written\n" );
-	
+
 	rmr_set_vlevel( 0 );
 	rmr_vlog( RMR_VL_DEBUG, "debug message should not be written\n" );
 	rmr_vlog( RMR_VL_INFO, "info message should not be written\n" );
@@ -87,12 +91,15 @@ int main( ) {
 	rmr_vlog_force( RMR_VL_ERR, "error forced message should be written\n" );
 	rmr_vlog_force( RMR_VL_CRIT, "crit forced message should be written\n" );
 
+	// CAUTION -- this needs to be manually updated when 'should be' messages are added!!
+	fprintf( stderr, "<INFO> expeted 'should be' messages count is 13\n" );
 
 	rmr_vlog( -1, "out of range message might be written\n" );			// drive range checks
 	rmr_vlog( 10, "out of range message should not be written\n" );
 
-	rmr_vlog_force( -1, "out of range message might be written\n" );			// drive range checks
-	rmr_vlog_force( 10, "out of range message should not be written\n" );
+	rmr_vlog_force( -1, "out of range message might be written\n" );				// drive range checks
+	rmr_vlog_force( 10, "out of range message should be written (as debug)\n" );	// force with high log level should set to debug
 
+	test_summary( errors, "logging tests" );
 	return errors > 0;
 }