X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=capifcore%2Finternal%2Fprovidermanagement%2Fprovidermanagement.go;h=ebdfa9a217e784236df0ee82b3f2a83fa3f24cf3;hb=refs%2Fchanges%2F93%2F12493%2F3;hp=cb76c3a530339d2970e956454e0d6e366626741f;hpb=829338e085a03b58b6bb8a54b8c67bfffbf84952;p=nonrtric%2Fplt%2Fsme.git

diff --git a/capifcore/internal/providermanagement/providermanagement.go b/capifcore/internal/providermanagement/providermanagement.go
index cb76c3a..ebdfa9a 100644
--- a/capifcore/internal/providermanagement/providermanagement.go
+++ b/capifcore/internal/providermanagement/providermanagement.go
@@ -26,18 +26,18 @@ import (
 	"path"
 	"sync"
 
-	"github.com/labstack/echo/v4"
+	echo "github.com/labstack/echo/v4"
+	log "github.com/sirupsen/logrus"
 
 	"oransc.org/nonrtric/capifcore/internal/common29122"
 	provapi "oransc.org/nonrtric/capifcore/internal/providermanagementapi"
-
-	log "github.com/sirupsen/logrus"
 )
 
 //go:generate mockery --name ServiceRegister
 type ServiceRegister interface {
 	IsFunctionRegistered(functionId string) bool
 	GetAefsForPublisher(apfId string) []string
+	IsPublishingFunctionRegistered(apiProvFuncId string) bool
 }
 
 type ProviderManager struct {
@@ -69,14 +69,28 @@ func (pm *ProviderManager) GetAefsForPublisher(apfId string) []string {
 	return nil
 }
 
+func (pm *ProviderManager) IsPublishingFunctionRegistered(apiProvFuncId string) bool {
+	for _, provider := range pm.registeredProviders {
+		if provider.IsPublishingFunctionRegistered(apiProvFuncId) {
+			return true
+		}
+	}
+	return false
+}
+
 func (pm *ProviderManager) PostRegistrations(ctx echo.Context) error {
 	var newProvider provapi.APIProviderEnrolmentDetails
+	errMsg := "Unable to register provider due to %s"
 	if err := ctx.Bind(&newProvider); err != nil {
-		return sendCoreError(ctx, http.StatusBadRequest, "Invalid format for provider")
+		return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf(errMsg, "invalid format for provider"))
+	}
+
+	if err := pm.isProviderRegistered(newProvider); err != nil {
+		return sendCoreError(ctx, http.StatusForbidden, fmt.Sprintf(errMsg, err))
 	}
 
 	if err := newProvider.Validate(); err != nil {
-		return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf("Provider not valid due to %s", err))
+		return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf(errMsg, err))
 	}
 
 	pm.prepareNewProvider(&newProvider)
@@ -90,6 +104,15 @@ func (pm *ProviderManager) PostRegistrations(ctx echo.Context) error {
 	return nil
 }
 
+func (pm *ProviderManager) isProviderRegistered(newProvider provapi.APIProviderEnrolmentDetails) error {
+	for _, prov := range pm.registeredProviders {
+		if err := prov.ValidateAlreadyRegistered(newProvider); err != nil {
+			return err
+		}
+	}
+	return nil
+}
+
 func (pm *ProviderManager) prepareNewProvider(newProvider *provapi.APIProviderEnrolmentDetails) {
 	pm.lock.Lock()
 	defer pm.lock.Unlock()
@@ -129,6 +152,12 @@ func (pm *ProviderManager) PutRegistrationsRegistrationId(ctx echo.Context, regi
 		return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf(errMsg, err))
 	}
 
+	// Additional validation for PUT
+	if (updatedProvider.ApiProvDomId == nil) || (*updatedProvider.ApiProvDomId != registrationId) {
+		errDetail := "APIProviderEnrolmentDetails ApiProvDomId doesn't match path parameter"
+		return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf(errMsg, errDetail))
+	}
+
 	if err = pm.updateProvider(updatedProvider, registeredProvider); err != nil {
 		return sendCoreError(ctx, http.StatusBadRequest, fmt.Sprintf(errMsg, err))
 	}