X-Git-Url: https://gerrit.o-ran-sc.org/r/gitweb?a=blobdiff_plain;ds=sidebyside;f=E2Manager%2Fservices%2Frnib_data_service_test.go;h=07e2c4548ce6412216b6a33af56aab25ffc462cb;hb=7e2e493acba882641329f867cccb73b3d2a2d2d8;hp=fb86fe8293e66d0e0ca2618f9f45c86a01400503;hpb=2c9d450c93e4f0b312a68d39429efb685ec02022;p=ric-plt%2Fe2mgr.git

diff --git a/E2Manager/services/rnib_data_service_test.go b/E2Manager/services/rnib_data_service_test.go
index fb86fe8..07e2c45 100644
--- a/E2Manager/services/rnib_data_service_test.go
+++ b/E2Manager/services/rnib_data_service_test.go
@@ -24,11 +24,9 @@ import (
 	"e2mgr/configuration"
 	"e2mgr/logger"
 	"e2mgr/mocks"
-	"e2mgr/rNibWriter"
 	"fmt"
 	"gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common"
 	"gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities"
-	"gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/reader"
 	"github.com/stretchr/testify/assert"
 	"net"
 	"strings"
@@ -45,19 +43,15 @@ func setupRnibDataServiceTestWithMaxAttempts(t *testing.T, maxAttempts int) (*rN
 		t.Errorf("#... - failed to initialize logger, error: %s", err)
 	}
 
-	config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: maxAttempts}
+	config := &configuration.Configuration{RnibRetryIntervalMs: 10, MaxRnibConnectionAttempts: maxAttempts, RnibWriter: configuration.RnibWriterConfig{RanManipulationMessageChannel: "RAN_MANIPULATION", StateChangeMessageChannel: "RAN_CONNECTION_STATUS_CHANGE"}}
 
 	readerMock := &mocks.RnibReaderMock{}
-	rnibReaderProvider := func() reader.RNibReader {
-		return readerMock
-	}
+
 
 	writerMock := &mocks.RnibWriterMock{}
-	rnibWriterProvider := func() rNibWriter.RNibWriter {
-		return writerMock
-	}
 
-	rnibDataService := NewRnibDataService(logger, config, rnibReaderProvider, rnibWriterProvider)
+
+	rnibDataService := NewRnibDataService(logger, config, readerMock, writerMock)
 	assert.NotNil(t, rnibDataService)
 
 	return rnibDataService, readerMock, writerMock
@@ -263,6 +257,29 @@ func TestPingRnibOkOtherError(t *testing.T) {
 	assert.True(t, res)
 }
 
+func TestSuccessfulUpdateNodebInfoOnConnectionStatusInversion(t *testing.T) {
+	rnibDataService, _, writerMock := setupRnibDataServiceTest(t)
+	event := "event"
+
+	nodebInfo := &entities.NodebInfo{}
+	writerMock.On("UpdateNodebInfoOnConnectionStatusInversion", nodebInfo, event).Return(nil)
+
+	rnibDataService.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, event)
+	writerMock.AssertNumberOfCalls(t, "UpdateNodebInfoOnConnectionStatusInversion", 1)
+}
+
+func TestConnFailureUpdateNodebInfoOnConnectionStatusInversion(t *testing.T) {
+	rnibDataService, _, writerMock := setupRnibDataServiceTest(t)
+	event := "event"
+
+	nodebInfo := &entities.NodebInfo{}
+	mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}}
+	writerMock.On("UpdateNodebInfoOnConnectionStatusInversion", nodebInfo, event).Return(mockErr)
+
+	rnibDataService.UpdateNodebInfoOnConnectionStatusInversion(nodebInfo, event)
+	writerMock.AssertNumberOfCalls(t, "UpdateNodebInfoOnConnectionStatusInversion", 3)
+}
+
 //func TestConnFailureThenSuccessGetNodebIdList(t *testing.T) {
 //	rnibDataService, readerMock, _ := setupRnibDataServiceTest(t)
 //
@@ -277,3 +294,79 @@ func TestPingRnibOkOtherError(t *testing.T) {
 //	assert.True(t, strings.Contains(err.Error(),"connection failure", ))
 //	assert.Equal(t, nodeIds, res)
 //}
+
+func TestGetE2TInstanceConnFailure(t *testing.T) {
+	rnibDataService, readerMock, _ := setupRnibDataServiceTest(t)
+
+	address := "10.10.5.20:3200"
+	var e2tInstance *entities.E2TInstance = nil
+	mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}}
+	readerMock.On("GetE2TInstance", address).Return(e2tInstance, mockErr)
+
+	res, err := rnibDataService.GetE2TInstance(address)
+	readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 3)
+	assert.Nil(t, res)
+	assert.NotNil(t, err)
+}
+
+func TestGetE2TInstanceOkNoError(t *testing.T) {
+	rnibDataService, readerMock, _ := setupRnibDataServiceTest(t)
+
+	address := "10.10.5.20:3200"
+	e2tInstance := &entities.E2TInstance{}
+	readerMock.On("GetE2TInstance", address).Return(e2tInstance, nil)
+
+	res, err := rnibDataService.GetE2TInstance(address)
+	readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 1)
+	assert.Nil(t, err)
+	assert.Equal(t, e2tInstance, res)
+}
+
+func TestGetE2TInstanceOkOtherError(t *testing.T) {
+	rnibDataService, readerMock, _ := setupRnibDataServiceTest(t)
+
+	address := "10.10.5.20:3200"
+	var e2tInstance *entities.E2TInstance = nil
+	mockErr := &common.InternalError{Err: fmt.Errorf("non connection error")}
+	readerMock.On("GetE2TInstance", address).Return(e2tInstance, mockErr)
+
+	res, err := rnibDataService.GetE2TInstance(address)
+	readerMock.AssertNumberOfCalls(t, "GetE2TInstance", 1)
+	assert.Nil(t, res)
+	assert.NotNil(t, err)
+}
+
+func TestRemoveEnbConnFailure(t *testing.T) {
+	rnibDataService, _, writerMock := setupRnibDataServiceTest(t)
+
+	mockErr := &common.InternalError{Err: &net.OpError{Err: fmt.Errorf("connection error")}}
+	nodebInfo := &entities.NodebInfo{}
+	writerMock.On("RemoveEnb", nodebInfo).Return(mockErr)
+
+	err := rnibDataService.RemoveEnb(nodebInfo)
+	writerMock.AssertNumberOfCalls(t, "RemoveEnb", 3)
+	assert.NotNil(t, err)
+}
+
+func TestRemoveEnbOkNoError(t *testing.T) {
+	rnibDataService, _, writerMock := setupRnibDataServiceTest(t)
+
+	nodebInfo := &entities.NodebInfo{}
+	writerMock.On("RemoveEnb", nodebInfo).Return(nil)
+
+	err := rnibDataService.RemoveEnb(nodebInfo)
+	writerMock.AssertNumberOfCalls(t, "RemoveEnb", 1)
+	assert.Nil(t, err)
+}
+
+func TestRemoveEnbOtherError(t *testing.T) {
+	rnibDataService, _, writerMock := setupRnibDataServiceTest(t)
+
+	mockErr := &common.InternalError{Err: fmt.Errorf("non connection error")}
+	nodebInfo := &entities.NodebInfo{}
+	writerMock.On("RemoveEnb", nodebInfo).Return(mockErr)
+
+	err := rnibDataService.RemoveEnb(nodebInfo)
+	writerMock.AssertNumberOfCalls(t, "RemoveEnb", 1)
+	assert.NotNil(t, err)
+}
\ No newline at end of file