Improve unit-test coverage

[portal/ric-dashboard.git] / webapp-backend / src / test / java / org / oransc / ric / portal / dashboard / controller / AdminControllerExtension.java

diff --git a/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/controller/AdminController2.java b/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/controller/AdminControllerExtension.java
similarity index 59%
rename from webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/controller/AdminController2.java
rename to webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/controller/AdminControllerExtension.java
index c40c285..6217b08 100644 (file)
--- a/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/controller/AdminController2.java
+++ b/webapp-backend/src/test/java/org/oransc/ric/portal/dashboard/controller/AdminControllerExtension.java
@@ -23,31 +23,44 @@ import java.lang.invoke.MethodHandles;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+import org.springframework.http.HttpStatus;
 import org.springframework.http.MediaType;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.RequestMapping;
 import org.springframework.web.bind.annotation.RestController;
+import org.springframework.web.client.HttpClientErrorException;
 import org.springframework.web.client.RestClientResponseException;
 
 /**
- * Provides methods that throw exceptions to support testing.
+ * Extends the Admin controller with methods that throw exceptions to support
+ * testing.
  */
 @RestController
 @RequestMapping(value = AdminController.CONTROLLER_PATH, produces = MediaType.APPLICATION_JSON_VALUE)
-public class AdminController2 {
+public class AdminControllerExtension {
+
+       public static final String HTTP_STATUS_CODE_EXCEPTION_METHOD = "hscexception";
+       public static final String REST_CLIENT_RESPONSE_EXCEPTION_METHOD = "rcrexception";
+       public static final String RUNTIME_EXCEPTION_METHOD = "rexception";
 
        private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
 
-       @GetMapping("throw1")
-       public void throw1() {
+       @GetMapping(HTTP_STATUS_CODE_EXCEPTION_METHOD)
+       public void throwHttpStatusCodeException() {
+               logger.warn("throwing HttpStatusCodeException");
+               throw new HttpClientErrorException(HttpStatus.CHECKPOINT, "simulate http status code exception");
+       }
+
+       @GetMapping(REST_CLIENT_RESPONSE_EXCEPTION_METHOD)
+       public void throwRestClientResponseException() {
                logger.warn("throwing RestClientResponseException");
-               throw new RestClientResponseException("foo", 0, "bar", null, null, null);
+               throw new RestClientResponseException("simulate remote client failure", 0, "bar", null, null, null);
        }
 
-       @GetMapping("throw2")
-       public void throw2() {
+       @GetMapping(RUNTIME_EXCEPTION_METHOD)
+       public void throwRuntimeException() {
                logger.warn("throwing RuntimeException");
-               throw new RuntimeException("throw2");
+               throw new RuntimeException("simulate runtime failure");
        }
 
 }