Fix Sonar complains

[oam/nf-oam-adopter.git] / ves-nf-oam-adopter / ves-nf-oam-adopter-snmp-manager / src / main / java / org / o / ran / oam / nf / oam / adopter / snmp / manager / SnmpTrapListener.java

diff --git a/ves-nf-oam-adopter/ves-nf-oam-adopter-snmp-manager/src/main/java/org/o/ran/oam/nf/oam/adopter/snmp/manager/SnmpTrapListener.java b/ves-nf-oam-adopter/ves-nf-oam-adopter-snmp-manager/src/main/java/org/o/ran/oam/nf/oam/adopter/snmp/manager/SnmpTrapListener.java
index 09c7ff3..6c75680 100644 (file)
--- a/ves-nf-oam-adopter/ves-nf-oam-adopter-snmp-manager/src/main/java/org/o/ran/oam/nf/oam/adopter/snmp/manager/SnmpTrapListener.java
+++ b/ves-nf-oam-adopter/ves-nf-oam-adopter-snmp-manager/src/main/java/org/o/ran/oam/nf/oam/adopter/snmp/manager/SnmpTrapListener.java
@@ -19,22 +19,14 @@
 
 package org.o.ran.oam.nf.oam.adopter.snmp.manager;
 
-import com.google.gson.Gson;
-import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
 import java.io.IOException;
-import java.time.LocalDateTime;
-import java.time.ZoneId;
-import java.util.Optional;
 import org.o.ran.oam.nf.oam.adopter.api.VesEventNotifier;
 import org.o.ran.oam.nf.oam.adopter.snmp.manager.api.TimeZoneOffsetService;
 import org.o.ran.oam.nf.oam.adopter.snmp.manager.mapper.SnmpMapper;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.snmp4j.CommandResponder;
-import org.snmp4j.CommandResponderEvent;
 import org.snmp4j.MessageDispatcher;
 import org.snmp4j.MessageDispatcherImpl;
-import org.snmp4j.PDU;
 import org.snmp4j.Snmp;
 import org.snmp4j.mp.MPv2c;
 import org.snmp4j.smi.UdpAddress;
@@ -42,32 +34,25 @@ import org.snmp4j.transport.DefaultUdpTransportMapping;
 import org.snmp4j.util.MultiThreadedMessageDispatcher;
 import org.snmp4j.util.ThreadPool;
 
-final class SnmpTrapListener implements CommandResponder, Runnable {
+final class SnmpTrapListener implements Runnable {
 
     private static final Logger LOG = LoggerFactory.getLogger(SnmpTrapListener.class);
     private static final int THREADS_SIZE = 2;
     private final String hostPortAddress;
-    private final SnmpMapper mapper;
-    private final VesEventNotifier vesEventNotifier;
-    private final Gson gson = new Gson();
-    private final TimeZoneOffsetService timeZoneOffsetService;
+    private final SnmpCommandResponder commandResponder;
 
     public SnmpTrapListener(final String host, final Integer port, final SnmpMapper mapper,
             final VesEventNotifier vesEventNotifier, final TimeZoneOffsetService timeZoneOffsetService) {
         LOG.info("SnmpTrapListener listening on {}:{}", host, port);
         this.hostPortAddress = host + "/" + port;
-        this.mapper = mapper;
-        this.vesEventNotifier = vesEventNotifier;
-        this.timeZoneOffsetService = timeZoneOffsetService;
+        this.commandResponder = new SnmpCommandResponder(timeZoneOffsetService, mapper, vesEventNotifier);
     }
 
     @Override
     public synchronized void run() {
-        try (final DefaultUdpTransportMapping snmpTarget = new DefaultUdpTransportMapping(
-                new UdpAddress(hostPortAddress))) {
-            final ThreadPool threadPool = ThreadPool.create("SNMP_V2_Listener", THREADS_SIZE);
-            final MessageDispatcher dispatcher =
-                    new MultiThreadedMessageDispatcher(threadPool, new MessageDispatcherImpl());
+        try (final var snmpTarget = new DefaultUdpTransportMapping(new UdpAddress(hostPortAddress))) {
+            final var threadPool = ThreadPool.create("SNMP_V2_Listener", THREADS_SIZE);
+            final var dispatcher = new MultiThreadedMessageDispatcher(threadPool, new MessageDispatcherImpl());
             dispatcher.addMessageProcessingModel(new MPv2c());
             listenSnmp(dispatcher, snmpTarget);
         } catch (final IOException e) {
@@ -75,41 +60,17 @@ final class SnmpTrapListener implements CommandResponder, Runnable {
         }
     }
 
-    @SuppressFBWarnings("WA_NOT_IN_LOOP")
-    private void listenSnmp(final MessageDispatcher dispatcher, final DefaultUdpTransportMapping snmpTarget) {
-        try (final Snmp snmp = new Snmp(dispatcher, snmpTarget)) {
-            snmp.addCommandResponder(this);
-            snmpTarget.listen();
-            LOG.debug("Listening on {}", snmpTarget);
-            wait();
-        } catch (final InterruptedException | IOException ex) {
-            Thread.currentThread().interrupt();
-        }
-    }
-
-    /**
-     * This method will be called whenever a pdu is received on the given port
-     * specified in the listen() method.
-     */
-    @Override
-    public synchronized void processPdu(final CommandResponderEvent cmdRespEvent) {
-        LOG.info("Received PDU");
-        final PDU pdu = cmdRespEvent.getPDU();
-        if (pdu == null) {
-            LOG.warn("Ignoring PDU.");
-            return;
-        }
-
-        final UdpAddress address = (UdpAddress) cmdRespEvent.getPeerAddress();
-        final ZoneId optZoneId = timeZoneOffsetService.getTimeZone(address.getInetAddress().getHostAddress());
-        final String timeZone = Optional.ofNullable(optZoneId)
-            .map(zoneId -> "UTC" + LocalDateTime.now().atZone(zoneId).getOffset().toString()).orElse(null);
-
-        mapper.toEvent(address, timeZone, pdu)
-                .flatMapCompletable(vesEventNotifier::notifyEvents)
-                .doOnSubscribe(result -> LOG.debug("SNMP Trap processing started"))
-                .doOnComplete(() -> LOG.debug("SNMP Trap processed successfully"))
-                .doOnError(error -> LOG.error("Failed to process SNMP Trap", error))
-                .subscribe();
+    private synchronized void listenSnmp(final MessageDispatcher dispatcher,
+            final DefaultUdpTransportMapping snmpTarget) {
+        do {
+            try (final var snmp = new Snmp(dispatcher, snmpTarget)) {
+                snmp.addCommandResponder(commandResponder);
+                snmpTarget.listen();
+                LOG.debug("Listening on {}", snmpTarget);
+                wait();
+            } catch (final InterruptedException | IOException ex) {
+                Thread.currentThread().interrupt();
+            }
+        } while (snmpTarget.isListening());
     }
 }