Fix Sonar complains

[oam/nf-oam-adopter.git] / ves-nf-oam-adopter / ves-nf-oam-adopter-mock / src / main / java / org / o / ran / oam / nf / oam / adopter / mock / app / SnmpNotifier.java

diff --git a/ves-nf-oam-adopter/ves-nf-oam-adopter-mock/src/main/java/org/o/ran/oam/nf/oam/adopter/mock/app/SnmpNotifier.java b/ves-nf-oam-adopter/ves-nf-oam-adopter-mock/src/main/java/org/o/ran/oam/nf/oam/adopter/mock/app/SnmpNotifier.java
index 388a1ce..3f759f2 100644 (file)
--- a/ves-nf-oam-adopter/ves-nf-oam-adopter-mock/src/main/java/org/o/ran/oam/nf/oam/adopter/mock/app/SnmpNotifier.java
+++ b/ves-nf-oam-adopter/ves-nf-oam-adopter-mock/src/main/java/org/o/ran/oam/nf/oam/adopter/mock/app/SnmpNotifier.java
@@ -47,7 +47,7 @@ public class SnmpNotifier {
 
     private final HashMap<String, String> alarmTrap;
     private final HashMap<String, String> clearTrap;
-    private final CommunityTarget target;
+    private final CommunityTarget<UdpAddress> target;
 
     /**
      * Default constructor.
@@ -74,7 +74,7 @@ public class SnmpNotifier {
         sendTrap(target, clearTrap, "clear");
     }
 
-    private static void sendTrap(final CommunityTarget target, final HashMap<String, String> trap,
+    private static void sendTrap(final CommunityTarget<UdpAddress> target, final HashMap<String, String> trap,
             final String trapType) throws IOException {
         final PDU pdu = new PDU();
         pdu.setType(PDU.TRAP);
@@ -86,10 +86,9 @@ public class SnmpNotifier {
             }
         });
 
-
-        final Snmp snmp = new Snmp(new DefaultUdpTransportMapping());
-        snmp.send(pdu, target, null, null);
-        snmp.close();
-        LOG.info("Trap {} sent successfully.", trapType);
+        try (final Snmp snmp = new Snmp(new DefaultUdpTransportMapping())) {
+            snmp.send(pdu, target, null, null);
+            LOG.info("Trap {} sent successfully.", trapType);
+        }
     }
 }