Correct bug identified in static analysis

[ric-plt/lib/rmr.git] / test / rmr_si_api_static_test.c

diff --git a/test/rmr_si_api_static_test.c b/test/rmr_si_api_static_test.c
index 528e9cc..5f0a4f4 100644 (file)
--- a/test/rmr_si_api_static_test.c
+++ b/test/rmr_si_api_static_test.c
@@ -66,6 +66,30 @@
 #include "rmr.h"
 #include "rmr_agnostic.h"
 
+/*
+       Driving ep counts is tricky when trying to do it as a part of the rts function, so
+       we drive that code on it's own.
+*/
+static int test_ep_counts() {
+       int errors = 0;
+       struct endpoint ep;                     // need a dummy endpoint
+
+       memset( &ep, 0, sizeof( ep ) );
+
+       incr_ep_counts( RMR_OK, &ep );
+       errors += fail_if_false(  ep.scounts[EPSC_GOOD] == 1, "ep inc good counter had bad value" );
+
+       incr_ep_counts( RMR_ERR_RETRY, &ep );
+       errors += fail_if_false(  ep.scounts[EPSC_TRANS] == 1, "ep inc trans counter had bad value" );
+
+       incr_ep_counts( 99, &ep );                              // any non-retry/ok value
+       errors += fail_if_false(  ep.scounts[EPSC_FAIL] == 1, "ep inc fail counter had bad value" );
+
+       incr_ep_counts( RMR_OK, NULL );                 // ensure nil pointer doesn't crash us
+
+       return errors;
+}
+
 static int rmr_api_test( ) {
        int             errors = 0;
        void*   rmc;                            // route manager context
@@ -96,8 +120,8 @@ static int rmr_api_test( ) {
        v = strcmp( ((uta_ctx_t *) rmc2)->my_name, "somehost:6789" );
        errors += fail_not_equal( v, 0, "source name not set from environment variable (see previous info)" );
        free_ctx( rmc2 );                       // coverage
-       
-       unsetenv( "RMR_SRC_ID" );                                                                                               // context should NOT have our artificial name 
+
+       unsetenv( "RMR_SRC_ID" );                                                                                               // context should NOT have our artificial name
        if( (rmc2 = rmr_init( NULL, 1024, FL_NOTHREAD )) == NULL ) {                    // drive default port selector code
                errors += fail_if_nil( rmc, "rmr_init returned a nil pointer when driving for default port "  );
        }
@@ -112,7 +136,7 @@ static int rmr_api_test( ) {
        msg = rmr_alloc_msg( NULL,  1024 );                                                                     // should return nil pointer
        errors += fail_not_nil( msg, "rmr_alloc_msg didn't return nil when given nil context "  );
 
-       
+
        msg = rmr_alloc_msg( rmc, 2048 );                               // allocate larger than default size given on init
        errors += fail_if_nil( msg, "rmr_alloc_msg returned nil msg pointer "  );
        if( msg ) {
@@ -210,9 +234,8 @@ static int rmr_api_test( ) {
                max_tries--;
        }
 
-
        // ----- the queue load and disc cb tests should be last! -----------------------------
-       for( i = 0; i < 4000; i++ ) {                   // test ring drop 
+       for( i = 0; i < 4000; i++ ) {                   // test ring drop
                if( msg == NULL ) {
                        msg = rmr_alloc_msg( rmc, 2048 );                               // get a buffer with a transport header
                }
@@ -257,6 +280,37 @@ static int rmr_api_test( ) {
        rmr_close( rmc );                       // no return to check; drive for coverage
 
 
+       // --------------- nil pointer exception checks
+       rmr_rcv_specific( NULL, NULL, "foo", 0 );
+       rmr_mt_rcv( NULL, NULL, 0 );
+       mt_call( NULL, NULL, 0, 1, NULL );
+       rmr_mt_call( NULL, NULL, 0, 1 );
+       rmr_set_low_latency( NULL );
+       rmr_set_fack( NULL );
+
+
+       msg2 = rmr_alloc_msg( rmc,  1024 );
+       msg2 = rmr_rcv_msg( NULL, msg2 );
+       if( msg2 != NULL ) {
+               errors += fail_if( msg2->state == RMR_OK, "nil context check for rcv msg returned OK" );
+       }
+       msg2 = rmr_torcv_msg( NULL, msg2, 200 );
+       if( msg2 != NULL ) {
+               errors += fail_if( msg2->state == RMR_OK, "nil context check for torcv msg returned OK" );
+       }
+
+       //  ----- thread start coverage ---------------------------------------------------------------------------
+       setenv( "RMR_WARNINGS", "1", 1 );       // force non-default branches during these tests
+       setenv( "RMR_SRC_NAMEONLY", "1", 1 );
+
+       rmr_init( ":6789", 1024, 0 );           // threaded mode with defined/default RM target
+       setenv( "RMR_RTG_SVC", "-1", 1 );       // force into static table mode
+       rmr_init( ":6789", 1024, 0 );           // threaded mode with static table
+
+
+       // ---- some things must be pushed specifically for edge cases and such ------------------------------------
+       errors += test_ep_counts();
+       init_err( "test error message", rmc, rmc2, ENOMEM );            // drive for coverage
 
        // --------------- phew, done ------------------------------------------------------------------------------