Tweak unit tests to save coverage in common dir

[ric-app/mc.git] / sidecars / listener / src / mcl.c

diff --git a/sidecars/listener/src/mcl.c b/sidecars/listener/src/mcl.c
index a50924b..0077e96 100644 (file)
--- a/sidecars/listener/src/mcl.c
+++ b/sidecars/listener/src/mcl.c
@@ -321,6 +321,16 @@ static void wr_stats( void* st, void* entry, char const* name, void* thing, void
 
                fifo->wcount_rp = 0;            // reset the report counts
                fifo->drops_rp = 0;
+               return;                                         // return here to avoid sonar required hack below
+       }
+
+       /*
+               Sonar doesn't grok the fact that for callback functions some parms are naturally
+               ignored. So, to eliminate the 5 code smells because we only care about thing, we
+               have this hack....
+       */
+       if( st == NULL && entry == NULL && name == NULL && data == NULL ) {
+               fprintf( stderr, "mdcl: all parms to callback stats were nil\n" );
        }
 }
 
@@ -421,10 +431,10 @@ extern    void* mcl_mk_context( const char* dir ) {
        delimeter. We assume best case most likely and handle it as such.
 */
 static void read_header( int fd, char* buf ) {
-       int len;
-       int need = MCL_EXHDR_SIZE;              // total needed
-       int dneed;                                              // delimieter needed
-       char*   rp;                             // read position in buf
+       size_t len;
+       size_t need = MCL_EXHDR_SIZE;           // total needed
+       size_t dneed;                                           // delimieter needed
+       char*   rp;                                                     // read position in buf
 
        len = read( fd, buf, need );
        if( len == need && strncmp( buf, MCL_DELIM, strlen( MCL_DELIM )) == 0 ) {       // best case, most likely