Code Review / nonrtric.git / blobdiff
? search:
summary | shortlog | log | commit | commitdiff | review | tree
raw | inline | side by side
Clean up A1 controller code
[nonrtric.git] / sdnc-a1-controller / northbound / generic-resource-api / provider / src / test / java / org / onap / sdnc / northbound / VnfTopologyOperationRPCTest.java
diff --git a/sdnc-a1-controller/northbound/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/VnfTopologyOperationRPCTest.java b/sdnc-a1-controller/northbound/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/VnfTopologyOperationRPCTest.java
deleted file mode 100644 (file)
index 3c7b6ff..0000000
--- a/sdnc-a1-controller/northbound/generic-resource-api/provider/src/test/java/org/onap/sdnc/northbound/VnfTopologyOperationRPCTest.java
+++ /dev/null
@@ -1,208 +0,0 @@
-package org.onap.sdnc.northbound;
-
-import static org.junit.Assert.assertEquals;
-import static org.mockito.Mockito.mock;
-import static org.mockito.Mockito.when;
-import static org.onap.sdnc.northbound.GenericResourceApiProvider.APP_NAME;
-import static org.onap.sdnc.northbound.GenericResourceApiProvider.NO_SERVICE_LOGIC_ACTIVE;
-import static org.onap.sdnc.northbound.GenericResourceApiProvider.NULL_OR_EMPTY_ERROR_PARAM;
-import static org.onap.sdnc.northbound.util.MDSALUtil.build;
-import static org.onap.sdnc.northbound.util.MDSALUtil.exec;
-import static org.onap.sdnc.northbound.util.MDSALUtil.requestInformation;
-import static org.onap.sdnc.northbound.util.MDSALUtil.sdncRequestHeader;
-import static org.onap.sdnc.northbound.util.MDSALUtil.serviceInformationBuilder;
-import static org.onap.sdnc.northbound.util.MDSALUtil.serviceResponseInformation;
-import static org.onap.sdnc.northbound.util.MDSALUtil.vnfInformationBuilder;
-import static org.onap.sdnc.northbound.util.MDSALUtil.vnfResponseInformation;
-import static org.onap.sdnc.northbound.util.MDSALUtil.vnfTopologyOperationInput;
-import static org.onap.sdnc.northbound.util.MDSALUtil.vnfTopologyOperationOutput;
-
-import org.junit.Before;
-import org.junit.Test;
-import org.junit.runner.RunWith;
-import org.mockito.Mockito;
-import org.mockito.runners.MockitoJUnitRunner;
-import org.onap.sdnc.northbound.util.PropBuilder;
-import org.opendaylight.controller.md.sal.binding.api.DataBroker;
-import org.opendaylight.controller.md.sal.binding.api.WriteTransaction;
-import org.opendaylight.controller.md.sal.common.api.data.TransactionChainClosedException;
-import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.VnfTopologyOperationInput;
-import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.VnfTopologyOperationOutput;
-import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.request.information.RequestInformation;
-import org.opendaylight.yang.gen.v1.org.onap.sdnc.northbound.generic.resource.rev170824.sdnc.request.header.SdncRequestHeader.SvcAction;
-import org.opendaylight.yangtools.yang.common.RpcResult;
-
-@RunWith(MockitoJUnitRunner.class)
-public class VnfTopologyOperationRPCTest extends GenericResourceApiProviderTest {
-
-    private static final String SVC_OPERATION = "vnf-topology-operation";
-
-    @Before
-    public void setUp() throws Exception {
-        super.setUp();
-        svcClient.setScvOperation(SVC_OPERATION);
-    }
-
-    @Test
-    public void should_fail_when_service_info_not_present() throws Exception {
-
-        VnfTopologyOperationInput input = build(vnfTopologyOperationInput());
-
-        VnfTopologyOperationOutput output =
-            exec(genericResourceApiProvider::vnfTopologyOperation, input, RpcResult::getResult);
-
-        assertEquals("404", output.getResponseCode());
-        assertEquals(NULL_OR_EMPTY_ERROR_PARAM, output.getResponseMessage());
-        assertEquals("Y", output.getAckFinalIndicator());
-    }
-
-
-    /*
-    @Test
-    public void should_fail_when_invalid_vnf_id() throws Exception {
-
-        VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
-            .setServiceInformation(build(serviceInformationBuilder().
-                setServiceInstanceId("test-service-instance-id")
-            ))
-        );
-
-        VnfTopologyOperationOutput output =
-            exec(genericResourceApiProvider::vnfTopologyOperation, input, RpcResult::getResult);
-
-        assertEquals("404", output.getResponseCode());
-        assertEquals("invalid input, null or empty vnf-id", output.getResponseMessage());
-        assertEquals("Y", output.getAckFinalIndicator());
-    }*/
-
-
-    @Test
-    public void should_fail_when_client_execution_failed() throws Exception {
-
-        svcClient.mockHasGraph(true);
-        svcClient.mockExecute(new RuntimeException("test exception"));
-
-        VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
-            .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")
-            ))
-            .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")
-            ))
-        );
-
-        VnfTopologyOperationOutput output =
-            exec(genericResourceApiProvider::vnfTopologyOperation, input, RpcResult::getResult);
-
-        assertEquals("500", output.getResponseCode());
-        assertEquals("test exception", output.getResponseMessage());
-        assertEquals("Y", output.getAckFinalIndicator());
-    }
-
-    @Test
-    public void should_fail_when_client_has_no_graph() throws Exception {
-
-        svcClient.mockHasGraph(false);
-
-        VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
-            .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")
-            ))
-            .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")
-            ))
-        );
-
-        VnfTopologyOperationOutput output =
-            exec(genericResourceApiProvider::vnfTopologyOperation, input, RpcResult::getResult);
-
-        assertEquals("503", output.getResponseCode());
-        assertEquals(NO_SERVICE_LOGIC_ACTIVE + APP_NAME + ": '" + SVC_OPERATION + "'", output.getResponseMessage());
-        assertEquals("Y", output.getAckFinalIndicator());
-    }
-
-    @Test
-    public void should_fail_when_failed_to_update_mdsal() throws Exception {
-
-        PropBuilder svcResultProp = svcClient.createExecuteOKResult();
-        svcClient.mockExecute(svcResultProp);
-        svcClient.mockHasGraph(true);
-        WriteTransaction mockWriteTransaction = mock(WriteTransaction.class);
-        when(mockWriteTransaction.submit()).thenThrow(new TransactionChainClosedException("test exception"));
-
-        DataBroker spyDataBroker = Mockito.spy(dataBroker);
-        when(spyDataBroker.newWriteOnlyTransaction()).thenReturn(mockWriteTransaction);
-        genericResourceApiProvider.setDataBroker(spyDataBroker);
-
-        VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
-            .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")
-            ))
-            .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")
-            ))
-        );
-
-        VnfTopologyOperationOutput output =
-            exec(genericResourceApiProvider::vnfTopologyOperation, input, RpcResult::getResult);
-
-        assertEquals("500", output.getResponseCode());
-        assertEquals("test exception", output.getResponseMessage());
-        assertEquals("Y", output.getAckFinalIndicator());
-    }
-
-    @Test
-    public void should_complete_with_success_when_no_errors() throws Exception {
-
-        svcClient.mockHasGraph(true);
-        PropBuilder svcResultProp = svcClient.createExecuteOKResult();
-        svcClient.mockExecute(svcResultProp);
-
-        VnfTopologyOperationInput input = build(vnfTopologyOperationInput()
-            .setSdncRequestHeader(build(sdncRequestHeader()
-                .setSvcRequestId("test-svc-request-id")
-                .setSvcAction(SvcAction.Assign)
-            ))
-            .setRequestInformation(build(requestInformation()
-                .setRequestId("test-request-id")
-                .setRequestAction(RequestInformation.RequestAction.CreateServiceInstance)
-            ))
-            .setServiceInformation(build(serviceInformationBuilder()
-                .setServiceInstanceId("test-service-instance-id")
-            ))
-            .setVnfInformation(build(vnfInformationBuilder()
-                .setVnfId("test-vnf-id")
-            ))
-        );
-
-        VnfTopologyOperationOutput output =
-            exec(genericResourceApiProvider::vnfTopologyOperation, input, RpcResult::getResult);
-
-        assertEquals("200", output.getResponseCode());
-        assertEquals("OK", output.getResponseMessage());
-        assertEquals("Y", output.getAckFinalIndicator());
-
-        VnfTopologyOperationOutput expectedVnfTopologyOperationOutput = createExpectedOutput(svcResultProp,
-            input);
-        assertEquals(expectedVnfTopologyOperationOutput, output);
-    }
-
-    private VnfTopologyOperationOutput createExpectedOutput(PropBuilder svcResultProp,
-        VnfTopologyOperationInput vnfTopologyOperationInput) {
-        return build(
-            vnfTopologyOperationOutput()
-                .setSvcRequestId(vnfTopologyOperationInput.getSdncRequestHeader().getSvcRequestId())
-                .setResponseCode(svcResultProp.get(svcClient.errorCode))
-                .setAckFinalIndicator(svcResultProp.get(svcClient.ackFinal))
-                .setResponseMessage(svcResultProp.get(svcClient.errorMessage))
-                .setServiceResponseInformation(build(serviceResponseInformation()
-                    .setInstanceId(vnfTopologyOperationInput.getServiceInformation().getServiceInstanceId())
-                    .setObjectPath(svcResultProp.get(svcClient.serviceObjectPath))
-                ))
-                .setVnfResponseInformation(build(vnfResponseInformation()
-                    .setInstanceId(vnfTopologyOperationInput.getVnfInformation().getVnfId())
-                    .setObjectPath(svcResultProp.get(svcClient.vnfObjectPath))
-                ))
-        );
-    }
-}
Parent repository for the O-RAN SC Non Real-Time RIC (NONRTRIC) project.