import (
"errors"
- "gerrit.ranco-dev-tools.eastus.cloudapp.azure.com/ric-plt/nodeb-rnib.git/common"
- "gerrit.ranco-dev-tools.eastus.cloudapp.azure.com/ric-plt/nodeb-rnib.git/entities"
+ "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/common"
+ "gerrit.o-ran-sc.org/r/ric-plt/nodeb-rnib.git/entities"
"github.com/golang/protobuf/proto"
"github.com/stretchr/testify/assert"
"testing"
assert.Equal(t, 0, created, "number of created objects in the readerPool should be 0")
}
-func initSdlInstanceMock(namespace string, poolSize int) * MockSdlInstance {
- sdlInstanceMock := new( MockSdlInstance)
+func initSdlInstanceMock(namespace string, poolSize int) *MockSdlInstance {
+ sdlInstanceMock := new(MockSdlInstance)
initPool(poolSize, func() interface{} {
sdlI := common.ISdlInstance(sdlInstanceMock)
return &rNibReaderInstance{sdl: &sdlI, namespace: namespace}
nb.Ip = "localhost"
nb.Port = 5656
enb := entities.Enb{}
- cell := entities.ServedCellInfo{Tac:"tac"}
+ cell := entities.ServedCellInfo{Tac: "tac"}
enb.ServedCells = []*entities.ServedCellInfo{&cell}
- nb.Configuration = &entities.NodebInfo_Enb{Enb:&enb}
+ nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb}
var e error
data, err := proto.Marshal(&nb)
if err != nil {
t.Errorf("#rNibReader_test.TestGetNb - Failed to marshal ENB instance. Error: %v", err)
}
- ret := map[string]interface{}{"RAN:" + name:string(data)}
+ ret := map[string]interface{}{"RAN:" + name: string(data)}
sdlInstanceMock.On("Get", []string{"RAN:" + name}).Return(ret, e)
getNb, er := w.GetNodeb(name)
assert.Nil(t, er)
assert.NotNil(t, er)
assert.Nil(t, getNb)
assert.Equal(t, 1, er.GetCode())
- assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.GetNodeb - responding node name not found", er.Error())
+ assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.getNodeb - responding node not found. Key: RAN:name", er.Error())
}
func TestGetNodeBUnmarshalFailure(t *testing.T) {
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- ret := make( map[string]interface{}, 1)
- ret["RAN:" + name] = "data"
+ ret := make(map[string]interface{}, 1)
+ ret["RAN:"+name] = "data"
sdlInstanceMock.On("Get", []string{"RAN:" + name}).Return(ret, e)
getNb, er := w.GetNodeb(name)
assert.NotNil(t, er)
nb.Ip = "localhost"
nb.Port = 5656
enb := entities.Enb{}
- cell := entities.ServedCellInfo{Tac:"tac"}
+ cell := entities.ServedCellInfo{Tac: "tac"}
enb.ServedCells = []*entities.ServedCellInfo{&cell}
- nb.Configuration = &entities.NodebInfo_Enb{Enb:&enb}
+ nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb}
var e error
data, err := proto.Marshal(&nb)
if err != nil {
t.Errorf("#rNibReader_test.GetNodeBCellsList - Failed to marshal ENB instance. Error: %v", err)
}
- ret := map[string]interface{}{"RAN:" + name:string(data)}
+ ret := map[string]interface{}{"RAN:" + name: string(data)}
sdlInstanceMock.On("Get", []string{"RAN:" + name}).Return(ret, e)
cells, er := w.GetCellList(name)
assert.Nil(t, er)
nb.Port = 5656
nb.NodeType = entities.Node_GNB
gnb := entities.Gnb{}
- cell := entities.ServedNRCell{ServedNrCellInformation:&entities.ServedNRCellInformation{NrPci:10}}
+ cell := entities.ServedNRCell{ServedNrCellInformation: &entities.ServedNRCellInformation{NrPci: 10}}
gnb.ServedNrCells = []*entities.ServedNRCell{&cell}
- nb.Configuration = &entities.NodebInfo_Gnb{Gnb:&gnb}
+ nb.Configuration = &entities.NodebInfo_Gnb{Gnb: &gnb}
var e error
data, err := proto.Marshal(&nb)
if err != nil {
t.Errorf("#rNibReader_test.GetNodeBCellsList - Failed to marshal GNB instance. Error: %v", err)
}
- ret := map[string]interface{}{"RAN:" + name:string(data)}
+ ret := map[string]interface{}{"RAN:" + name: string(data)}
sdlInstanceMock.On("Get", []string{"RAN:" + name}).Return(ret, e)
cells, er := w.GetCellList(name)
assert.Nil(t, er)
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- ret := make( map[string]interface{}, 1)
- ret["RAN:" + name] = "data"
+ ret := make(map[string]interface{}, 1)
+ ret["RAN:"+name] = "data"
sdlInstanceMock.On("Get", []string{"RAN:" + name}).Return(ret, e)
cells, er := w.GetCellList(name)
assert.NotNil(t, er)
assert.NotNil(t, er)
assert.Nil(t, cells)
assert.Equal(t, 1, er.GetCode())
- assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.GetNodeb - responding node name not found", er.Error())
+ assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.getNodeb - responding node not found. Key: RAN:name", er.Error())
}
func TestGetNodeBCellsListNotFoundFailureEnb(t *testing.T) {
nb.Ip = "localhost"
nb.Port = 5656
enb := entities.Enb{}
- nb.Configuration = &entities.NodebInfo_Enb{Enb:&enb}
+ nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb}
var e error
data, err := proto.Marshal(&nb)
if err != nil {
t.Errorf("#rNibReader_test.TestGetNbCellsListNotFoundFailure - Failed to marshal ENB instance. Error: %v", err)
}
- ret := map[string]interface{}{"RAN:" + name:string(data)}
+ ret := map[string]interface{}{"RAN:" + name: string(data)}
sdlInstanceMock.On("Get", []string{"RAN:" + name}).Return(ret, e)
_, er := w.GetCellList(name)
assert.NotNil(t, er)
nb.Ip = "localhost"
nb.Port = 5656
gnb := entities.Gnb{}
- nb.Configuration = &entities.NodebInfo_Gnb{Gnb:&gnb}
+ nb.Configuration = &entities.NodebInfo_Gnb{Gnb: &gnb}
var e error
data, err := proto.Marshal(&nb)
if err != nil {
t.Errorf("#rNibReader_test.TestGetNbCellsListNotFoundFailure - Failed to marshal ENB instance. Error: %v", err)
}
- ret := map[string]interface{}{"RAN:" + name:string(data)}
+ ret := map[string]interface{}{"RAN:" + name: string(data)}
sdlInstanceMock.On("Get", []string{"RAN:" + name}).Return(ret, e)
_, er := w.GetCellList(name)
assert.NotNil(t, er)
var e error
instanceMock.On("Close").Return(e)
Close()
- assert.Panics(t, func(){Close()})
+ assert.Panics(t, func() { Close() })
}
func TestCloseFailure(t *testing.T) {
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- sdlInstanceMock.On("GetMembers", "GNB").Return([]string{"data"}, e)
+ sdlInstanceMock.On("GetMembers", GnbType).Return([]string{"data"}, e)
ids, er := w.GetListGnbIds()
assert.NotNil(t, er)
assert.Nil(t, ids)
w := GetRNibReader()
e := errors.New(errMsg)
var data []string
- sdlInstanceMock.On("GetMembers", "GNB").Return(data, e)
+ sdlInstanceMock.On("GetMembers", GnbType).Return(data, e)
ids, er := w.GetListGnbIds()
assert.NotNil(t, er)
assert.Nil(t, ids)
assert.Equal(t, 2, er.GetCode())
- assert.EqualValues(t, errMsgExpected,er.Error())
+ assert.EqualValues(t, errMsgExpected, er.Error())
+}
+
+func TestGetListNodesIdsGnbSdlgoFailure(t *testing.T) {
+
+ readerPool = nil
+ sdlInstanceMock := initSdlInstanceMock(namespace, 1)
+ w := GetRNibReader()
+
+ name := "name"
+ plmnId := "02f829"
+ nbId := "4a952a0a"
+ nbIdentity := &entities.NbIdentity{InventoryName: name, GlobalNbId: &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}}
+ var nilError error
+ data, err := proto.Marshal(nbIdentity)
+ if err != nil {
+ t.Errorf("#rNibReader_test.TestGetListNodesIdsGnbSdlgoFailure - Failed to marshal nodeb identity entity. Error: %v", err)
+ }
+ sdlInstanceMock.On("GetMembers", EnbType).Return([]string{string(data)}, nilError)
+
+ errMsg := "expected Sdlgo error"
+ errMsgExpected := "2 INTERNAL_ERROR - expected Sdlgo error"
+ expectedError := errors.New(errMsg)
+ var nilData []string
+ sdlInstanceMock.On("GetMembers", GnbType).Return(nilData, expectedError)
+
+ ids, er := w.GetListNodebIds()
+ assert.NotNil(t, er)
+ assert.Nil(t, ids)
+ assert.Equal(t, 2, er.GetCode())
+ assert.EqualValues(t, errMsgExpected, er.Error())
+}
+
+func TestGetListNodesIdsEnbSdlgoFailure(t *testing.T) {
+
+ readerPool = nil
+ sdlInstanceMock := initSdlInstanceMock(namespace, 1)
+ w := GetRNibReader()
+
+ name := "name"
+ plmnId := "02f829"
+ nbId := "4a952a0a"
+ nbIdentity := &entities.NbIdentity{InventoryName: name, GlobalNbId: &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}}
+ var nilError error
+ data, err := proto.Marshal(nbIdentity)
+ if err != nil {
+ t.Errorf("#rNibReader_test.TestGetListNodesIdsEnbSdlgoFailure - Failed to marshal nodeb identity entity. Error: %v", err)
+ }
+ sdlInstanceMock.On("GetMembers", GnbType).Return([]string{string(data)}, nilError)
+
+ errMsg := "expected Sdlgo error"
+ errMsgExpected := "2 INTERNAL_ERROR - expected Sdlgo error"
+ expectedError := errors.New(errMsg)
+ var nilData []string
+ sdlInstanceMock.On("GetMembers", EnbType).Return(nilData, expectedError)
+
+ ids, er := w.GetListNodebIds()
+ assert.NotNil(t, er)
+ assert.Nil(t, ids)
+ assert.Equal(t, 2, er.GetCode())
+ assert.EqualValues(t, errMsgExpected, er.Error())
+}
+
+func TestGetListNodesIdsEnbSdlgoSuccess(t *testing.T) {
+
+ readerPool = nil
+ sdlInstanceMock := initSdlInstanceMock(namespace, 1)
+ w := GetRNibReader()
+
+ name := "name"
+ plmnId := "02f829"
+ nbId := "4a952a0a"
+ nbIdentity := &entities.NbIdentity{InventoryName: name, GlobalNbId: &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}}
+ var nilError error
+ data, err := proto.Marshal(nbIdentity)
+ if err != nil {
+ t.Errorf("#rNibReader_test.TestGetListNodesIdsEnbSdlgoFailure - Failed to marshal nodeb identity entity. Error: %v", err)
+ }
+ sdlInstanceMock.On("GetMembers", GnbType).Return([]string{string(data)}, nilError)
+ sdlInstanceMock.On("GetMembers", EnbType).Return([]string{string(data)}, nilError)
+
+ ids, er := w.GetListNodebIds()
+ assert.Nil(t, er)
+ assert.NotNil(t, ids)
+ assert.Len(t, ids, 2)
}
func TestGetListEnbIdsUnmarshalFailure(t *testing.T) {
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- sdlInstanceMock.On("GetMembers", "ENB").Return([]string{"data"}, e)
+ sdlInstanceMock.On("GetMembers", EnbType).Return([]string{"data"}, e)
ids, er := w.GetListEnbIds()
assert.NotNil(t, er)
assert.Nil(t, ids)
readerPool = nil
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
- nbIdentity := &entities.NbIdentity{InventoryName:name, GlobalNbId:&entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}}
+ nbIdentity := &entities.NbIdentity{InventoryName: name, GlobalNbId: &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}}
var e error
data, err := proto.Marshal(nbIdentity)
if err != nil {
t.Errorf("#rNibReader_test.TestGetListEnbIds - Failed to marshal nodeb identity entity. Error: %v", err)
}
- sdlInstanceMock.On("GetMembers", "ENB").Return([]string{string(data)}, e)
+ sdlInstanceMock.On("GetMembers", EnbType).Return([]string{string(data)}, e)
ids, er := w.GetListEnbIds()
assert.Nil(t, er)
assert.Len(t, *ids, 1)
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- sdlInstanceMock.On("GetMembers", "ENB").Return([]string{}, e)
+ sdlInstanceMock.On("GetMembers", EnbType).Return([]string{}, e)
ids, er := w.GetListEnbIds()
assert.Nil(t, er)
assert.Len(t, *ids, 0)
w := GetRNibReader()
idsData := make([]string, listSize)
idsEntities := make([]*entities.NbIdentity, listSize)
- for i:=0; i< listSize ;i++{
- nbIdentity := &entities.NbIdentity{InventoryName:name, GlobalNbId:&entities.GlobalNbId{PlmnId:string(plmnId + i), NbId:string(nbId + i)}}
+ for i := 0; i < listSize; i++ {
+ nbIdentity := &entities.NbIdentity{InventoryName: name, GlobalNbId: &entities.GlobalNbId{PlmnId: string(plmnId + i), NbId: string(nbId + i)}}
data, err := proto.Marshal(nbIdentity)
if err != nil {
t.Errorf("#rNibReader_test.TestGetListEnbIds - Failed to marshal nodeb identity entity. Error: %v", err)
idsEntities[i] = nbIdentity
}
var e error
- sdlInstanceMock.On("GetMembers", "ENB").Return(idsData, e)
+ sdlInstanceMock.On("GetMembers", EnbType).Return(idsData, e)
ids, er := w.GetListEnbIds()
assert.Nil(t, er)
assert.Len(t, *ids, listSize)
- for i, id :=range *ids{
+ for i, id := range *ids {
assert.Equal(t, id.GetInventoryName(), name)
assert.Equal(t, id.GetGlobalNbId().GetPlmnId(), idsEntities[i].GetGlobalNbId().GetPlmnId())
assert.Equal(t, id.GetGlobalNbId().GetNbId(), idsEntities[i].GetGlobalNbId().GetNbId())
readerPool = nil
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
- nbIdentity := &entities.NbIdentity{InventoryName:name, GlobalNbId:&entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}}
+ nbIdentity := &entities.NbIdentity{InventoryName: name, GlobalNbId: &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}}
var e error
data, err := proto.Marshal(nbIdentity)
if err != nil {
t.Errorf("#rNibReader_test.TestGetListGnbIds - Failed to marshal nodeb identity entity. Error: %v", err)
}
- sdlInstanceMock.On("GetMembers", "GNB").Return([]string{string(data)}, e)
+ sdlInstanceMock.On("GetMembers", GnbType).Return([]string{string(data)}, e)
ids, er := w.GetListGnbIds()
assert.Nil(t, er)
assert.Len(t, *ids, 1)
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- sdlInstanceMock.On("GetMembers", "GNB").Return([]string{}, e)
+ sdlInstanceMock.On("GetMembers", GnbType).Return([]string{}, e)
ids, er := w.GetListGnbIds()
assert.Nil(t, er)
assert.Len(t, *ids, 0)
w := GetRNibReader()
idsData := make([]string, listSize)
idsEntities := make([]*entities.NbIdentity, listSize)
- for i:=0; i< listSize ;i++{
- nbIdentity := &entities.NbIdentity{InventoryName:name, GlobalNbId:&entities.GlobalNbId{PlmnId:string(plmnId + i), NbId:string(nbId + i)}}
+ for i := 0; i < listSize; i++ {
+ nbIdentity := &entities.NbIdentity{InventoryName: name, GlobalNbId: &entities.GlobalNbId{PlmnId: string(plmnId + i), NbId: string(nbId + i)}}
data, err := proto.Marshal(nbIdentity)
if err != nil {
t.Errorf("#rNibReader_test.TestGetListGnbIds - Failed to marshal nodeb identity entity. Error: %v", err)
idsEntities[i] = nbIdentity
}
var e error
- sdlInstanceMock.On("GetMembers", "GNB").Return(idsData, e)
+ sdlInstanceMock.On("GetMembers", GnbType).Return(idsData, e)
ids, er := w.GetListGnbIds()
assert.Nil(t, er)
assert.Len(t, *ids, listSize)
- for i, id :=range *ids{
+ for i, id := range *ids {
assert.Equal(t, id.GetInventoryName(), name)
assert.Equal(t, id.GetGlobalNbId().GetPlmnId(), idsEntities[i].GetGlobalNbId().GetPlmnId())
assert.Equal(t, id.GetGlobalNbId().GetNbId(), idsEntities[i].GetGlobalNbId().GetNbId())
w := GetRNibReader()
e := errors.New(errMsg)
var data []string
- sdlInstanceMock.On("GetMembers", "ENB").Return(data, e)
+ sdlInstanceMock.On("GetMembers", EnbType).Return(data, e)
ids, er := w.GetListEnbIds()
assert.NotNil(t, er)
assert.Nil(t, ids)
}
func TestGetCountGnbListOneId(t *testing.T) {
- name := "name"
- plmnId := "02f829"
- nbId := "4a952a0a"
readerPool = nil
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
- nbIdentity := &entities.NbIdentity{InventoryName:name, GlobalNbId:&entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}}
var e error
- data, err := proto.Marshal(nbIdentity)
- if err != nil {
- t.Errorf("#rNibReader_test.TestGetCountGnbList - Failed to marshal nodeb identity entity. Error: %v", err)
- }
- sdlInstanceMock.On("GetMembers", "GNB").Return([]string{string(data)}, e)
+ sdlInstanceMock.On("GroupSize", GnbType).Return(1, e)
count, er := w.GetCountGnbList()
assert.Nil(t, er)
assert.Equal(t, count, 1)
}
func TestGetCountGnbList(t *testing.T) {
- listSize := 3
- name := "name"
- plmnId := 0x02f823
- nbId := 0x4a952a1f
readerPool = nil
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- idsData := make([]string, listSize)
- idsEntities := make([]*entities.NbIdentity, listSize)
- for i:=0; i< listSize ;i++{
- nbIdentity := &entities.NbIdentity{InventoryName:name, GlobalNbId:&entities.GlobalNbId{PlmnId:string(plmnId + i), NbId:string(nbId + i)}}
- data, err := proto.Marshal(nbIdentity)
- if err != nil {
- t.Errorf("#rNibReader_test.TestGetListGnbIds - Failed to marshal nodeb identity entity. Error: %v", err)
- }
- idsData[i] = string(data)
- idsEntities[i] = nbIdentity
- }
- sdlInstanceMock.On("GetMembers", "GNB").Return(idsData, e)
+ sdlInstanceMock.On("GroupSize", GnbType).Return(3, e)
count, er := w.GetCountGnbList()
assert.Nil(t, er)
assert.Equal(t, count, 3)
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
e := errors.New(errMsg)
- var data []string
- sdlInstanceMock.On("GetMembers", "GNB").Return(data, e)
+ var count int
+ sdlInstanceMock.On("GroupSize", GnbType).Return(count, e)
count, er := w.GetCountGnbList()
assert.NotNil(t, er)
assert.Equal(t, 0, count)
func TestGetCell(t *testing.T) {
name := "name"
- var pci uint32
- pci = 10
+ var pci uint32 = 10
readerPool = nil
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
- cellEntity := entities.Cell{Type:entities.Cell_LTE_CELL, Cell:&entities.Cell_ServedCellInfo{ServedCellInfo:&entities.ServedCellInfo{Pci:pci}}}
+ cellEntity := entities.Cell{Type: entities.Cell_LTE_CELL, Cell: &entities.Cell_ServedCellInfo{ServedCellInfo: &entities.ServedCellInfo{Pci: pci}}}
cellData, err := proto.Marshal(&cellEntity)
if err != nil {
t.Errorf("#rNibReader_test.TestGetCell - Failed to marshal Cell entity. Error: %v", err)
if rNibErr != nil {
t.Errorf("#rNibReader_test.TestGetCell - failed to validate key parameter")
}
- ret := map[string]interface{}{key:string(cellData)}
+ ret := map[string]interface{}{key: string(cellData)}
sdlInstanceMock.On("Get", []string{key}).Return(ret, e)
cell, er := w.GetCell(name, pci)
assert.Nil(t, er)
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
var e error
- ret := make( map[string]interface{}, 1)
+ ret := make(map[string]interface{}, 1)
key, rNibErr := common.ValidateAndBuildCellNamePciKey(name, pci)
if rNibErr != nil {
t.Errorf("#rNibReader_test.TestGetCellUnmarshalFailure - failed to validate key parameter")
readerPool = nil
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
- nb := entities.NodebInfo{NodeType:entities.Node_ENB}
+ nb := entities.NodebInfo{NodeType: entities.Node_ENB}
nb.ConnectionStatus = 1
nb.Ip = "localhost"
nb.Port = 5656
enb := entities.Enb{}
- cell := entities.ServedCellInfo{Tac:"tac"}
+ cell := entities.ServedCellInfo{Tac: "tac"}
enb.ServedCells = []*entities.ServedCellInfo{&cell}
- nb.Configuration = &entities.NodebInfo_Enb{Enb:&enb}
+ nb.Configuration = &entities.NodebInfo_Enb{Enb: &enb}
var e error
data, err := proto.Marshal(&nb)
if err != nil {
plmnId := "02f829"
nbId := "4a952a0a"
key, rNibErr := common.ValidateAndBuildNodeBIdKey(entities.Node_ENB.String(), plmnId, nbId)
- if rNibErr != nil{
+ if rNibErr != nil {
t.Errorf("Failed to validate nodeb identity, plmnId: %s, nbId: %s", plmnId, nbId)
}
- ret := map[string]interface{}{key:string(data)}
+ ret := map[string]interface{}{key: string(data)}
sdlInstanceMock.On("Get", []string{key}).Return(ret, e)
- globalNbId := &entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}
+ globalNbId := &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}
getNb, er := w.GetNodebByGlobalNbId(entities.Node_ENB, globalNbId)
assert.Nil(t, er)
assert.Equal(t, getNb.Ip, nb.Ip)
w := GetRNibReader()
var e error
key, rNibErr := common.ValidateAndBuildNodeBIdKey(entities.Node_ENB.String(), plmnId, nbId)
- if rNibErr != nil{
+ if rNibErr != nil {
t.Errorf("Failed to validate nodeb identity, plmnId: %s, nbId: %s", plmnId, nbId)
}
var ret map[string]interface{}
sdlInstanceMock.On("Get", []string{key}).Return(ret, e)
- globalNbId := &entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}
+ globalNbId := &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}
getNb, er := w.GetNodebByGlobalNbId(entities.Node_ENB, globalNbId)
assert.NotNil(t, er)
assert.Nil(t, getNb)
assert.Equal(t, 1, er.GetCode())
- assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.GetNodebByGlobalNbId - responding node not found, global nodeb Id: ENB:02f829:4a952a0a", er.Error())
+ assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.getNodeb - responding node not found. Key: ENB:02f829:4a952a0a", er.Error())
}
func TestGetNodebByIdNotFoundFailureGnb(t *testing.T) {
w := GetRNibReader()
var e error
key, rNibErr := common.ValidateAndBuildNodeBIdKey(entities.Node_GNB.String(), plmnId, nbId)
- if rNibErr != nil{
+ if rNibErr != nil {
t.Errorf("Failed to validate nodeb identity, plmnId: %s, nbId: %s", plmnId, nbId)
}
var ret map[string]interface{}
sdlInstanceMock.On("Get", []string{key}).Return(ret, e)
- globalNbId := &entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}
+ globalNbId := &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}
getNb, er := w.GetNodebByGlobalNbId(entities.Node_GNB, globalNbId)
assert.NotNil(t, er)
assert.Nil(t, getNb)
assert.Equal(t, 1, er.GetCode())
- assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.GetNodebByGlobalNbId - responding node not found, global nodeb Id: GNB:02f829:4a952a0a", er.Error())
+ assert.EqualValues(t, "1 RESOURCE_NOT_FOUND - #rNibReader.getNodeb - responding node not found. Key: GNB:02f829:4a952a0a", er.Error())
}
func TestGetNodeByIdUnmarshalFailure(t *testing.T) {
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
key, rNibErr := common.ValidateAndBuildNodeBIdKey(entities.Node_ENB.String(), plmnId, nbId)
- if rNibErr != nil{
+ if rNibErr != nil {
t.Errorf("Failed to validate nodeb identity, plmnId: %s, nbId: %s", plmnId, nbId)
}
var e error
- ret := make( map[string]interface{}, 1)
+ ret := make(map[string]interface{}, 1)
ret[key] = "data"
sdlInstanceMock.On("Get", []string{key}).Return(ret, e)
- globalNbId := &entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}
+ globalNbId := &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}
getNb, er := w.GetNodebByGlobalNbId(entities.Node_ENB, globalNbId)
assert.NotNil(t, er)
assert.Nil(t, getNb)
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
key, rNibErr := common.ValidateAndBuildNodeBIdKey(entities.Node_GNB.String(), plmnId, nbId)
- if rNibErr != nil{
+ if rNibErr != nil {
t.Errorf("Failed to validate nodeb identity, plmnId: %s, nbId: %s", plmnId, nbId)
}
e := errors.New(errMsg)
var ret map[string]interface{}
sdlInstanceMock.On("Get", []string{key}).Return(ret, e)
- globalNbId := &entities.GlobalNbId{PlmnId:plmnId, NbId:nbId}
+ globalNbId := &entities.GlobalNbId{PlmnId: plmnId, NbId: nbId}
getNb, er := w.GetNodebByGlobalNbId(entities.Node_GNB, globalNbId)
assert.NotNil(t, er)
assert.Nil(t, getNb)
func TestGetCellById(t *testing.T) {
cellId := "aaaa"
- var pci uint32
- pci = 10
+ var pci uint32 = 10
readerPool = nil
sdlInstanceMock := initSdlInstanceMock(namespace, 1)
w := GetRNibReader()
- cellEntity := entities.Cell{Type:entities.Cell_LTE_CELL, Cell:&entities.Cell_ServedCellInfo{ServedCellInfo:&entities.ServedCellInfo{Pci:pci}}}
+ cellEntity := entities.Cell{Type: entities.Cell_LTE_CELL, Cell: &entities.Cell_ServedCellInfo{ServedCellInfo: &entities.ServedCellInfo{Pci: pci}}}
cellData, err := proto.Marshal(&cellEntity)
if err != nil {
t.Errorf("#rNibReader_test.TestGetCellById - Failed to marshal Cell entity. Error: %v", err)
if rNibErr != nil {
t.Errorf("#rNibReader_test.TestGetCellById - failed to validate key parameter")
}
- ret := map[string]interface{}{key:string(cellData)}
+ ret := map[string]interface{}{key: string(cellData)}
sdlInstanceMock.On("Get", []string{key}).Return(ret, e)
cell, er := w.GetCellById(entities.Cell_LTE_CELL, cellId)
assert.Nil(t, er)
// } else if cell != nil{
// fmt.Printf("responding node type NR Cell: %v\n", cell.GetServedNrCell())
// }
-//}
\ No newline at end of file
+//}
Code Review / ric-plt / nodeb-rnib.git / blobdiff