Cleanup

[nonrtric.git] / policy-agent / src / test / java / org / oransc / policyagent / ApplicationTest.java

diff --git a/policy-agent/src/test/java/org/oransc/policyagent/ApplicationTest.java b/policy-agent/src/test/java/org/oransc/policyagent/ApplicationTest.java
index d8ff2e1..8bcd99a 100644 (file)
--- a/policy-agent/src/test/java/org/oransc/policyagent/ApplicationTest.java
+++ b/policy-agent/src/test/java/org/oransc/policyagent/ApplicationTest.java
@@ -17,16 +17,19 @@
  * limitations under the License.
  * ========================LICENSE_END===================================
  */
+
 package org.oransc.policyagent;
 
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.Assert.assertFalse;
 
 import java.net.URL;
-
+import java.util.Vector;
 import org.junit.Test;
 import org.junit.runner.RunWith;
 import org.oransc.policyagent.configuration.ApplicationConfig;
+import org.oransc.policyagent.configuration.ImmutableRicConfig;
+import org.oransc.policyagent.configuration.RicConfig;
 import org.oransc.policyagent.exceptions.ServiceException;
 import org.oransc.policyagent.repository.ImmutablePolicy;
 import org.oransc.policyagent.repository.ImmutablePolicyType;
@@ -34,6 +37,8 @@ import org.oransc.policyagent.repository.Policies;
 import org.oransc.policyagent.repository.Policy;
 import org.oransc.policyagent.repository.PolicyType;
 import org.oransc.policyagent.repository.PolicyTypes;
+import org.oransc.policyagent.repository.Ric;
+import org.oransc.policyagent.repository.Rics;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.boot.test.context.SpringBootTest;
 import org.springframework.boot.test.context.SpringBootTest.WebEnvironment;
@@ -50,15 +55,10 @@ import org.springframework.web.client.RestTemplate;
 public class ApplicationTest {
 
     @Autowired
-    private Policies policies;
-
-    @Autowired
-    private PolicyTypes policyTypes;
-
-    @Autowired
-    ApplicationConfig appConfig;
+    private Beans beans;
 
     static class MockApplicationConfig extends ApplicationConfig {
+        @Override
         public void initialize() {
             URL url = MockApplicationConfig.class.getClassLoader().getResource("test_application_configuration.json");
             loadConfigurationFromFile(url.getFile());
@@ -68,17 +68,22 @@ public class ApplicationTest {
     @TestConfiguration
     static class Beans {
         @Bean
-        Policies getPolicies() {
+        public Rics getRics() {
+            return new Rics();
+        }
+
+        @Bean
+        public Policies getPolicies() {
             return new Policies();
         }
 
         @Bean
-        PolicyTypes getPolicyTypes() {
+        public PolicyTypes getPolicyTypes() {
             return new PolicyTypes();
         }
 
         @Bean
-        ApplicationConfig getApplicationConfig() {
+        public ApplicationConfig getApplicationConfig() {
             return new MockApplicationConfig();
         }
     }
@@ -109,22 +114,37 @@ public class ApplicationTest {
         String url = "http://localhost:" + port + "/policy?type=type1&instance=instance1&ric=ric1&service=service1";
         String json = "{}";
         addPolicyType("type1");
+        addRic(beans.getRics(), "ric1", url);
 
         this.restTemplate.put(url, json);
-        Policy policy = this.policies.get("instance1");
+
+        Policy policy = beans.getPolicies().get("instance1");
 
         assertThat(policy).isNotNull();
         assertThat(policy.id()).isEqualTo("instance1");
         assertThat(policy.ownerServiceName()).isEqualTo("service1");
     }
 
+    private void addRic(Rics rics, String ric, String url) {
+        Vector<String> nodeNames = new Vector<>(1);
+        nodeNames.add("node1");
+        RicConfig ricConfig = ImmutableRicConfig.builder() //
+            .name(ric) //
+            .baseUrl(url) //
+            .managedElementIds(nodeNames) //
+            .build();
+        Ric ricObj = new Ric(ricConfig);
+
+        rics.put(ricObj);
+    }
+
     private PolicyType addPolicyType(String name) {
         PolicyType type = ImmutablePolicyType.builder() //
             .jsonSchema("") //
             .name(name) //
             .build();
 
-        policyTypes.put(type);
+        beans.getPolicyTypes().put(type);
         return type;
     }
 
@@ -132,10 +152,10 @@ public class ApplicationTest {
         Policy p = ImmutablePolicy.builder().id(id) //
             .json("{}") //
             .ownerServiceName(service) //
-            .ric(appConfig.getRic("ric1")) //
+            .ric(beans.getRics().getRic("ric1")) //
             .type(addPolicyType(typeName)) //
             .build();
-        this.policies.put(p);
+        beans.getPolicies().put(p);
         return p;
     }
 
@@ -148,7 +168,7 @@ public class ApplicationTest {
             assertThat(rsp).isEqualTo(policy.json());
         }
         {
-            this.policies.remove(policy);
+            beans.getPolicies().remove(policy);
             ResponseEntity<String> rsp = this.restTemplate.getForEntity(url, String.class);
             assertThat(rsp.getStatusCodeValue()).isEqualTo(HttpStatus.NO_CONTENT.value());
         }
@@ -157,6 +177,7 @@ public class ApplicationTest {
     @Test
     public void getPolicies() throws Exception {
         String url = "http://localhost:" + port + "/policies";
+        addRic(beans.getRics(), "ric1", url);
         addPolicy("id1", "type1", "service1");
         addPolicy("id2", "type2", "service2");
 
@@ -168,11 +189,11 @@ public class ApplicationTest {
 
     @Test
     public void getPoliciesFilter() throws Exception {
-        String url = "http://localhost:" + port + "/policies?type=type1";
         addPolicy("id1", "type1", "service1");
         addPolicy("id2", "type1", "service2");
         addPolicy("id3", "type2", "service1");
 
+        String url = "http://localhost:" + port + "/policies?type=type1";
         String rsp = this.restTemplate.getForObject(url, String.class);
         System.out.println(rsp);
         assertThat(rsp).contains("id1");