Merge "Add unit tests for AsyncRestClient"

[nonrtric.git] / policy-agent / src / main / java / org / oransc / policyagent / repository / Services.java

diff --git a/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java b/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java
index 35cae71..369b258 100644 (file)
--- a/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java
+++ b/policy-agent/src/main/java/org/oransc/policyagent/repository/Services.java
@@ -20,7 +20,6 @@
 
 package org.oransc.policyagent.repository;
 
-import java.util.Collection;
 import java.util.HashMap;
 import java.util.Map;
 
@@ -50,14 +49,19 @@ public class Services {
 
     public synchronized void put(Service service) {
         logger.debug("Put service: " + service.getName());
-        // TODO a threading problem is that this may happend at the same time as someone is iterating (getAll())
-        // This is a generic problem
         services.put(service.getName(), service);
     }
 
-    // TODO the returned value should be unmodifiable if possible
-    public synchronized Collection<Service> getAll() {
+    public synchronized Iterable<Service> getAll() {
         return services.values();
     }
 
+    public synchronized void remove(String name) {
+        services.remove(name);
+    }
+
+    public synchronized int size() {
+        return services.size();
+    }
+
 }