Merge "Junit tests for ServiceException"

[nonrtric.git] / policy-agent / src / main / java / org / oransc / policyagent / dmaap / DmaapMessageHandler.java

diff --git a/policy-agent/src/main/java/org/oransc/policyagent/dmaap/DmaapMessageHandler.java b/policy-agent/src/main/java/org/oransc/policyagent/dmaap/DmaapMessageHandler.java
index 2d963c3..6b4f0f4 100644 (file)
--- a/policy-agent/src/main/java/org/oransc/policyagent/dmaap/DmaapMessageHandler.java
+++ b/policy-agent/src/main/java/org/oransc/policyagent/dmaap/DmaapMessageHandler.java
@@ -2,7 +2,7 @@
  * ========================LICENSE_START=================================
  * O-RAN-SC
  * %%
- * Copyright (C) 2019 Nordix Foundation
+ * Copyright (C) 2020 Nordix Foundation
  * %%
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -25,7 +25,6 @@ import com.google.gson.GsonBuilder;
 import java.io.IOException;
 import org.onap.dmaap.mr.client.MRBatchingPublisher;
 import org.oransc.policyagent.clients.AsyncRestClient;
-import org.oransc.policyagent.configuration.ApplicationConfig;
 import org.oransc.policyagent.dmaap.DmaapRequestMessage.Operation;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
@@ -37,27 +36,22 @@ public class DmaapMessageHandler {
     private static final Logger logger = LoggerFactory.getLogger(DmaapMessageHandler.class);
 
     private static Gson gson = new GsonBuilder() //
-            .serializeNulls() //
-            .create(); //
+        .serializeNulls() //
+        .create(); //
 
     private final MRBatchingPublisher dmaapClient;
     private final AsyncRestClient agentClient;
 
-    public DmaapMessageHandler(MRBatchingPublisher dmaapClient, ApplicationConfig applicationConfig,
-            AsyncRestClient agentClient) {
+    public DmaapMessageHandler(MRBatchingPublisher dmaapClient, AsyncRestClient agentClient) {
         this.agentClient = agentClient;
         this.dmaapClient = dmaapClient;
     }
 
     public void handleDmaapMsg(String msg) {
-        try {
-            this.createTask(msg) //
-                    .subscribe(x -> logger.debug("handleDmaapMsg: " + x), //
-                            throwable -> logger.warn("handleDmaapMsg failure ", throwable), //
-                            () -> logger.debug("handleDmaapMsg complete"));
-        } catch (Exception e) {
-            logger.warn("Received unparsable message from DMAAP: {}", msg);
-        }
+        this.createTask(msg) //
+            .subscribe(message -> logger.debug("handleDmaapMsg: {}", message), //
+                throwable -> logger.warn("handleDmaapMsg failure ", throwable), //
+                () -> logger.debug("handleDmaapMsg complete"));
     }
 
     Mono<String> createTask(String msg) {
@@ -65,8 +59,8 @@ public class DmaapMessageHandler {
             DmaapRequestMessage dmaapRequestMessage = gson.fromJson(msg, ImmutableDmaapRequestMessage.class);
 
             return this.invokePolicyAgent(dmaapRequestMessage) //
-                    .onErrorResume(t -> handleAgentCallError(t, dmaapRequestMessage)) //
-                    .flatMap(response -> sendDmaapResponse(response, dmaapRequestMessage, HttpStatus.OK));
+                .onErrorResume(t -> handleAgentCallError(t, dmaapRequestMessage)) //
+                .flatMap(response -> sendDmaapResponse(response, dmaapRequestMessage, HttpStatus.OK));
 
         } catch (Exception e) {
             logger.warn("Received unparsable message from DMAAP: {}", msg);
@@ -75,9 +69,9 @@ public class DmaapMessageHandler {
     }
 
     private Mono<String> handleAgentCallError(Throwable t, DmaapRequestMessage dmaapRequestMessage) {
-        logger.debug("Agent call failed: " + t.getMessage());
+        logger.debug("Agent call failed: {}", t.getMessage());
         return sendDmaapResponse(t.toString(), dmaapRequestMessage, HttpStatus.NOT_FOUND) //
-                .flatMap(s -> Mono.empty());
+            .flatMap(notUsed -> Mono.empty());
     }
 
     private Mono<String> invokePolicyAgent(DmaapRequestMessage dmaapRequestMessage) {
@@ -99,10 +93,10 @@ public class DmaapMessageHandler {
     }
 
     private Mono<String> sendDmaapResponse(String response, DmaapRequestMessage dmaapRequestMessage,
-            HttpStatus status) {
+        HttpStatus status) {
         return getDmaapResponseMessage(dmaapRequestMessage, response, status) //
-                .flatMap(body -> sendToDmaap(body)) //
-                .onErrorResume(t -> handleResponseCallError(t, dmaapRequestMessage));
+            .flatMap(this::sendToDmaap) //
+            .onErrorResume(this::handleResponseCallError);
     }
 
     private Mono<String> sendToDmaap(String body) {
@@ -116,26 +110,25 @@ public class DmaapMessageHandler {
         }
     }
 
-    private Mono<String> handleResponseCallError(Throwable t, DmaapRequestMessage dmaapRequestMessage) {
-        logger.debug("Failed to respond: " + t.getMessage());
+    private Mono<String> handleResponseCallError(Throwable t) {
+        logger.debug("Failed to respond: {}", t.getMessage());
         return Mono.empty();
     }
 
     private Mono<String> getDmaapResponseMessage(DmaapRequestMessage dmaapRequestMessage, String response,
-            HttpStatus status) {
+        HttpStatus status) {
         DmaapResponseMessage dmaapResponseMessage = ImmutableDmaapResponseMessage.builder() //
-                .status(status.toString()) //
-                .message(response) //
-                .type("response") //
-                .correlationId(dmaapRequestMessage.correlationId()) //
-                .originatorId(dmaapRequestMessage.originatorId()) //
-                .requestId(dmaapRequestMessage.requestId()) //
-                .timestamp(dmaapRequestMessage.timestamp()) //
-                .build();
+            .status(status.toString()) //
+            .message(response) //
+            .type("response") //
+            .correlationId(dmaapRequestMessage.correlationId()) //
+            .originatorId(dmaapRequestMessage.originatorId()) //
+            .requestId(dmaapRequestMessage.requestId()) //
+            .timestamp(dmaapRequestMessage.timestamp()) //
+            .build();
         String str = gson.toJson(dmaapResponseMessage);
 
         return Mono.just(str);
 
     }
-
 }