package org.oransc.policyagent.clients;
-import java.lang.invoke.MethodHandles;
-import java.util.ArrayList;
import java.util.List;
-import org.json.JSONArray;
-import org.json.JSONException;
-import org.json.JSONObject;
import org.oransc.policyagent.configuration.RicConfig;
import org.oransc.policyagent.repository.Policy;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
+import org.springframework.web.util.UriComponentsBuilder;
import reactor.core.publisher.Flux;
import reactor.core.publisher.Mono;
public class StdA1Client implements A1Client {
- private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ private static final String URL_PREFIX = "/A1-P/v1";
+
+ private static final String POLICY_TYPES_URI = "/policytypes";
+ private static final String POLICY_TYPE_ID = "policyTypeId";
+
+ private static final String POLICIES_URI = "/policies";
+
+ private static final UriComponentsBuilder POLICY_TYPE_SCHEMA_URI =
+ UriComponentsBuilder.fromPath("/policytypes/{policy-type-name}");
+
+ private static final UriComponentsBuilder POLICY_URI =
+ UriComponentsBuilder.fromPath("/policies/{policy-id}").queryParam(POLICY_TYPE_ID, "{policy-type-name}");
+
+ private static final UriComponentsBuilder POLICY_DELETE_URI =
+ UriComponentsBuilder.fromPath("/policies/{policy-id}");
+
+ private static final UriComponentsBuilder POLICY_STATUS_URI =
+ UriComponentsBuilder.fromPath("/policies/{policy-id}/status");
private final AsyncRestClient restClient;
public StdA1Client(RicConfig ricConfig) {
- String baseUrl = ricConfig.baseUrl() + "/A1-P/v1";
+ String baseUrl = ricConfig.baseUrl() + URL_PREFIX;
this.restClient = new AsyncRestClient(baseUrl);
}
- public StdA1Client(RicConfig ricConfig, AsyncRestClient restClient) {
+ public StdA1Client(AsyncRestClient restClient) {
this.restClient = restClient;
}
@Override
public Mono<List<String>> getPolicyIdentities() {
- return restClient.get("/policies") //
- .flatMap(this::parseJsonArrayOfString);
+ return getPolicyIds() //
+ .collectList();
}
@Override
public Mono<String> putPolicy(Policy policy) {
- String url = "/policies/" + policy.id() + "?policyTypeId=" + policy.type().name();
- return restClient.put(url, policy.json()) //
- .flatMap(this::validateJson);
+ String uri = POLICY_URI.buildAndExpand(policy.id(), policy.type().name()).toUriString();
+ return restClient.put(uri, policy.json()) //
+ .flatMap(JsonHelper::validateJson);
}
@Override
public Mono<List<String>> getPolicyTypeIdentities() {
- return restClient.get("/policytypes") //
- .flatMap(this::parseJsonArrayOfString);
+ return restClient.get(POLICY_TYPES_URI) //
+ .flatMapMany(JsonHelper::parseJsonArrayOfString) //
+ .collectList();
}
@Override
public Mono<String> getPolicyTypeSchema(String policyTypeId) {
- return restClient.get("/policytypes/" + policyTypeId) //
- .flatMap(this::extractPolicySchema);
+ String uri = POLICY_TYPE_SCHEMA_URI.buildAndExpand(policyTypeId).toUriString();
+ return restClient.get(uri) //
+ .flatMap(JsonHelper::extractPolicySchema);
}
@Override
public Mono<String> deletePolicy(Policy policy) {
- return deletePolicy(policy.id());
+ return deletePolicyById(policy.id());
}
@Override
public Flux<String> deleteAllPolicies() {
- return getPolicyIdentities() //
- .flatMapMany(policyIds -> Flux.fromIterable(policyIds)) // )
- .flatMap(policyId -> deletePolicy(policyId)); //
+ return getPolicyIds() //
+ .flatMap(this::deletePolicyById); //
}
@Override
.flatMap(x -> Mono.just(A1ProtocolType.STD_V1));
}
- private Mono<String> deletePolicy(String policyId) {
- return restClient.delete("/policies/" + policyId);
- }
-
- private Mono<List<String>> parseJsonArrayOfString(String inputString) {
- try {
- List<String> arrayList = new ArrayList<>();
- JSONArray jsonArray = new JSONArray(inputString);
- for (int i = 0; i < jsonArray.length(); i++) {
- arrayList.add(jsonArray.getString(i));
- }
- logger.debug("A1 client: received list = {}", arrayList);
- return Mono.just(arrayList);
- } catch (JSONException ex) { // invalid json
- return Mono.error(ex);
- }
+ @Override
+ public Mono<String> getPolicyStatus(Policy policy) {
+ String uri = POLICY_STATUS_URI.buildAndExpand(policy.id()).toUriString();
+ return restClient.get(uri);
}
- private Mono<String> extractPolicySchema(String inputString) {
- try {
- JSONObject jsonObject = new JSONObject(inputString);
- JSONObject schemaObject = jsonObject.getJSONObject("policySchema");
- String schemaString = schemaObject.toString();
- return Mono.just(schemaString);
- } catch (JSONException ex) { // invalid json
- return Mono.error(ex);
- }
+ private Flux<String> getPolicyIds() {
+ return restClient.get(POLICIES_URI) //
+ .flatMapMany(JsonHelper::parseJsonArrayOfString);
}
- private Mono<String> validateJson(String inputString) {
- try {
- new JSONObject(inputString);
- return Mono.just(inputString);
- } catch (JSONException ex) { // invalid json
- return Mono.error(ex);
- }
+ private Mono<String> deletePolicyById(String policyId) {
+ String uri = POLICY_DELETE_URI.buildAndExpand(policyId).toUriString();
+ return restClient.delete(uri);
}
-
- @Override
- public Mono<String> getPolicyStatus(Policy policy) {
- return restClient.get("/policies/" + policy.id() + "/status");
- }
-
}