import (
"fmt"
+ "gerrit.o-ran-sc.org/r/ric-plt/e2ap/pkg/e2ap"
"gerrit.o-ran-sc.org/r/ric-plt/xapp-frame/pkg/xapp"
"sync"
+ "time"
)
//-----------------------------------------------------------------------------
//
//-----------------------------------------------------------------------------
+
type Registry struct {
mutex sync.Mutex
- register map[uint16]*Subscription
- counter uint16
+ register map[uint32]*Subscription
+ subIds []uint32
rtmgrClient *RtmgrClient
}
-// This method should run as a constructor
-func (r *Registry) Initialize(seedsn uint16) {
- r.register = make(map[uint16]*Subscription)
- r.counter = seedsn
+func (r *Registry) Initialize() {
+ r.register = make(map[uint32]*Subscription)
+ var i uint32
+ for i = 0; i < 65535; i++ {
+ r.subIds = append(r.subIds, i+1)
+ }
}
-// Reserves and returns the next free sequence number
-func (r *Registry) ReserveSubscription(endPoint RmrEndpoint, meid *xapp.RMRMeid) (*Subscription, error) {
- // Check is current SequenceNumber valid
- // Allocate next SequenceNumber value and retry N times
- r.mutex.Lock()
- defer r.mutex.Unlock()
- var subs *Subscription = nil
- var retrytimes uint16 = 1000
- for ; subs == nil && retrytimes > 0; retrytimes-- {
- sequenceNumber := r.counter
- if r.counter == 65535 {
- r.counter = 0
- } else {
- r.counter++
+func (r *Registry) allocateSubs(trans *TransactionXapp, subReqMsg *e2ap.E2APSubscriptionRequest) (*Subscription, error) {
+ if len(r.subIds) > 0 {
+ sequenceNumber := r.subIds[0]
+ r.subIds = r.subIds[1:]
+ if _, ok := r.register[sequenceNumber]; ok == true {
+ r.subIds = append(r.subIds, sequenceNumber)
+ return nil, fmt.Errorf("Registry: Failed to reserve subscription exists")
}
- if _, ok := r.register[sequenceNumber]; ok == false {
- subs := &Subscription{
- Seq: sequenceNumber,
- Active: false,
- RmrEndpoint: endPoint,
- Meid: meid,
- Trans: nil,
+ subs := &Subscription{
+ registry: r,
+ Meid: trans.Meid,
+ SubReqMsg: subReqMsg,
+ valid: true,
+ }
+ subs.ReqId.Id = 123
+ subs.ReqId.Seq = sequenceNumber
+
+ if subs.EpList.AddEndpoint(trans.GetEndpoint()) == false {
+ r.subIds = append(r.subIds, subs.ReqId.Seq)
+ return nil, fmt.Errorf("Registry: Endpoint existing already in subscription")
+ }
+
+ return subs, nil
+ }
+ return nil, fmt.Errorf("Registry: Failed to reserve subscription no free ids")
+}
+
+func (r *Registry) findExistingSubs(trans *TransactionXapp, subReqMsg *e2ap.E2APSubscriptionRequest) *Subscription {
+
+ for _, subs := range r.register {
+ if subs.IsMergeable(trans, subReqMsg) {
+
+ //
+ // check if there has been race conditions
+ //
+ subs.mutex.Lock()
+ //subs has been set to invalid
+ if subs.valid == false {
+ subs.mutex.Unlock()
+ continue
+ }
+ // If size is zero, entry is to be deleted
+ if subs.EpList.Size() == 0 {
+ subs.mutex.Unlock()
+ continue
}
- r.register[sequenceNumber] = subs
-
- // Update routing
- r.mutex.Unlock()
- err := subs.UpdateRoute(CREATE, r.rtmgrClient)
- r.mutex.Lock()
- if err != nil {
- if _, ok := r.register[sequenceNumber]; ok {
- delete(r.register, sequenceNumber)
- }
- return nil, err
+ // try to add to endpointlist.
+ if subs.EpList.AddEndpoint(trans.GetEndpoint()) == false {
+ subs.mutex.Unlock()
+ continue
}
- return subs, nil
+ subs.mutex.Unlock()
+
+ xapp.Logger.Debug("Registry: Mergeable subs found %s for %s", subs.String(), trans.String())
+ return subs
}
}
- return nil, fmt.Errorf("Registry: Failed to reserves subcription. RmrEndpoint: %s, Meid: %s", endPoint, meid.RanName)
+ return nil
}
-func (r *Registry) GetSubscription(sn uint16) *Subscription {
+func (r *Registry) AssignToSubscription(trans *TransactionXapp, subReqMsg *e2ap.E2APSubscriptionRequest) (*Subscription, error) {
+ var err error
+ var newAlloc bool
r.mutex.Lock()
defer r.mutex.Unlock()
- xapp.Logger.Debug("Registry map: %v", r.register)
- if _, ok := r.register[sn]; ok {
- return r.register[sn]
+
+ subs := r.findExistingSubs(trans, subReqMsg)
+
+ if subs == nil {
+ subs, err = r.allocateSubs(trans, subReqMsg)
+ if err != nil {
+ return nil, err
+ }
+ newAlloc = true
+ }
+
+ //
+ // Add to subscription
+ //
+ subs.mutex.Lock()
+ defer subs.mutex.Unlock()
+
+ epamount := subs.EpList.Size()
+
+ r.mutex.Unlock()
+ //
+ // Subscription route updates
+ //
+ if epamount == 1 {
+ subRouteAction := SubRouteInfo{subs.EpList, uint16(subs.ReqId.Seq)}
+ err = r.rtmgrClient.SubscriptionRequestCreate(subRouteAction)
+ } else {
+ subRouteAction := SubRouteInfo{subs.EpList, uint16(subs.ReqId.Seq)}
+ err = r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction)
+ }
+ r.mutex.Lock()
+
+ if err != nil {
+ if newAlloc {
+ r.subIds = append(r.subIds, subs.ReqId.Seq)
+ }
+ return nil, err
+ }
+
+ if newAlloc {
+ r.register[subs.ReqId.Seq] = subs
}
+ xapp.Logger.Debug("CREATE %s", subs.String())
+ xapp.Logger.Debug("Registry: substable=%v", r.register)
+ return subs, nil
+}
+
+// TODO: Works with concurrent calls, but check if can be improved
+func (r *Registry) RemoveFromSubscription(subs *Subscription, trans *TransactionXapp, waitRouteClean time.Duration) error {
+
+ r.mutex.Lock()
+ defer r.mutex.Unlock()
+ subs.mutex.Lock()
+ defer subs.mutex.Unlock()
+
+ delStatus := subs.EpList.DelEndpoint(trans.GetEndpoint())
+ epamount := subs.EpList.Size()
+ seqId := subs.ReqId.Seq
+
+ if delStatus == false {
+ return nil
+ }
+
+ r.mutex.Unlock()
+
+ //
+ // Wait some time before really do route updates
+ //
+ if waitRouteClean > 0 {
+ subs.mutex.Unlock()
+ time.Sleep(waitRouteClean)
+ subs.mutex.Lock()
+ }
+
+ xapp.Logger.Info("CLEAN %s", subs.String())
+
+ //
+ // Subscription route updates
+ //
+ if epamount == 0 {
+ tmpList := RmrEndpointList{}
+ tmpList.AddEndpoint(trans.GetEndpoint())
+ subRouteAction := SubRouteInfo{tmpList, uint16(seqId)}
+ r.rtmgrClient.SubscriptionRequestDelete(subRouteAction)
+ } else if subs.EpList.Size() > 0 {
+ subRouteAction := SubRouteInfo{subs.EpList, uint16(seqId)}
+ r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction)
+ }
+
+ r.mutex.Lock()
+ //
+ // If last endpoint, release and free seqid
+ //
+ if epamount == 0 {
+ if _, ok := r.register[seqId]; ok {
+ xapp.Logger.Debug("RELEASE %s", subs.String())
+ delete(r.register, seqId)
+ xapp.Logger.Debug("Registry: substable=%v", r.register)
+ }
+ r.subIds = append(r.subIds, seqId)
+ }
+
return nil
}
-func (r *Registry) DelSubscription(sn uint16) bool {
+func (r *Registry) GetSubscription(sn uint32) *Subscription {
r.mutex.Lock()
defer r.mutex.Unlock()
if _, ok := r.register[sn]; ok {
- subs := r.register[sn]
- delete(r.register, sn)
+ return r.register[sn]
+ }
+ return nil
+}
- // Update routing
- r.mutex.Unlock()
- err := subs.UpdateRoute(DELETE, r.rtmgrClient)
- r.mutex.Lock()
- if err != nil {
- xapp.Logger.Error("Registry: Failed to del route. SubId: %d, RmrEndpoint: %s", subs.Seq, subs.RmrEndpoint)
+func (r *Registry) GetSubscriptionFirstMatch(ids []uint32) (*Subscription, error) {
+ r.mutex.Lock()
+ defer r.mutex.Unlock()
+ for _, id := range ids {
+ if _, ok := r.register[id]; ok {
+ return r.register[id], nil
}
- return true
}
- return false
+ return nil, fmt.Errorf("No valid subscription found with ids %v", ids)
}
Code Review / ric-plt / submgr.git / blobdiff