Fixed function id handling and improved ut fail handling
[ric-plt/submgr.git] / pkg / control / registry.go
index 2c5bd8c..2750b78 100644 (file)
@@ -21,8 +21,10 @@ package control
 
 import (
        "fmt"
+       "gerrit.o-ran-sc.org/r/ric-plt/e2ap/pkg/e2ap"
        "gerrit.o-ran-sc.org/r/ric-plt/xapp-frame/pkg/xapp"
        "sync"
+       "time"
 )
 
 //-----------------------------------------------------------------------------
@@ -31,82 +33,155 @@ import (
 type Registry struct {
        mutex       sync.Mutex
        register    map[uint16]*Subscription
-       counter     uint16
+       subIds      []uint16
        rtmgrClient *RtmgrClient
 }
 
-// This method should run as a constructor
-func (r *Registry) Initialize(seedsn uint16) {
+func (r *Registry) Initialize() {
        r.register = make(map[uint16]*Subscription)
-       r.counter = seedsn
+       var i uint16
+       for i = 0; i < 65535; i++ {
+               r.subIds = append(r.subIds, i+1)
+       }
 }
 
-// Reserves and returns the next free sequence number
-func (r *Registry) ReserveSubscription(endPoint RmrEndpoint, meid *xapp.RMRMeid) (*Subscription, error) {
-       // Check is current SequenceNumber valid
-       // Allocate next SequenceNumber value and retry N times
+func (r *Registry) AssignToSubscription(trans *Transaction, subReqMsg *e2ap.E2APSubscriptionRequest) (*Subscription, error) {
        r.mutex.Lock()
        defer r.mutex.Unlock()
-       var subs *Subscription = nil
-       var retrytimes uint16 = 1000
-       for ; subs == nil && retrytimes > 0; retrytimes-- {
-               sequenceNumber := r.counter
-               if r.counter == 65535 {
-                       r.counter = 0
-               } else {
-                       r.counter++
+
+       var sequenceNumber uint16
+
+       //
+       // Allocate subscription
+       //
+       if len(r.subIds) > 0 {
+               sequenceNumber = r.subIds[0]
+               r.subIds = r.subIds[1:]
+               if _, ok := r.register[sequenceNumber]; ok == true {
+                       r.subIds = append(r.subIds, sequenceNumber)
+                       return nil, fmt.Errorf("Registry: Failed to reserves subscription")
+               }
+       } else {
+               return nil, fmt.Errorf("Registry: Failed to reserves subscription no free ids")
+       }
+       subs := &Subscription{
+               registry: r,
+               Seq:      sequenceNumber,
+               Meid:     trans.Meid,
+       }
+
+       //
+       // Add to subscription
+       //
+       subs.mutex.Lock()
+       defer subs.mutex.Unlock()
+
+       if subs.EpList.AddEndpoint(trans.GetEndpoint()) == false {
+               r.subIds = append(r.subIds, sequenceNumber)
+               return nil, fmt.Errorf("Registry: Endpoint existing already in subscription")
+       }
+       epamount := subs.EpList.Size()
+
+       r.mutex.Unlock()
+       //
+       // Subscription route updates
+       //
+       var err error
+       if epamount == 1 {
+               subRouteAction := SubRouteInfo{CREATE, subs.EpList, subs.Seq}
+               err = r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction)
+       } else {
+               subRouteAction := SubRouteInfo{UPDATE, subs.EpList, subs.Seq}
+               err = r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction)
+       }
+       r.mutex.Lock()
+
+       if err != nil {
+               r.subIds = append(r.subIds, sequenceNumber)
+               return nil, err
+       }
+       subs.SubReqMsg = subReqMsg
+
+       r.register[sequenceNumber] = subs
+       xapp.Logger.Debug("Registry: Create %s", subs.String())
+       xapp.Logger.Debug("Registry: substable=%v", r.register)
+       return subs, nil
+}
+
+func (r *Registry) RemoveFromSubscription(subs *Subscription, trans *Transaction, waitRouteClean time.Duration) error {
+       r.mutex.Lock()
+       defer r.mutex.Unlock()
+       subs.mutex.Lock()
+       defer subs.mutex.Unlock()
+
+       delStatus := subs.EpList.DelEndpoint(trans.GetEndpoint())
+       epamount := subs.EpList.Size()
+
+       //
+       // If last endpoint remove from register map
+       //
+       if epamount == 0 {
+               if _, ok := r.register[subs.Seq]; ok {
+                       xapp.Logger.Debug("Registry: Delete %s", subs.String())
+                       delete(r.register, subs.Seq)
+                       xapp.Logger.Debug("Registry: substable=%v", r.register)
                }
-               if _, ok := r.register[sequenceNumber]; ok == false {
-                       subs := &Subscription{
-                               Seq:         sequenceNumber,
-                               Active:      false,
-                               RmrEndpoint: endPoint,
-                               Meid:        meid,
-                               Trans:       nil,
-                       }
-                       r.register[sequenceNumber] = subs
-
-                       // Update routing
-                       r.mutex.Unlock()
-                       err := subs.UpdateRoute(CREATE, r.rtmgrClient)
-                       r.mutex.Lock()
-                       if err != nil {
-                               if _, ok := r.register[sequenceNumber]; ok {
-                                       delete(r.register, sequenceNumber)
-                               }
-                               return nil, err
-                       }
-                       return subs, nil
+       }
+       r.mutex.Unlock()
+
+       //
+       // Wait some time before really do route updates
+       //
+       if waitRouteClean > 0 {
+               subs.mutex.Unlock()
+               time.Sleep(waitRouteClean)
+               subs.mutex.Lock()
+       }
+
+       xapp.Logger.Info("Registry: Cleaning %s", subs.String())
+
+       //
+       // Subscription route updates
+       //
+       if delStatus {
+               if epamount == 0 {
+                       tmpList := RmrEndpointList{}
+                       tmpList.AddEndpoint(trans.GetEndpoint())
+                       subRouteAction := SubRouteInfo{DELETE, tmpList, subs.Seq}
+                       r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction)
+               } else {
+                       subRouteAction := SubRouteInfo{UPDATE, subs.EpList, subs.Seq}
+                       r.rtmgrClient.SubscriptionRequestUpdate(subRouteAction)
                }
        }
-       return nil, fmt.Errorf("Registry: Failed to reserves subcription. RmrEndpoint: %s, Meid: %s", endPoint, meid.RanName)
+
+       r.mutex.Lock()
+       //
+       // If last endpoint free seq nro
+       //
+       if epamount == 0 {
+               r.subIds = append(r.subIds, subs.Seq)
+       }
+
+       return nil
 }
 
 func (r *Registry) GetSubscription(sn uint16) *Subscription {
        r.mutex.Lock()
        defer r.mutex.Unlock()
-       xapp.Logger.Debug("Registry map: %v", r.register)
        if _, ok := r.register[sn]; ok {
                return r.register[sn]
        }
        return nil
 }
 
-func (r *Registry) DelSubscription(sn uint16) bool {
+func (r *Registry) GetSubscriptionFirstMatch(ids []uint16) (*Subscription, error) {
        r.mutex.Lock()
        defer r.mutex.Unlock()
-       if _, ok := r.register[sn]; ok {
-               subs := r.register[sn]
-               delete(r.register, sn)
-
-               // Update routing
-               r.mutex.Unlock()
-               err := subs.UpdateRoute(DELETE, r.rtmgrClient)
-               r.mutex.Lock()
-               if err != nil {
-                       xapp.Logger.Error("Registry: Failed to del route. SubId: %d, RmrEndpoint: %s", subs.Seq, subs.RmrEndpoint)
+       for _, id := range ids {
+               if _, ok := r.register[id]; ok {
+                       return r.register[id], nil
                }
-               return true
        }
-       return false
+       return nil, fmt.Errorf("No valid subscription found with ids %v", ids)
 }