-
/*
Copyright (c) 2019 AT&T Intellectual Property.
Copyright (c) 2018-2019 Nokia.
limitations under the License.
*/
+/*
+ * This source code is part of the near-RT RIC (RAN Intelligent Controller)
+ * platform project (RICP).
+ */
+
package sdlgoredis_test
import (
- "testing"
"errors"
+ "strconv"
+ "testing"
"time"
- "github.com/go-redis/redis"
"gerrit.o-ran-sc.org/r/ric-plt/sdlgo/internal/sdlgoredis"
+ "github.com/go-redis/redis"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/mock"
)
return m.Called(key).Get(0).(*redis.IntCmd)
}
+func (m *clientMock) PTTL(key string) *redis.DurationCmd {
+ return m.Called(key).Get(0).(*redis.DurationCmd)
+}
+
+func (m *clientMock) Eval(script string, keys []string, args ...interface{}) *redis.Cmd {
+ return m.Called(script, keys).Get(0).(*redis.Cmd)
+}
+
+func (m *clientMock) EvalSha(sha1 string, keys []string, args ...interface{}) *redis.Cmd {
+ return m.Called(sha1, keys, args).Get(0).(*redis.Cmd)
+}
+
+func (m *clientMock) ScriptExists(scripts ...string) *redis.BoolSliceCmd {
+ return m.Called(scripts).Get(0).(*redis.BoolSliceCmd)
+}
+
+func (m *clientMock) ScriptLoad(script string) *redis.StringCmd {
+ return m.Called(script).Get(0).(*redis.StringCmd)
+}
+
func setSubscribeNotifications() (*pubSubMock, sdlgoredis.SubscribeFn) {
mock := new(pubSubMock)
return mock, func(client sdlgoredis.RedisClient, channels ...string) sdlgoredis.Subscriber {
if commandsExists {
cmdResult = map[string]*redis.CommandInfo{
- "setie": &dummyCommandInfo,
- "delie": &dummyCommandInfo,
+ "setie": &dummyCommandInfo,
+ "delie": &dummyCommandInfo,
"setiepub": &dummyCommandInfo,
"setnxpub": &dummyCommandInfo,
"msetmpub": &dummyCommandInfo,
- "delmpub": &dummyCommandInfo,
+ "delmpub": &dummyCommandInfo,
}
} else {
cmdResult = map[string]*redis.CommandInfo{
func TestMSetSuccessfully(t *testing.T) {
_, r, db := setup(true)
expectedKeysAndValues := []interface{}{"key1", "value1", "key2", 2}
- r.On("MSet",expectedKeysAndValues).Return(redis.NewStatusResult("OK", nil))
+ r.On("MSet", expectedKeysAndValues).Return(redis.NewStatusResult("OK", nil))
err := db.MSet("key1", "value1", "key2", 2)
assert.Nil(t, err)
r.AssertExpectations(t)
func TestMSetFailure(t *testing.T) {
_, r, db := setup(true)
expectedKeysAndValues := []interface{}{"key1", "value1", "key2", 2}
- r.On("MSet",expectedKeysAndValues).Return(redis.NewStatusResult("OK", errors.New("Some error")))
+ r.On("MSet", expectedKeysAndValues).Return(redis.NewStatusResult("OK", errors.New("Some error")))
err := db.MSet("key1", "value1", "key2", 2)
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestMSetMPubSuccessfully(t *testing.T) {
_, r, db := setup(true)
expectedMessage := []interface{}{"MSETMPUB", 2, 2, "key1", "val1", "key2", "val2",
- "chan1", "event1", "chan2", "event2"}
+ "chan1", "event1", "chan2", "event2"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult("", nil))
assert.Nil(t, db.MSetMPub([]string{"chan1", "event1", "chan2", "event2"},
- "key1", "val1", "key2", "val2"))
+ "key1", "val1", "key2", "val2"))
r.AssertExpectations(t)
}
func TestMsetMPubFailure(t *testing.T) {
_, r, db := setup(true)
expectedMessage := []interface{}{"MSETMPUB", 2, 2, "key1", "val1", "key2", "val2",
- "chan1", "event1", "chan2", "event2"}
+ "chan1", "event1", "chan2", "event2"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult("", errors.New("Some error")))
assert.NotNil(t, db.MSetMPub([]string{"chan1", "event1", "chan2", "event2"},
- "key1", "val1", "key2", "val2"))
+ "key1", "val1", "key2", "val2"))
r.AssertExpectations(t)
}
func TestMSetMPubCommandMissing(t *testing.T) {
_, r, db := setup(false)
expectedMessage := []interface{}{"MSETMPUB", 2, 2, "key1", "val1", "key2", "val2",
- "chan1", "event1", "chan2", "event2"}
+ "chan1", "event1", "chan2", "event2"}
r.AssertNotCalled(t, "Do", expectedMessage)
assert.NotNil(t, db.MSetMPub([]string{"chan1", "event1", "chan2", "event2"},
- "key1", "val1", "key2", "val2"))
+ "key1", "val1", "key2", "val2"))
r.AssertExpectations(t)
}
expectedKeys := []string{"key1", "key2", "key3"}
expectedResult := []interface{}{nil}
r.On("MGet", expectedKeys).Return(redis.NewSliceResult(expectedResult,
- errors.New("Some error")))
+ errors.New("Some error")))
result, err := db.MGet([]string{"key1", "key2", "key3"})
assert.Equal(t, result, expectedResult)
assert.NotNil(t, err)
func TestDelMPubSuccessfully(t *testing.T) {
_, r, db := setup(true)
expectedMessage := []interface{}{"DELMPUB", 2, 2, "key1", "key2", "chan1", "event1",
- "chan2", "event2"}
+ "chan2", "event2"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult("", nil))
assert.Nil(t, db.DelMPub([]string{"chan1", "event1", "chan2", "event2"},
- []string{"key1", "key2"}))
+ []string{"key1", "key2"}))
r.AssertExpectations(t)
}
func TestDelMPubFailure(t *testing.T) {
_, r, db := setup(true)
expectedMessage := []interface{}{"DELMPUB", 2, 2, "key1", "key2", "chan1", "event1",
- "chan2", "event2"}
+ "chan2", "event2"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult("", errors.New("Some error")))
assert.NotNil(t, db.DelMPub([]string{"chan1", "event1", "chan2", "event2"},
- []string{"key1", "key2"}))
+ []string{"key1", "key2"}))
r.AssertExpectations(t)
}
func TestDelMPubCommandMissing(t *testing.T) {
_, r, db := setup(false)
expectedMessage := []interface{}{"DELMPUB", 2, 2, "key1", "key2", "chan1", "event1",
- "chan2", "event2"}
+ "chan2", "event2"}
r.AssertNotCalled(t, "Do", expectedMessage)
assert.NotNil(t, db.DelMPub([]string{"chan1", "event1", "chan2", "event2"},
- []string{"key1", "key2"}))
+ []string{"key1", "key2"}))
r.AssertExpectations(t)
}
expectedPattern := "pattern*"
expectedResult := []string{}
r.On("Keys", expectedPattern).Return(redis.NewStringSliceResult(expectedResult,
- errors.New("Some error")))
+ errors.New("Some error")))
_, err := db.Keys("pattern*")
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestSetIEPubKeyExists(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"SETIEPUB", "key", "newdata", "olddata", "channel", "message"}
+ expectedMessage := []interface{}{"SETIEMPUB", "key", "newdata", "olddata", "channel", "message"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult("OK", nil))
- result, err := db.SetIEPub("channel", "message", "key", "olddata", "newdata")
+ result, err := db.SetIEPub([]string{"channel", "message"}, "key", "olddata", "newdata")
assert.True(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
func TestSetIEPubKeyDoesntExists(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"SETIEPUB", "key", "newdata", "olddata", "channel", "message"}
+ expectedMessage := []interface{}{"SETIEMPUB", "key", "newdata", "olddata", "channel", "message"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult(nil, nil))
- result, err := db.SetIEPub("channel", "message", "key", "olddata", "newdata")
+ result, err := db.SetIEPub([]string{"channel", "message"}, "key", "olddata", "newdata")
assert.False(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
func TestSetIEPubFailure(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"SETIEPUB", "key", "newdata", "olddata", "channel", "message"}
+ expectedMessage := []interface{}{"SETIEMPUB", "key", "newdata", "olddata", "channel", "message"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult(nil, errors.New("Some error")))
- result, err := db.SetIEPub("channel", "message", "key", "olddata", "newdata")
+ result, err := db.SetIEPub([]string{"channel", "message"}, "key", "olddata", "newdata")
assert.False(t, result)
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestSetIEPubCommandMissing(t *testing.T) {
_, r, db := setup(false)
- expectedMessage := []interface{}{"SETIEPUB", "key", "newdata", "olddata", "channel", "message"}
+ expectedMessage := []interface{}{"SETIEMPUB", "key", "newdata", "olddata", "channel", "message"}
r.AssertNotCalled(t, "Do", expectedMessage)
- result, err := db.SetIEPub("channel", "message", "key", "olddata", "newdata")
+ result, err := db.SetIEPub([]string{"channel", "message"}, "key", "olddata", "newdata")
assert.False(t, result)
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestSetNXPubKeyDoesntExist(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"SETNXPUB", "key", "data", "channel", "message"}
+ expectedMessage := []interface{}{"SETNXMPUB", "key", "data", "channel", "message"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult("OK", nil))
- result, err := db.SetNXPub("channel", "message", "key", "data")
+ result, err := db.SetNXPub([]string{"channel", "message"}, "key", "data")
assert.True(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
func TestSetNXPubKeyExists(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"SETNXPUB", "key", "data", "channel", "message"}
+ expectedMessage := []interface{}{"SETNXMPUB", "key", "data", "channel", "message"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult(nil, nil))
- result, err := db.SetNXPub("channel", "message", "key", "data")
+ result, err := db.SetNXPub([]string{"channel", "message"}, "key", "data")
assert.False(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
func TestSetNXPubFailure(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"SETNXPUB", "key", "data", "channel", "message"}
+ expectedMessage := []interface{}{"SETNXMPUB", "key", "data", "channel", "message"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult(nil, errors.New("Some error")))
- result, err := db.SetNXPub("channel", "message", "key", "data")
+ result, err := db.SetNXPub([]string{"channel", "message"}, "key", "data")
assert.False(t, result)
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestSetNXPubCommandMissing(t *testing.T) {
_, r, db := setup(false)
- expectedMessage := []interface{}{"SETNXPUB", "key", "data", "channel", "message"}
+ expectedMessage := []interface{}{"SETNXMPUB", "key", "data", "channel", "message"}
r.AssertNotCalled(t, "Do", expectedMessage)
- result, err := db.SetNXPub("channel", "message", "key", "data")
+ result, err := db.SetNXPub([]string{"channel", "message"}, "key", "data")
assert.False(t, result)
assert.NotNil(t, err)
r.AssertExpectations(t)
expectedKey := "key"
expectedData := "data"
r.On("SetNX", expectedKey, expectedData, time.Duration(0)).Return(redis.NewBoolResult(true, nil))
- result, err := db.SetNX("key", "data")
+ result, err := db.SetNX("key", "data", 0)
assert.True(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
expectedKey := "key"
expectedData := "data"
r.On("SetNX", expectedKey, expectedData, time.Duration(0)).Return(redis.NewBoolResult(false, nil))
- result, err := db.SetNX("key", "data")
+ result, err := db.SetNX("key", "data", 0)
assert.False(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
expectedKey := "key"
expectedData := "data"
r.On("SetNX", expectedKey, expectedData, time.Duration(0)).
- Return(redis.NewBoolResult(false,errors.New("Some error")))
- result, err := db.SetNX("key", "data")
+ Return(redis.NewBoolResult(false, errors.New("Some error")))
+ result, err := db.SetNX("key", "data", 0)
assert.False(t, result)
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestDelIEPubKeyDoesntExist(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"DELIEPUB", "key", "data", "channel", "message"}
- r.On("Do", expectedMessage).Return(redis.NewCmdResult(0, nil))
- result, err := db.DelIEPub("channel", "message", "key", "data")
+ expectedMessage := []interface{}{"DELIEMPUB", "key", "data", "channel", "message"}
+ r.On("Do", expectedMessage).Return(redis.NewCmdResult(int64(0), nil))
+ result, err := db.DelIEPub([]string{"channel", "message"}, "key", "data")
assert.False(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
func TestDelIEPubKeyExists(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"DELIEPUB", "key", "data", "channel", "message"}
+ expectedMessage := []interface{}{"DELIEMPUB", "key", "data", "channel", "message"}
+ r.On("Do", expectedMessage).Return(redis.NewCmdResult(int64(1), nil))
+ result, err := db.DelIEPub([]string{"channel", "message"}, "key", "data")
+ assert.True(t, result)
+ assert.Nil(t, err)
+ r.AssertExpectations(t)
+}
+
+func TestDelIEPubKeyExistsIntTypeRedisValue(t *testing.T) {
+ _, r, db := setup(true)
+ expectedMessage := []interface{}{"DELIEMPUB", "key", "data", "channel", "message"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult(1, nil))
- result, err := db.DelIEPub("channel", "message", "key", "data")
+ result, err := db.DelIEPub([]string{"channel", "message"}, "key", "data")
assert.True(t, result)
assert.Nil(t, err)
r.AssertExpectations(t)
func TestDelIEPubFailure(t *testing.T) {
_, r, db := setup(true)
- expectedMessage := []interface{}{"DELIEPUB", "key", "data", "channel", "message"}
- r.On("Do", expectedMessage).Return(redis.NewCmdResult(0, errors.New("Some error")))
- result, err := db.DelIEPub("channel", "message", "key", "data")
+ expectedMessage := []interface{}{"DELIEMPUB", "key", "data", "channel", "message"}
+ r.On("Do", expectedMessage).Return(redis.NewCmdResult(int64(0), errors.New("Some error")))
+ result, err := db.DelIEPub([]string{"channel", "message"}, "key", "data")
assert.False(t, result)
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestDelIEPubCommandMissing(t *testing.T) {
_, r, db := setup(false)
- expectedMessage := []interface{}{"DELIEPUB", "key", "data", "channel", "message"}
+ expectedMessage := []interface{}{"DELIEMPUB", "key", "data", "channel", "message"}
r.AssertNotCalled(t, "Do", expectedMessage)
- result, err := db.DelIEPub("channel", "message", "key", "data")
+ result, err := db.DelIEPub([]string{"channel", "message"}, "key", "data")
assert.False(t, result)
assert.NotNil(t, err)
r.AssertExpectations(t)
func TestDelIEKeyDoesntExist(t *testing.T) {
_, r, db := setup(true)
expectedMessage := []interface{}{"DELIE", "key", "data"}
- r.On("Do", expectedMessage).Return(redis.NewCmdResult(0, nil))
+ r.On("Do", expectedMessage).Return(redis.NewCmdResult(int64(0), nil))
result, err := db.DelIE("key", "data")
assert.False(t, result)
assert.Nil(t, err)
}
func TestDelIEKeyExists(t *testing.T) {
+ _, r, db := setup(true)
+ expectedMessage := []interface{}{"DELIE", "key", "data"}
+ r.On("Do", expectedMessage).Return(redis.NewCmdResult(int64(1), nil))
+ result, err := db.DelIE("key", "data")
+ assert.True(t, result)
+ assert.Nil(t, err)
+ r.AssertExpectations(t)
+}
+
+func TestDelIEKeyExistsIntTypeRedisValue(t *testing.T) {
_, r, db := setup(true)
expectedMessage := []interface{}{"DELIE", "key", "data"}
r.On("Do", expectedMessage).Return(redis.NewCmdResult(1, nil))
func TestDelIEFailure(t *testing.T) {
_, r, db := setup(true)
expectedMessage := []interface{}{"DELIE", "key", "data"}
- r.On("Do", expectedMessage).Return(redis.NewCmdResult(0, errors.New("Some error")))
+ r.On("Do", expectedMessage).Return(redis.NewCmdResult(int64(0), errors.New("Some error")))
result, err := db.DelIE("key", "data")
assert.False(t, result)
assert.NotNil(t, err)
expectedKey := "key"
expectedResult := []string{"member1", "member2"}
r.On("SMembers", expectedKey).Return(redis.NewStringSliceResult(expectedResult,
- errors.New("Some error")))
+ errors.New("Some error")))
result, err := db.SMembers("key")
assert.Equal(t, result, expectedResult)
assert.NotNil(t, err)
ps.On("Close").Return(nil)
count := 0
receivedChannel := ""
- db.SubscribeChannelDB(func(channel string, payload ...string){
+ db.SubscribeChannelDB(func(channel string, payload ...string) {
count++
receivedChannel = channel
- },"{prefix}", "---", "{prefix}channel")
+ }, "{prefix}", "---", "{prefix}channel")
ch <- &msg
db.UnsubscribeChannelDB("{prefix}channel")
time.Sleep(1 * time.Second)
ps.On("Close").Return(nil)
count := 0
receivedChannel1 := ""
- db.SubscribeChannelDB(func(channel string, payload ...string){
+ db.SubscribeChannelDB(func(channel string, payload ...string) {
count++
receivedChannel1 = channel
- },"{prefix}", "---", "{prefix}channel1")
+ }, "{prefix}", "---", "{prefix}channel1")
ch <- &msg1
receivedChannel2 := ""
- db.SubscribeChannelDB(func(channel string, payload ...string){
+ db.SubscribeChannelDB(func(channel string, payload ...string) {
count++
receivedChannel2 = channel
- },"{prefix}", "---", "{prefix}channel2")
+ }, "{prefix}", "---", "{prefix}channel2")
+ time.Sleep(1 * time.Second)
db.UnsubscribeChannelDB("{prefix}channel1")
ch <- &msg2
db.UnsubscribeChannelDB("{prefix}channel2")
assert.Equal(t, "channel2", receivedChannel2)
r.AssertExpectations(t)
ps.AssertExpectations(t)
-}
\ No newline at end of file
+}
+
+func TestSubscribeChannelReDBSubscribeAfterUnsubscribe(t *testing.T) {
+ ps, r, db := setup(true)
+ ch := make(chan *redis.Message)
+ msg := redis.Message{
+ Channel: "{prefix}channel",
+ Pattern: "pattern",
+ Payload: "event",
+ }
+ ps.On("Channel").Return(ch)
+ ps.On("Unsubscribe").Return(nil)
+ ps.On("Close").Return(nil)
+ count := 0
+ receivedChannel := ""
+
+ db.SubscribeChannelDB(func(channel string, payload ...string) {
+ count++
+ receivedChannel = channel
+ }, "{prefix}", "---", "{prefix}channel")
+ ch <- &msg
+ db.UnsubscribeChannelDB("{prefix}channel")
+ time.Sleep(1 * time.Second)
+
+ db.SubscribeChannelDB(func(channel string, payload ...string) {
+ count++
+ receivedChannel = channel
+ }, "{prefix}", "---", "{prefix}channel")
+ ch <- &msg
+ db.UnsubscribeChannelDB("{prefix}channel")
+
+ time.Sleep(1 * time.Second)
+ assert.Equal(t, 2, count)
+ assert.Equal(t, "channel", receivedChannel)
+ r.AssertExpectations(t)
+ ps.AssertExpectations(t)
+}
+
+func TestPTTLSuccessfully(t *testing.T) {
+ _, r, db := setup(true)
+ expectedKey := "key"
+ expectedResult := time.Duration(1)
+ r.On("PTTL", expectedKey).Return(redis.NewDurationResult(expectedResult,
+ nil))
+ result, err := db.PTTL("key")
+ assert.Equal(t, result, expectedResult)
+ assert.Nil(t, err)
+ r.AssertExpectations(t)
+}
+
+func TestPTTLFailure(t *testing.T) {
+ _, r, db := setup(true)
+ expectedKey := "key"
+ expectedResult := time.Duration(1)
+ r.On("PTTL", expectedKey).Return(redis.NewDurationResult(expectedResult,
+ errors.New("Some error")))
+ result, err := db.PTTL("key")
+ assert.Equal(t, result, expectedResult)
+ assert.NotNil(t, err)
+ r.AssertExpectations(t)
+}
+
+func TestPExpireIESuccessfully(t *testing.T) {
+ _, r, db := setup(true)
+ expectedKey := "key"
+ expectedData := "data"
+ expectedDuration := strconv.FormatInt(int64(10000), 10)
+
+ r.On("EvalSha", mock.Anything, []string{expectedKey}, []interface{}{expectedData, expectedDuration}).
+ Return(redis.NewCmdResult(int64(1), nil))
+
+ err := db.PExpireIE("key", "data", 10*time.Second)
+ assert.Nil(t, err)
+ r.AssertExpectations(t)
+}
+
+func TestPExpireIEFailure(t *testing.T) {
+ _, r, db := setup(true)
+ expectedKey := "key"
+ expectedData := "data"
+ expectedDuration := strconv.FormatInt(int64(10000), 10)
+
+ r.On("EvalSha", mock.Anything, []string{expectedKey}, []interface{}{expectedData, expectedDuration}).
+ Return(redis.NewCmdResult(int64(1), errors.New("Some error")))
+
+ err := db.PExpireIE("key", "data", 10*time.Second)
+ assert.NotNil(t, err)
+ r.AssertExpectations(t)
+}
+
+func TestPExpireIELockNotHeld(t *testing.T) {
+ _, r, db := setup(true)
+ expectedKey := "key"
+ expectedData := "data"
+ expectedDuration := strconv.FormatInt(int64(10000), 10)
+
+ r.On("EvalSha", mock.Anything, []string{expectedKey}, []interface{}{expectedData, expectedDuration}).
+ Return(redis.NewCmdResult(int64(0), nil))
+
+ err := db.PExpireIE("key", "data", 10*time.Second)
+ assert.NotNil(t, err)
+ r.AssertExpectations(t)
+}
Code Review / ric-plt / sdlgo.git / blobdiff