Add tests to improve code-coverage stats in Sonar
[portal/ric-dashboard.git] / dashboard / webapp-backend / src / test / java / org / oransc / ric / portal / dashboard / controller / AdminControllerTest.java
index 02534fb..4deafe7 100644 (file)
@@ -21,23 +21,30 @@ package org.oransc.ric.portal.dashboard.controller;
 
 import java.lang.invoke.MethodHandles;
 import java.net.URI;
-import java.util.HashMap;
 import java.util.List;
-import java.util.Map;
 
+import org.junit.Assert;
 import org.junit.jupiter.api.Assertions;
+import org.junit.jupiter.api.MethodOrderer;
+import org.junit.jupiter.api.Order;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.TestMethodOrder;
 import org.onap.portalsdk.core.restful.domain.EcompUser;
 import org.oransc.ric.portal.dashboard.DashboardConstants;
-import org.oransc.ric.portal.dashboard.model.ErrorTransport;
+import org.oransc.ric.portal.dashboard.config.RICInstanceMockConfiguration;
+import org.oransc.ric.portal.dashboard.model.AppStats;
 import org.oransc.ric.portal.dashboard.model.RicInstanceKeyName;
+import org.oransc.ric.portal.dashboard.model.StatsDetailsTransport;
 import org.oransc.ric.portal.dashboard.model.SuccessTransport;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.core.ParameterizedTypeReference;
+import org.springframework.http.HttpEntity;
 import org.springframework.http.HttpMethod;
 import org.springframework.http.ResponseEntity;
+import org.springframework.web.client.RestClientException;
 
+@TestMethodOrder(MethodOrderer.OrderAnnotation.class)
 public class AdminControllerTest extends AbstractControllerTest {
 
        private static final Logger logger = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
@@ -87,40 +94,99 @@ public class AdminControllerTest extends AbstractControllerTest {
                Assertions.assertTrue(response.getStatusCode().is4xxClientError());
        }
 
+       @Order(1)
        @Test
-       public void getxAppMetricsUrlTest() {
-               Map<String, String> metricsQueryParms = new HashMap<String, String>();
-               URI uri;
+       public void getAppStatsTest() {
+               URI uri = buildUri(null, AdminController.CONTROLLER_PATH, DashboardConstants.RIC_INSTANCE_KEY, "i1",
+                               AdminController.STATAPPMETRIC_METHOD);
+               logger.info("Invoking uri {}", uri);
+               ResponseEntity<List<AppStats>> response = testRestTemplateAdminRole().exchange(uri, HttpMethod.GET, null,
+                               new ParameterizedTypeReference<List<AppStats>>() {
+                               });
+               Assertions.assertFalse(response.getBody().isEmpty());
+               Assertions.assertNotEquals(-1, response.getBody().get(0).getStatsDetails().getAppId());
+       }
 
-               metricsQueryParms.clear();
-               metricsQueryParms.put("app", DashboardConstants.APP_NAME_AC);
-               uri = buildUri(metricsQueryParms, AdminController.CONTROLLER_PATH, AdminController.XAPPMETRICS_METHOD);
-               logger.debug("Invoking {}", uri);
-               ResponseEntity<SuccessTransport> successResponse = testRestTemplateStandardRole().exchange(uri, HttpMethod.GET,
-                               null, SuccessTransport.class);
-               Assertions.assertFalse(successResponse.getBody().getData().toString().isEmpty());
-               Assertions.assertTrue(successResponse.getStatusCode().is2xxSuccessful());
+       @Order(2)
+       @Test
+       public void createAppStatsTest() {
+               URI uri = buildUri(null, AdminController.CONTROLLER_PATH, DashboardConstants.RIC_INSTANCE_KEY,
+                               RICInstanceMockConfiguration.INSTANCE_KEY_1, AdminController.STATAPPMETRIC_METHOD);
+               logger.info("Invoking uri {}", uri);
+               StatsDetailsTransport statsDetails = new StatsDetailsTransport();
+               statsDetails.setAppName("MachLearn-2");
+               statsDetails.setMetricUrl("https://www.example2.com");
+               AppStats st = testRestTemplateAdminRole().postForObject(uri, statsDetails, AppStats.class);
+               Assertions.assertFalse(st.getStatsDetails().getAppName().isEmpty());
+               statsDetails.setAppName("MachLearn-2-next");
+               statsDetails.setMetricUrl("https://www.example2-next.com");
+               AppStats stNext = testRestTemplateAdminRole().postForObject(uri, statsDetails, AppStats.class);
+               Assertions.assertTrue(st.getStatsDetails().getAppId() < stNext.getStatsDetails().getAppId());
+               try {
+                       testRestTemplateAdminRole().postForObject(uri, statsDetails, AppStats.class);
+                       Assert.assertTrue(false);
+               } catch (RestClientException ex) {
+                       logger.info("Caught exception on create as expected: {}", ex.toString());
+               }
+       }
 
-               metricsQueryParms.clear();
-               metricsQueryParms.put("app", DashboardConstants.APP_NAME_MC);
-               logger.debug("Invoking {}", uri);
-               successResponse = testRestTemplateStandardRole().exchange(uri, HttpMethod.GET, null, SuccessTransport.class);
-               Assertions.assertFalse(successResponse.getBody().getData().toString().isEmpty());
-               Assertions.assertTrue(successResponse.getStatusCode().is2xxSuccessful());
+       @Order(3)
+       @Test
+       public void updateAppStatsTest() {
+               URI uri = buildUri(null, AdminController.CONTROLLER_PATH, DashboardConstants.RIC_INSTANCE_KEY,
+                               RICInstanceMockConfiguration.INSTANCE_KEY_1, AdminController.STATAPPMETRIC_METHOD);
+               logger.info("Invoking uri {}", uri);
+               ResponseEntity<List<AppStats>> response = testRestTemplateAdminRole().exchange(uri, HttpMethod.GET, null,
+                               new ParameterizedTypeReference<List<AppStats>>() {
+                               });
+               int statToUpdate = 0;
+               if (response.getBody() != null) {
+                       statToUpdate = response.getBody().get(0).getStatsDetails().getAppId();
+               }
+               StatsDetailsTransport statsDetails = new StatsDetailsTransport();
+               statsDetails.setAppId(statToUpdate);
+               statsDetails.setAppName("MachLearn-1");
+               statsDetails.setMetricUrl("https://www.example1.com");
+               HttpEntity<StatsDetailsTransport> entity = new HttpEntity<>(statsDetails);
+               ResponseEntity<String> stringResponse = testRestTemplateAdminRole().exchange(uri, HttpMethod.PUT, entity,
+                               String.class);
+               Assertions.assertTrue(stringResponse.getStatusCode().is2xxSuccessful());
+
+               StatsDetailsTransport bogusDetails = new StatsDetailsTransport();
+               bogusDetails.setAppId(-1);
+               bogusDetails.setAppName("bogus");
+               HttpEntity<StatsDetailsTransport> bogusEntity = new HttpEntity<>(bogusDetails);
+               ResponseEntity<String> voidResponse = testRestTemplateAdminRole().exchange(uri, HttpMethod.PUT, bogusEntity,
+                               String.class);
+               Assertions.assertTrue(voidResponse.getStatusCode().is4xxClientError());
        }
 
+       @Order(4)
        @Test
-       public void getxAppMetricsUrlTestFail() {
-               Map<String, String> metricsQueryParms = new HashMap<String, String>();
-               // Providing a bogus value for application name in query parameter to test
-               // failure
-               metricsQueryParms.put("app", "ABCD");
-               URI uri = buildUri(metricsQueryParms, AdminController.CONTROLLER_PATH, AdminController.XAPPMETRICS_METHOD);
-               logger.debug("Invoking {}", uri);
-               ResponseEntity<ErrorTransport> errorResponse = testRestTemplateStandardRole().exchange(uri, HttpMethod.GET,
-                               null, ErrorTransport.class);
-               logger.debug("{}", errorResponse.getBody().getError().toString());
-               Assertions.assertTrue(errorResponse.getStatusCode().is4xxClientError());
+       public void deleteAppStatsTest() {
+               URI uri = buildUri(null, AdminController.CONTROLLER_PATH, DashboardConstants.RIC_INSTANCE_KEY,
+                               RICInstanceMockConfiguration.INSTANCE_KEY_1, AdminController.STATAPPMETRIC_METHOD);
+               ResponseEntity<List<AppStats>> response = testRestTemplateAdminRole().exchange(uri, HttpMethod.GET, null,
+                               new ParameterizedTypeReference<List<AppStats>>() {
+                               });
+               int statToDelete = 0;
+               if (response.getBody() != null) {
+                       statToDelete = response.getBody().get(0).getStatsDetails().getAppId();
+               }
+               uri = buildUri(null, AdminController.CONTROLLER_PATH, DashboardConstants.RIC_INSTANCE_KEY,
+                               RICInstanceMockConfiguration.INSTANCE_KEY_1, AdminController.STATAPPMETRIC_METHOD,
+                               DashboardConstants.APP_ID, String.valueOf(statToDelete));
+               logger.info("Invoking uri {}", uri);
+               ResponseEntity<String> stringResponse = testRestTemplateAdminRole().exchange(uri, HttpMethod.DELETE, null,
+                               String.class);
+               Assertions.assertTrue(stringResponse.getStatusCode().is2xxSuccessful());
+
+               URI uri99 = buildUri(null, AdminController.CONTROLLER_PATH, DashboardConstants.RIC_INSTANCE_KEY,
+                               RICInstanceMockConfiguration.INSTANCE_KEY_1, AdminController.STATAPPMETRIC_METHOD,
+                               DashboardConstants.APP_ID, "999999");
+               ResponseEntity<String> voidResponse = testRestTemplateAdminRole().exchange(uri99, HttpMethod.DELETE, null,
+                               String.class);
+               Assertions.assertTrue(voidResponse.getStatusCode().is4xxClientError());
        }
 
        @Test
@@ -128,10 +194,10 @@ public class AdminControllerTest extends AbstractControllerTest {
                URI uri = buildUri(null, AdminController.CONTROLLER_PATH,
                                AdminControllerExtension.HTTP_STATUS_CODE_EXCEPTION_METHOD);
                logger.debug("Invoking {}", uri);
-               ResponseEntity<ErrorTransport> errorResponse = testRestTemplateStandardRole().exchange(uri, HttpMethod.GET,
-                               null, ErrorTransport.class);
-               logger.debug("{}", errorResponse.getBody().getError().toString());
-               Assertions.assertTrue(errorResponse.getStatusCode().is5xxServerError());
+               ResponseEntity<String> response = testRestTemplateStandardRole().exchange(uri, HttpMethod.GET, null,
+                               String.class);
+               logger.debug("{}", response.getBody().toString());
+               Assertions.assertTrue(response.getStatusCode().is5xxServerError());
        }
 
        @Test
@@ -139,9 +205,9 @@ public class AdminControllerTest extends AbstractControllerTest {
                URI uri = buildUri(null, AdminController.CONTROLLER_PATH,
                                AdminControllerExtension.REST_CLIENT_RESPONSE_EXCEPTION_METHOD);
                logger.debug("Invoking {}", uri);
-               ResponseEntity<ErrorTransport> errorResponse = testRestTemplateStandardRole().exchange(uri, HttpMethod.GET,
-                               null, ErrorTransport.class);
-               logger.debug("{}", errorResponse.getBody().getError().toString());
+               ResponseEntity<String> errorResponse = testRestTemplateStandardRole().exchange(uri, HttpMethod.GET, null,
+                               String.class);
+               logger.debug("{}", errorResponse.getBody());
                Assertions.assertTrue(errorResponse.getStatusCode().is5xxServerError());
        }