Merge "Changes in implementation of Security API - get Token"

[nonrtric/plt/sme.git] / capifcore / internal / securityservice / security_test.go

diff --git a/capifcore/internal/securityservice/security_test.go b/capifcore/internal/securityservice/security_test.go
index e97e354..6c62161 100644 (file)
--- a/capifcore/internal/securityservice/security_test.go
+++ b/capifcore/internal/securityservice/security_test.go
@@ -35,8 +35,6 @@ import (
 
        "github.com/labstack/echo/v4"
 
-       "oransc.org/nonrtric/capifcore/internal/common29122"
-
        invokermocks "oransc.org/nonrtric/capifcore/internal/invokermanagement/mocks"
        servicemocks "oransc.org/nonrtric/capifcore/internal/providermanagement/mocks"
        publishmocks "oransc.org/nonrtric/capifcore/internal/publishservice/mocks"
@@ -48,22 +46,27 @@ import (
        "github.com/stretchr/testify/mock"
 )
 
-func TestPostSecurityIdToken(t *testing.T) {
+func TestPostSecurityIdTokenInvokerRegistered(t *testing.T) {
        invokerRegisterMock := invokermocks.InvokerRegister{}
        invokerRegisterMock.On("IsInvokerRegistered", mock.AnythingOfType("string")).Return(true)
        invokerRegisterMock.On("VerifyInvokerSecret", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(true)
        serviceRegisterMock := servicemocks.ServiceRegister{}
        serviceRegisterMock.On("IsFunctionRegistered", mock.AnythingOfType("string")).Return(true)
-       apiRegisterMock := publishmocks.APIRegister{}
-       apiRegisterMock.On("IsAPIRegistered", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(true)
+       publishRegisterMock := publishmocks.PublishRegister{}
+       publishRegisterMock.On("IsAPIPublished", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(true)
 
-       requestHandler := getEcho(&serviceRegisterMock, &apiRegisterMock, &invokerRegisterMock)
+       requestHandler := getEcho(&serviceRegisterMock, &publishRegisterMock, &invokerRegisterMock)
 
        data := url.Values{}
-       data.Set("client_id", "id")
-       data.Add("client_secret", "secret")
-       data.Add("grant_type", "client_credentials")
-       data.Add("scope", "scope#aefId:path")
+       clientId := "id"
+       clientSecret := "secret"
+       aefId := "aefId"
+       path := "path"
+       data.Set("client_id", clientId)
+       data.Set("client_secret", clientSecret)
+       data.Set("grant_type", "client_credentials")
+       data.Set("scope", "3gpp#"+aefId+":"+path)
+
        encodedData := data.Encode()
 
        result := testutil.NewRequest().Post("/securities/invokerId/token").WithContentType("application/x-www-form-urlencoded").WithBody([]byte(encodedData)).Go(t, requestHandler)
@@ -73,16 +76,120 @@ func TestPostSecurityIdToken(t *testing.T) {
        err := result.UnmarshalBodyToObject(&resultResponse)
        assert.NoError(t, err, "error unmarshaling response")
        assert.NotEmpty(t, resultResponse.AccessToken)
-       assert.Equal(t, "scope#aefId:path", *resultResponse.Scope)
+       assert.Equal(t, "3gpp#"+aefId+":"+path, *resultResponse.Scope)
        assert.Equal(t, securityapi.AccessTokenRspTokenTypeBearer, resultResponse.TokenType)
-       assert.Equal(t, common29122.DurationSec(0), resultResponse.ExpiresIn)
-       invokerRegisterMock.AssertCalled(t, "IsInvokerRegistered", "id")
-       invokerRegisterMock.AssertCalled(t, "VerifyInvokerSecret", "id", "secret")
-       serviceRegisterMock.AssertCalled(t, "IsFunctionRegistered", "aefId")
-       apiRegisterMock.AssertCalled(t, "IsAPIRegistered", "aefId", "path")
+       invokerRegisterMock.AssertCalled(t, "IsInvokerRegistered", clientId)
+       invokerRegisterMock.AssertCalled(t, "VerifyInvokerSecret", clientId, clientSecret)
+       serviceRegisterMock.AssertCalled(t, "IsFunctionRegistered", aefId)
+       publishRegisterMock.AssertCalled(t, "IsAPIPublished", aefId, path)
+}
+
+func TestPostSecurityIdTokenInvokerNotRegistered(t *testing.T) {
+       invokerRegisterMock := invokermocks.InvokerRegister{}
+       invokerRegisterMock.On("IsInvokerRegistered", mock.AnythingOfType("string")).Return(false)
+
+       requestHandler := getEcho(nil, nil, &invokerRegisterMock)
+
+       data := url.Values{}
+       data.Set("client_id", "id")
+       data.Add("client_secret", "secret")
+       data.Add("grant_type", "client_credentials")
+       data.Add("scope", "3gpp#aefId:path")
+       encodedData := data.Encode()
+
+       result := testutil.NewRequest().Post("/securities/invokerId/token").WithContentType("application/x-www-form-urlencoded").WithBody([]byte(encodedData)).Go(t, requestHandler)
+
+       assert.Equal(t, http.StatusBadRequest, result.Code())
+       var errDetails securityapi.AccessTokenErr
+       err := result.UnmarshalBodyToObject(&errDetails)
+       assert.NoError(t, err, "error unmarshaling response")
+       assert.Equal(t, securityapi.AccessTokenErrErrorInvalidClient, errDetails.Error)
+       errMsg := "Invoker not registered"
+       assert.Equal(t, &errMsg, errDetails.ErrorDescription)
+}
+
+func TestPostSecurityIdTokenInvokerSecretNotValid(t *testing.T) {
+       invokerRegisterMock := invokermocks.InvokerRegister{}
+       invokerRegisterMock.On("IsInvokerRegistered", mock.AnythingOfType("string")).Return(true)
+       invokerRegisterMock.On("VerifyInvokerSecret", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(false)
+
+       requestHandler := getEcho(nil, nil, &invokerRegisterMock)
+
+       data := url.Values{}
+       data.Set("client_id", "id")
+       data.Add("client_secret", "secret")
+       data.Add("grant_type", "client_credentials")
+       data.Add("scope", "3gpp#aefId:path")
+       encodedData := data.Encode()
+
+       result := testutil.NewRequest().Post("/securities/invokerId/token").WithContentType("application/x-www-form-urlencoded").WithBody([]byte(encodedData)).Go(t, requestHandler)
+
+       assert.Equal(t, http.StatusBadRequest, result.Code())
+       var errDetails securityapi.AccessTokenErr
+       err := result.UnmarshalBodyToObject(&errDetails)
+       assert.NoError(t, err, "error unmarshaling response")
+       assert.Equal(t, securityapi.AccessTokenErrErrorUnauthorizedClient, errDetails.Error)
+       errMsg := "Invoker secret not valid"
+       assert.Equal(t, &errMsg, errDetails.ErrorDescription)
+}
+
+func TestPostSecurityIdTokenFunctionNotRegistered(t *testing.T) {
+       invokerRegisterMock := invokermocks.InvokerRegister{}
+       invokerRegisterMock.On("IsInvokerRegistered", mock.AnythingOfType("string")).Return(true)
+       invokerRegisterMock.On("VerifyInvokerSecret", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(true)
+       serviceRegisterMock := servicemocks.ServiceRegister{}
+       serviceRegisterMock.On("IsFunctionRegistered", mock.AnythingOfType("string")).Return(false)
+
+       requestHandler := getEcho(&serviceRegisterMock, nil, &invokerRegisterMock)
+
+       data := url.Values{}
+       data.Set("client_id", "id")
+       data.Add("client_secret", "secret")
+       data.Add("grant_type", "client_credentials")
+       data.Add("scope", "3gpp#aefId:path")
+       encodedData := data.Encode()
+
+       result := testutil.NewRequest().Post("/securities/invokerId/token").WithContentType("application/x-www-form-urlencoded").WithBody([]byte(encodedData)).Go(t, requestHandler)
+
+       assert.Equal(t, http.StatusBadRequest, result.Code())
+       var errDetails securityapi.AccessTokenErr
+       err := result.UnmarshalBodyToObject(&errDetails)
+       assert.NoError(t, err, "error unmarshaling response")
+       assert.Equal(t, securityapi.AccessTokenErrErrorInvalidScope, errDetails.Error)
+       errMsg := "AEF Function not registered"
+       assert.Equal(t, &errMsg, errDetails.ErrorDescription)
+}
+
+func TestPostSecurityIdTokenAPINotPublished(t *testing.T) {
+       invokerRegisterMock := invokermocks.InvokerRegister{}
+       invokerRegisterMock.On("IsInvokerRegistered", mock.AnythingOfType("string")).Return(true)
+       invokerRegisterMock.On("VerifyInvokerSecret", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(true)
+       serviceRegisterMock := servicemocks.ServiceRegister{}
+       serviceRegisterMock.On("IsFunctionRegistered", mock.AnythingOfType("string")).Return(true)
+       publishRegisterMock := publishmocks.PublishRegister{}
+       publishRegisterMock.On("IsAPIPublished", mock.AnythingOfType("string"), mock.AnythingOfType("string")).Return(false)
+
+       requestHandler := getEcho(&serviceRegisterMock, &publishRegisterMock, &invokerRegisterMock)
+
+       data := url.Values{}
+       data.Set("client_id", "id")
+       data.Add("client_secret", "secret")
+       data.Add("grant_type", "client_credentials")
+       data.Add("scope", "3gpp#aefId:path")
+       encodedData := data.Encode()
+
+       result := testutil.NewRequest().Post("/securities/invokerId/token").WithContentType("application/x-www-form-urlencoded").WithBody([]byte(encodedData)).Go(t, requestHandler)
+
+       assert.Equal(t, http.StatusBadRequest, result.Code())
+       var errDetails securityapi.AccessTokenErr
+       err := result.UnmarshalBodyToObject(&errDetails)
+       assert.NoError(t, err, "error unmarshaling response")
+       assert.Equal(t, securityapi.AccessTokenErrErrorInvalidScope, errDetails.Error)
+       errMsg := "API not published"
+       assert.Equal(t, &errMsg, errDetails.ErrorDescription)
 }
 
-func getEcho(serviceRegister providermanagement.ServiceRegister, apiRegister publishservice.APIRegister, invokerRegister invokermanagement.InvokerRegister) *echo.Echo {
+func getEcho(serviceRegister providermanagement.ServiceRegister, publishRegister publishservice.PublishRegister, invokerRegister invokermanagement.InvokerRegister) *echo.Echo {
        swagger, err := securityapi.GetSwagger()
        if err != nil {
                fmt.Fprintf(os.Stderr, "Error loading swagger spec\n: %s", err)
@@ -91,7 +198,7 @@ func getEcho(serviceRegister providermanagement.ServiceRegister, apiRegister pub
 
        swagger.Servers = nil
 
-       s := NewSecurity(serviceRegister, apiRegister, invokerRegister)
+       s := NewSecurity(serviceRegister, publishRegister, invokerRegister)
 
        e := echo.New()
        e.Use(echomiddleware.Logger())