Improve validation for provider management

[nonrtric/plt/sme.git] / capifcore / internal / providermanagementapi / typevalidation_test.go

diff --git a/capifcore/internal/providermanagementapi/typevalidation_test.go b/capifcore/internal/providermanagementapi/typevalidation_test.go
index fb5ad81..7698aab 100644 (file)
--- a/capifcore/internal/providermanagementapi/typevalidation_test.go
+++ b/capifcore/internal/providermanagementapi/typevalidation_test.go
@@ -59,6 +59,14 @@ func TestValidateAPIProviderFunctionDetails(t *testing.T) {
                assert.Contains(t, err.Error(), "apiProvFuncRole")
        }
 
+       var invalidFuncRole ApiProviderFuncRole = "invalid"
+       funcDetailsUnderTest.ApiProvFuncRole = invalidFuncRole
+       err = funcDetailsUnderTest.Validate()
+       if assert.Error(t, err) {
+               assert.Contains(t, err.Error(), "invalid")
+               assert.Contains(t, err.Error(), "apiProvFuncRole")
+       }
+
        funcDetailsUnderTest.ApiProvFuncRole = ApiProviderFuncRoleAEF
        err = funcDetailsUnderTest.Validate()
        if assert.Error(t, err) {
@@ -88,55 +96,14 @@ func TestValidateAPIProviderEnrolmentDetails(t *testing.T) {
                assert.Contains(t, err.Error(), "apiProvFuncs")
                assert.Contains(t, err.Error(), "contains invalid")
        }
-}
 
-func TestUpdateFuncs_addNewFunction(t *testing.T) {
-       providerUnderTest := getProvider()
-
-       newFuncInfoAEF := "new func as AEF"
-       newFuncs := append(*providerUnderTest.ApiProvFuncs, APIProviderFunctionDetails{
-               ApiProvFuncInfo: &newFuncInfoAEF,
+       (*providerDetailsUnderTest.ApiProvFuncs)[0] = APIProviderFunctionDetails{
                ApiProvFuncRole: ApiProviderFuncRoleAEF,
-       })
-       providerUnderTest.ApiProvFuncs = &newFuncs
-
-       err := providerUnderTest.UpdateFuncs(getProvider())
-
-       assert.Nil(t, err)
-       assert.Len(t, *providerUnderTest.ApiProvFuncs, 4)
-       assert.True(t, providerUnderTest.IsFunctionRegistered("AEF_id_new_func_as_AEF"))
-}
-
-func TestUpdateFuncs_deleteFunction(t *testing.T) {
-       providerUnderTest := getProvider()
-
-       modFuncs := []APIProviderFunctionDetails{(*providerUnderTest.ApiProvFuncs)[0], (*providerUnderTest.ApiProvFuncs)[1]}
-       providerUnderTest.ApiProvFuncs = &modFuncs
-
-       err := providerUnderTest.UpdateFuncs(getProvider())
-
-       assert.Nil(t, err)
-       assert.Len(t, *providerUnderTest.ApiProvFuncs, 2)
-       assert.True(t, providerUnderTest.IsFunctionRegistered(funcIdAPF))
-       assert.True(t, providerUnderTest.IsFunctionRegistered(funcIdAMF))
-}
-
-func TestUpdateFuncs_unregisteredFunction(t *testing.T) {
-       providerUnderTest := getProvider()
-
-       unRegId := "unRegId"
-       modFuncs := []APIProviderFunctionDetails{
-               {
-                       ApiProvFuncId: &unRegId,
+               RegInfo: RegistrationInformation{
+                       ApiProvPubKey: "key",
                },
        }
-       providerUnderTest.ApiProvFuncs = &modFuncs
-
-       err := providerUnderTest.UpdateFuncs(getProvider())
-       if assert.Error(t, err) {
-               assert.Contains(t, err.Error(), unRegId)
-               assert.Contains(t, err.Error(), "not registered")
-       }
+       assert.Nil(t, providerDetailsUnderTest.Validate())
 }
 
 func getProvider() APIProviderEnrolmentDetails {