Improve locking/unlocking

[nonrtric/plt/sme.git] / capifcore / internal / eventservice / eventservice.go

diff --git a/capifcore/internal/eventservice/eventservice.go b/capifcore/internal/eventservice/eventservice.go
index a4fa079..21742ef 100644 (file)
--- a/capifcore/internal/eventservice/eventservice.go
+++ b/capifcore/internal/eventservice/eventservice.go
@@ -33,6 +33,7 @@ import (
        "k8s.io/utils/strings/slices"
        "oransc.org/nonrtric/capifcore/internal/common29122"
        "oransc.org/nonrtric/capifcore/internal/eventsapi"
+       "oransc.org/nonrtric/capifcore/internal/publishserviceapi"
        "oransc.org/nonrtric/capifcore/internal/restclient"
 )
 
@@ -88,13 +89,13 @@ func (es *EventService) PostSubscriberIdSubscriptions(ctx echo.Context, subscrib
 
 func (es *EventService) DeleteSubscriberIdSubscriptionsSubscriptionId(ctx echo.Context, subscriberId string, subscriptionId string) error {
        es.lock.Lock()
-       defer es.lock.Unlock()
 
        log.Debug(es.subscriptions)
        if _, ok := es.subscriptions[subscriptionId]; ok {
                log.Debug("Deleting subscription", subscriptionId)
                delete(es.subscriptions, subscriptionId)
        }
+       es.lock.Unlock()
 
        return ctx.NoContent(http.StatusNoContent)
 }
@@ -132,10 +133,9 @@ func (es *EventService) getMatchingSubs(event eventsapi.EventNotification) []str
                subscription := es.subscriptions[subId]
                if subscription.EventFilters == nil || event.EventDetail == nil {
                        matchingSubs = append(matchingSubs, subId)
-                       break
-               }
-               if matchesFilters(*event.EventDetail.ApiIds, *subscription.EventFilters, getApiIdsFromFilter) &&
-                       matchesFilters(*event.EventDetail.ApiInvokerIds, *subscription.EventFilters, getInvokerIdsFromFilter) {
+               } else if matchesFilters(event.EventDetail.ApiIds, *subscription.EventFilters, getApiIdsFromFilter) &&
+                       matchesFilters(event.EventDetail.ApiInvokerIds, *subscription.EventFilters, getInvokerIdsFromFilter) &&
+                       matchesFilters(getAefIdsFromEvent(event.EventDetail.ServiceAPIDescriptions), *subscription.EventFilters, getAefIdsFromFilter) {
                        matchingSubs = append(matchingSubs, subId)
                }
        }
@@ -153,13 +153,14 @@ func (es *EventService) filterOnEventType(event eventsapi.EventNotification) []s
        return matchingSubs
 }
 
-func matchesFilters(eventIds []string, filters []eventsapi.CAPIFEventFilter, getIds func(eventsapi.CAPIFEventFilter) *[]string) bool {
-       if len(filters) == 0 {
+func matchesFilters(eventIds *[]string, filters []eventsapi.CAPIFEventFilter, getIds func(eventsapi.CAPIFEventFilter) *[]string) bool {
+       if len(filters) == 0 || eventIds == nil {
                return true
        }
-       for _, id := range eventIds {
+       for _, id := range *eventIds {
                filter := filters[0]
-               if getIds(filter) == nil {
+               filterIds := getIds(filter)
+               if filterIds == nil || len(*filterIds) == 0 {
                        return matchesFilters(eventIds, filters[1:], getIds)
                }
                return slices.Contains(*getIds(filter), id) && matchesFilters(eventIds, filters[1:], getIds)
@@ -170,10 +171,31 @@ func matchesFilters(eventIds []string, filters []eventsapi.CAPIFEventFilter, get
 func getApiIdsFromFilter(filter eventsapi.CAPIFEventFilter) *[]string {
        return filter.ApiIds
 }
+
 func getInvokerIdsFromFilter(filter eventsapi.CAPIFEventFilter) *[]string {
        return filter.ApiInvokerIds
 }
 
+func getAefIdsFromEvent(serviceAPIDescriptions *[]publishserviceapi.ServiceAPIDescription) *[]string {
+       aefIds := []string{}
+       if serviceAPIDescriptions == nil {
+               return &aefIds
+       }
+       for _, serviceDescription := range *serviceAPIDescriptions {
+               if serviceDescription.AefProfiles == nil {
+                       return &aefIds
+               }
+               for _, profile := range *serviceDescription.AefProfiles {
+                       aefIds = append(aefIds, profile.AefId)
+               }
+       }
+       return &aefIds
+}
+
+func getAefIdsFromFilter(filter eventsapi.CAPIFEventFilter) *[]string {
+       return filter.AefIds
+}
+
 func asStrings(events []eventsapi.CAPIFEvent) []string {
        asStrings := make([]string, len(events))
        for i, event := range events {