Code Review
/
portal
/
nonrtric-controlpanel.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Added presentation of owner of EiJob
[portal/nonrtric-controlpanel.git]
/
webapp-frontend
/
src
/
app
/
policy-control
/
policy-instance-dialog.component.html
diff --git
a/webapp-frontend/src/app/policy-control/policy-instance-dialog.component.html
b/webapp-frontend/src/app/policy-control/policy-instance-dialog.component.html
index
d447c70
..
e4b1e38
100644
(file)
--- a/
webapp-frontend/src/app/policy-control/policy-instance-dialog.component.html
+++ b/
webapp-frontend/src/app/policy-control/policy-instance-dialog.component.html
@@
-17,8
+17,9
@@
limitations under the License.
========================LICENSE_END===================================
-->
limitations under the License.
========================LICENSE_END===================================
-->
+
<div class="text-muted logo" fxLayout="row" fxLayoutGap="50px" fxLayoutAlign="space-around center">
<div class="text-muted logo" fxLayout="row" fxLayoutGap="50px" fxLayoutAlign="space-around center">
- <div *ngIf="policyInstanceId">{{policyInstanceId}}</div>
+ <div *ngIf="policyInstanceId">
[{{this.ric}}]
{{policyInstanceId}}</div>
</div>
<div class="mat-elevation-z8 header row" [ngClass]="{'header-dark': darkMode}">
<div class="logo">
</div>
<div class="mat-elevation-z8 header row" [ngClass]="{'header-dark': darkMode}">
<div class="logo">
@@
-35,18
+36,23
@@
<div class="text-muted" *ngIf="jsonSchemaObject.description">{{jsonSchemaObject.description}}</div>
<div class="text-muted" *ngIf="jsonSchemaObject.description">{{jsonSchemaObject.description}}</div>
-<div
fxLayout="row" fxLayoutAlign="space-around start" fxLayout.lt-sm="column" fxLayoutAlign.lt-sm="flex-start center">
-
+<div
[formGroup]="instanceForm" fxLayout="row" fxLayoutAlign="space-around start" fxLayout.lt-sm="column"
+ fxLayoutAlign.lt-sm="flex-start center">
<mat-card class="card" [ngClass]="{'card-dark': darkMode}">
<mat-card class="card" [ngClass]="{'card-dark': darkMode}">
-
<mat-form-field *ngIf="!this.policyInstanceId">
<mat-form-field *ngIf="!this.policyInstanceId">
- <mat-label [class.text-danger]="!this.ric">Select RIC</mat-label>
- <mat-select [(value)]="this.ric">
+ <mat-select id="ricSelector" formControlName="ricSelector" matInput required [(value)]="this.ric"
+ placeholder="Target"
+ matTooltip="Element where the policy instance resides, e.g. a gNodeB or Near-RT RIC">
<mat-option *ngFor="let ric of this.allRics" [value]="ric">
{{ric}}
</mat-option>
</mat-select>
<mat-option *ngFor="let ric of this.allRics" [value]="ric">
{{ric}}
</mat-option>
</mat-select>
+ <div *ngIf="ricSelector.invalid && (ricSelector.dirty || ricSelector.touched)">
+ <div *ngIf="ricSelector.errors.required">
+ <mat-error role="alert">This field is required.</mat-error>
+ </div>
+ </div>
</mat-form-field>
<h4 class="default-cursor" (click)="toggleVisible('form')">
</mat-form-field>
<h4 class="default-cursor" (click)="toggleVisible('form')">
@@
-63,9
+69,9
@@
</json-schema-form>
</div>
<hr />
</json-schema-form>
</div>
<hr />
+ <button mat-raised-button (click)="this.onClose()">Close</button>
<button mat-raised-button (click)="this.onSubmit()" [disabled]="!this.formIsValid || !this.ric"
class="submitBtn">Submit</button>
<button mat-raised-button (click)="this.onSubmit()" [disabled]="!this.formIsValid || !this.ric"
class="submitBtn">Submit</button>
- <button mat-raised-button (click)="this.onClose()">Close</button>
<hr />
<h4 [class.text-danger]="!formIsValid && !isVisible.json" [class.default-cursor]="formIsValid || isVisible.json"
(click)="toggleVisible('json')">
<hr />
<h4 [class.text-danger]="!formIsValid && !isVisible.json" [class.default-cursor]="formIsValid || isVisible.json"
(click)="toggleVisible('json')">
@@
-83,7
+89,7
@@
<div *ngIf="prettyValidationErrors" class="text-danger" [innerHTML]="prettyValidationErrors"></div>
</div>
<div>
<div *ngIf="prettyValidationErrors" class="text-danger" [innerHTML]="prettyValidationErrors"></div>
</div>
<div>
- <pre [class.text__dark]=
'this.darkMode'
>{{prettyLiveFormData}}</pre>
+ <pre [class.text__dark]=
"this.darkMode"
>{{prettyLiveFormData}}</pre>
</div>
</div>
</div>
</div>
@@
-93,7
+99,7
@@
</h4>
<div *ngIf="isVisible.schema" fxLayout="column" [@expandSection]="true">
<strong class="text-muted">Schema</strong>
</h4>
<div *ngIf="isVisible.schema" fxLayout="column" [@expandSection]="true">
<strong class="text-muted">Schema</strong>
- <pre [class.text__dark]=
'this.darkMode'
>{{schemaAsString}}</pre>
+ <pre [class.text__dark]=
"this.darkMode"
>{{schemaAsString}}</pre>
</div>
</mat-card>
</div>
\ No newline at end of file
</div>
</mat-card>
</div>
\ No newline at end of file