Code Review
/
nonrtric
/
plt
/
rappmanager.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix sonar code smells
[nonrtric/plt/rappmanager.git]
/
rapp-manager-models
/
src
/
main
/
java
/
com
/
oransc
/
rappmanager
/
models
/
cache
/
RappCacheService.java
diff --git
a/rapp-manager-models/src/main/java/com/oransc/rappmanager/models/cache/RappCacheService.java
b/rapp-manager-models/src/main/java/com/oransc/rappmanager/models/cache/RappCacheService.java
index
49a6dfc
..
d81dd71
100755
(executable)
--- a/
rapp-manager-models/src/main/java/com/oransc/rappmanager/models/cache/RappCacheService.java
+++ b/
rapp-manager-models/src/main/java/com/oransc/rappmanager/models/cache/RappCacheService.java
@@
-19,7
+19,6
@@
package com.oransc.rappmanager.models.cache;
import com.oransc.rappmanager.models.rapp.Rapp;
package com.oransc.rappmanager.models.cache;
import com.oransc.rappmanager.models.rapp.Rapp;
-import java.util.ArrayList;
import java.util.Collection;
import java.util.List;
import java.util.Map;
import java.util.Collection;
import java.util.List;
import java.util.Map;
@@
-33,7
+32,7
@@
import org.springframework.stereotype.Service;
@RequiredArgsConstructor
public class RappCacheService {
@RequiredArgsConstructor
public class RappCacheService {
- private final String RAPP_CACHE = "rapp-cache";
+ private
static
final String RAPP_CACHE = "rapp-cache";
private final CacheManager cacheManager;
public Collection<Rapp> getAllRapp() {
private final CacheManager cacheManager;
public Collection<Rapp> getAllRapp() {
@@
-46,8
+45,7
@@
public class RappCacheService {
}
public Optional<Rapp> getRapp(String rappId) {
}
public Optional<Rapp> getRapp(String rappId) {
- final Cache cache = cacheManager.getCache(RAPP_CACHE);
- return Optional.ofNullable(cache.get(rappId, Rapp.class));
+ return Optional.ofNullable(cacheManager.getCache(RAPP_CACHE)).map(cache -> cache.get(rappId, Rapp.class));
}
public void putRapp(Rapp rapp) {
}
public void putRapp(Rapp rapp) {