Code Review
/
nonrtric.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Make assertions of log messages better
[nonrtric.git]
/
policy-agent
/
src
/
test
/
java
/
org
/
oransc
/
policyagent
/
aspect
/
LogAspectTest.java
diff --git
a/policy-agent/src/test/java/org/oransc/policyagent/aspect/LogAspectTest.java
b/policy-agent/src/test/java/org/oransc/policyagent/aspect/LogAspectTest.java
index
7930e5c
..
6b53aa1
100644
(file)
--- a/
policy-agent/src/test/java/org/oransc/policyagent/aspect/LogAspectTest.java
+++ b/
policy-agent/src/test/java/org/oransc/policyagent/aspect/LogAspectTest.java
@@
-47,7
+47,7
@@
class LogAspectTest {
// 'proceed(Object[])' is never called
verify(proceedingJoinPoint, never()).proceed(null);
// 'proceed(Object[])' is never called
verify(proceedingJoinPoint, never()).proceed(null);
- assertThat(logAppender.list.
toString().contains("Execution time of")).isTrue(
);
+ assertThat(logAppender.list.
get(0).getFormattedMessage()).startsWith("Execution time of"
);
}
@Test
}
@Test
@@
-60,7
+60,7
@@
class LogAspectTest {
sampleAspect.entryLog(proceedingJoinPoint);
sampleAspect.entryLog(proceedingJoinPoint);
- assertThat(logAppender.list.
toString().contains("Entering method: " + signature)).isTrue(
);
+ assertThat(logAppender.list.
get(0).getFormattedMessage()).isEqualTo("Entering method: " + signature
);
}
@Test
}
@Test
@@
-73,6
+73,6
@@
class LogAspectTest {
sampleAspect.exitLog(proceedingJoinPoint);
sampleAspect.exitLog(proceedingJoinPoint);
- assertThat(logAppender.list.
toString().contains("Exiting method: " + signature)).isTrue(
);
+ assertThat(logAppender.list.
get(0).getFormattedMessage()).isEqualTo("Exiting method: " + signature
);
}
}
}
}