Code Review
/
nonrtric.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fixed concurrency problems
[nonrtric.git]
/
policy-agent
/
src
/
main
/
java
/
org
/
oransc
/
policyagent
/
controllers
/
RicRepositoryController.java
diff --git
a/policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
b/policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
index
a566781
..
f6fc850
100644
(file)
--- a/
policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
+++ b/
policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
@@
-28,8
+28,9
@@
import io.swagger.annotations.ApiOperation;
import io.swagger.annotations.ApiResponse;
import io.swagger.annotations.ApiResponses;
import io.swagger.annotations.ApiResponse;
import io.swagger.annotations.ApiResponses;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Optional;
import java.util.Optional;
-import java.util.Vector;
import org.oransc.policyagent.configuration.ApplicationConfig;
import org.oransc.policyagent.repository.Ric;
import org.oransc.policyagent.configuration.ApplicationConfig;
import org.oransc.policyagent.repository.Ric;
@@
-57,7
+58,7
@@
public class RicRepositoryController {
}
/**
}
/**
- * Example: http://localhost:808
0
/rics?managedElementId=kista_1
+ * Example: http://localhost:808
1
/rics?managedElementId=kista_1
*/
@GetMapping("/ric")
@ApiOperation(value = "Returns the name of a RIC managing one Mananged Element")
*/
@GetMapping("/ric")
@ApiOperation(value = "Returns the name of a RIC managing one Mananged Element")
@@
-80,10
+81,10
@@
public class RicRepositoryController {
/**
* @return a Json array of all RIC data
/**
* @return a Json array of all RIC data
- * Example: http://localhost:808
0
/ric
+ * Example: http://localhost:808
1
/ric
*/
@GetMapping("/rics")
*/
@GetMapping("/rics")
- @ApiOperation(value = "
Returns
NearRT RIC information")
+ @ApiOperation(value = "
Query
NearRT RIC information")
@ApiResponses(
value = { //
@ApiResponse(code = 200, message = "OK", response = RicInfo.class, responseContainer = "List") //
@ApiResponses(
value = { //
@ApiResponse(code = 200, message = "OK", response = RicInfo.class, responseContainer = "List") //
@@
-91,7
+92,7
@@
public class RicRepositoryController {
public ResponseEntity<String> getRics(
@RequestParam(name = "policyType", required = false) String supportingPolicyType) {
public ResponseEntity<String> getRics(
@RequestParam(name = "policyType", required = false) String supportingPolicyType) {
-
Vector<RicInfo> result = new Vector
<>();
+
List<RicInfo> result = new ArrayList
<>();
synchronized (rics) {
for (Ric ric : rics.getRics()) {
if (supportingPolicyType == null || ric.isSupportingType(supportingPolicyType)) {
synchronized (rics) {
for (Ric ric : rics.getRics()) {
if (supportingPolicyType == null || ric.isSupportingType(supportingPolicyType)) {