Code Review
/
nonrtric.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Removed support for the non used A1 1.0 standard
[nonrtric.git]
/
policy-agent
/
src
/
main
/
java
/
org
/
oransc
/
policyagent
/
controllers
/
RicRepositoryController.java
diff --git
a/policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
b/policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
index
0d49833
..
a96766d
100644
(file)
--- a/
policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
+++ b/
policy-agent/src/main/java/org/oransc/policyagent/controllers/RicRepositoryController.java
@@
-28,10
+28,11
@@
import io.swagger.annotations.ApiOperation;
import io.swagger.annotations.ApiResponse;
import io.swagger.annotations.ApiResponses;
import io.swagger.annotations.ApiResponse;
import io.swagger.annotations.ApiResponses;
+import java.util.ArrayList;
+import java.util.List;
import java.util.Optional;
import java.util.Optional;
-import java.util.Vector;
-import org.oransc.policyagent.
configuration.ApplicationConfig
;
+import org.oransc.policyagent.
repository.PolicyTypes
;
import org.oransc.policyagent.repository.Ric;
import org.oransc.policyagent.repository.Rics;
import org.springframework.beans.factory.annotation.Autowired;
import org.oransc.policyagent.repository.Ric;
import org.oransc.policyagent.repository.Rics;
import org.springframework.beans.factory.annotation.Autowired;
@@
-42,29
+43,28
@@
import org.springframework.web.bind.annotation.RequestParam;
import org.springframework.web.bind.annotation.RestController;
@RestController
import org.springframework.web.bind.annotation.RestController;
@RestController
-@Api(
value = "RIC Management API
")
+@Api(
tags = "RIC Repository
")
public class RicRepositoryController {
@Autowired
private Rics rics;
public class RicRepositoryController {
@Autowired
private Rics rics;
+ @Autowired
+ PolicyTypes types;
+
private static Gson gson = new GsonBuilder() //
.serializeNulls() //
.create(); //
private static Gson gson = new GsonBuilder() //
.serializeNulls() //
.create(); //
- @Autowired
- RicRepositoryController(ApplicationConfig appConfig) {
- }
-
/**
/**
- * Example: http://localhost:808
0
/rics?managedElementId=kista_1
+ * Example: http://localhost:808
1
/rics?managedElementId=kista_1
*/
@GetMapping("/ric")
*/
@GetMapping("/ric")
- @ApiOperation(value = "Returns the name of a RIC managing one Mananged Element"
, response = String.class
)
+ @ApiOperation(value = "Returns the name of a RIC managing one Mananged Element")
@ApiResponses(
value = { //
@ApiResponses(
value = { //
- @ApiResponse(code = 200, message = "RIC is fond"), //
- @ApiResponse(code = 404, message = "RIC is not fond") //
+ @ApiResponse(code = 200, message = "RIC is fond"
, response = String.class
), //
+ @ApiResponse(code = 404, message = "RIC is not fond"
, response = String.class
) //
})
public ResponseEntity<String> getRic(
@RequestParam(name = "managedElementId", required = false, defaultValue = "") String managedElementId) {
})
public ResponseEntity<String> getRic(
@RequestParam(name = "managedElementId", required = false, defaultValue = "") String managedElementId) {
@@
-79,27
+79,26
@@
public class RicRepositoryController {
}
/**
}
/**
- * @return a Json array of all RIC data
- * Example: http://localhost:8080/ric
+ * @return a Json array of all RIC data Example: http://localhost:8081/ric
*/
@GetMapping("/rics")
*/
@GetMapping("/rics")
- @ApiOperation(value = "
Returns defined NearRT RIC:s as Json", response = RicInfo.class
)
+ @ApiOperation(value = "
Query NearRT RIC information"
)
@ApiResponses(
value = { //
@ApiResponses(
value = { //
- @ApiResponse(code = 200, message = "OK", response = RicInfo.class
)
//
- })
+ @ApiResponse(code = 200, message = "OK", response = RicInfo.class
, responseContainer = "List"),
//
+
@ApiResponse(code = 404, message = "Policy type is not found", response = String.class)
})
public ResponseEntity<String> getRics(
@RequestParam(name = "policyType", required = false) String supportingPolicyType) {
public ResponseEntity<String> getRics(
@RequestParam(name = "policyType", required = false) String supportingPolicyType) {
- Vector<RicInfo> result = new Vector<>();
+ if ((supportingPolicyType != null) && (this.types.get(supportingPolicyType) == null)) {
+ return new ResponseEntity<>("Policy type not found", HttpStatus.NOT_FOUND);
+ }
+
+ List<RicInfo> result = new ArrayList<>();
synchronized (rics) {
for (Ric ric : rics.getRics()) {
if (supportingPolicyType == null || ric.isSupportingType(supportingPolicyType)) {
synchronized (rics) {
for (Ric ric : rics.getRics()) {
if (supportingPolicyType == null || ric.isSupportingType(supportingPolicyType)) {
- result.add(ImmutableRicInfo.builder() //
- .name(ric.name()) //
- .managedElementIds(ric.getManagedElementIds()) //
- .policyTypes(ric.getSupportedPolicyTypeNames()) //
- .build());
+ result.add(new RicInfo(ric.name(), ric.getManagedElementIds(), ric.getSupportedPolicyTypeNames()));
}
}
}
}
}
}