Code Review
/
pti
/
o2.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Merge "Fixed alarm related issues"
[pti/o2.git]
/
o2ims
/
domain
/
alarm_repo.py
diff --git
a/o2ims/domain/alarm_repo.py
b/o2ims/domain/alarm_repo.py
index
72342f4
..
ca6929e
100644
(file)
--- a/
o2ims/domain/alarm_repo.py
+++ b/
o2ims/domain/alarm_repo.py
@@
-31,8
+31,8
@@
class AlarmEventRecordRepository(abc.ABC):
self.seen.add(alarm_event_record)
return alarm_event_record
self.seen.add(alarm_event_record)
return alarm_event_record
- def list(self, *
*kw
args) -> List[obj.AlarmEventRecord]:
- return self._list(*
[], **kw
args)[1]
+ def list(self, *args) -> List[obj.AlarmEventRecord]:
+ return self._list(*args)[1]
def list_with_count(self, *args, **kwargs) -> \
Tuple[int, List[obj.AlarmEventRecord]]:
def list_with_count(self, *args, **kwargs) -> \
Tuple[int, List[obj.AlarmEventRecord]]:
@@
-96,6
+96,10
@@
class AlarmDefinitionRepository(abc.ABC):
def _get(self, definition_id) -> obj.AlarmDefinition:
raise NotImplementedError
def _get(self, definition_id) -> obj.AlarmDefinition:
raise NotImplementedError
+ @abc.abstractmethod
+ def _list(self, **kwargs) -> List[obj.AlarmDefinition]:
+ raise NotImplementedError
+
@abc.abstractmethod
def _update(self, definition: obj.AlarmDefinition):
raise NotImplementedError
@abc.abstractmethod
def _update(self, definition: obj.AlarmDefinition):
raise NotImplementedError
@@
-137,7
+141,7
@@
class AlarmDictionaryRepository(abc.ABC):
raise NotImplementedError
@abc.abstractmethod
raise NotImplementedError
@abc.abstractmethod
- def _
update(self, dictionary: obj.AlarmDictionary)
:
+ def _
list(self, **kwargs) -> List[obj.AlarmDictionary]
:
raise NotImplementedError
@abc.abstractmethod
raise NotImplementedError
@abc.abstractmethod
@@
-159,8
+163,8
@@
class AlarmSubscriptionRepository(abc.ABC):
self.seen.add(subscription)
return subscription
self.seen.add(subscription)
return subscription
- def list(self, *
*kw
args) -> List[obj.AlarmSubscription]:
- return self._list(*
[], **kw
args)[1]
+ def list(self, *args) -> List[obj.AlarmSubscription]:
+ return self._list(*args)[1]
def list_with_count(self, *args, **kwargs) -> \
Tuple[int, List[obj.AlarmSubscription]]:
def list_with_count(self, *args, **kwargs) -> \
Tuple[int, List[obj.AlarmSubscription]]:
@@
-224,6
+228,10
@@
class AlarmProbableCauseRepository(abc.ABC):
def _get(self, probable_cause_id) -> obj.ProbableCause:
raise NotImplementedError
def _get(self, probable_cause_id) -> obj.ProbableCause:
raise NotImplementedError
+ @abc.abstractmethod
+ def _list(self, **kwargs) -> List[obj.ProbableCause]:
+ raise NotImplementedError
+
@abc.abstractmethod
def _update(self, probable_cause: obj.ProbableCause):
raise NotImplementedError
@abc.abstractmethod
def _update(self, probable_cause: obj.ProbableCause):
raise NotImplementedError