Code Review
/
pti
/
o2.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Fix a string issue of the selector
[pti/o2.git]
/
o2ims
/
domain
/
alarm_repo.py
diff --git
a/o2ims/domain/alarm_repo.py
b/o2ims/domain/alarm_repo.py
index
d712f1c
..
41205db
100644
(file)
--- a/
o2ims/domain/alarm_repo.py
+++ b/
o2ims/domain/alarm_repo.py
@@
-32,11
+32,11
@@
class AlarmEventRecordRepository(abc.ABC):
return alarm_event_record
def list(self, **kwargs) -> List[obj.AlarmEventRecord]:
return alarm_event_record
def list(self, **kwargs) -> List[obj.AlarmEventRecord]:
- return self._list(**kwargs)[1]
+ return self._list(*
[], *
*kwargs)[1]
- def list_with_count(self, **kwargs) -> \
+ def list_with_count(self, *
args, *
*kwargs) -> \
Tuple[int, List[obj.AlarmEventRecord]]:
Tuple[int, List[obj.AlarmEventRecord]]:
- return self._list(**kwargs)
+ return self._list(*
args, *
*kwargs)
def update(self, alarm_event_record: obj.AlarmEventRecord):
self._update(alarm_event_record)
def update(self, alarm_event_record: obj.AlarmEventRecord):
self._update(alarm_event_record)
@@
-96,6
+96,10
@@
class AlarmDefinitionRepository(abc.ABC):
def _get(self, definition_id) -> obj.AlarmDefinition:
raise NotImplementedError
def _get(self, definition_id) -> obj.AlarmDefinition:
raise NotImplementedError
+ @abc.abstractmethod
+ def _list(self, **kwargs) -> List[obj.AlarmDefinition]:
+ raise NotImplementedError
+
@abc.abstractmethod
def _update(self, definition: obj.AlarmDefinition):
raise NotImplementedError
@abc.abstractmethod
def _update(self, definition: obj.AlarmDefinition):
raise NotImplementedError
@@
-137,7
+141,7
@@
class AlarmDictionaryRepository(abc.ABC):
raise NotImplementedError
@abc.abstractmethod
raise NotImplementedError
@abc.abstractmethod
- def _
update(self, dictionary: obj.AlarmDictionary)
:
+ def _
list(self, **kwargs) -> List[obj.AlarmDictionary]
:
raise NotImplementedError
@abc.abstractmethod
raise NotImplementedError
@abc.abstractmethod
@@
-160,11
+164,11
@@
class AlarmSubscriptionRepository(abc.ABC):
return subscription
def list(self, **kwargs) -> List[obj.AlarmSubscription]:
return subscription
def list(self, **kwargs) -> List[obj.AlarmSubscription]:
- return self._list(**kwargs)[1]
+ return self._list(*
[], *
*kwargs)[1]
- def list_with_count(self, **kwargs) -> \
+ def list_with_count(self, *
args, *
*kwargs) -> \
Tuple[int, List[obj.AlarmSubscription]]:
Tuple[int, List[obj.AlarmSubscription]]:
- return self._list(**kwargs)
+ return self._list(*
args, *
*kwargs)
def update(self, subscription: obj.AlarmSubscription):
self._update(subscription)
def update(self, subscription: obj.AlarmSubscription):
self._update(subscription)
@@
-224,6
+228,10
@@
class AlarmProbableCauseRepository(abc.ABC):
def _get(self, probable_cause_id) -> obj.ProbableCause:
raise NotImplementedError
def _get(self, probable_cause_id) -> obj.ProbableCause:
raise NotImplementedError
+ @abc.abstractmethod
+ def _list(self, **kwargs) -> List[obj.ProbableCause]:
+ raise NotImplementedError
+
@abc.abstractmethod
def _update(self, probable_cause: obj.ProbableCause):
raise NotImplementedError
@abc.abstractmethod
def _update(self, probable_cause: obj.ProbableCause):
raise NotImplementedError