Code Review
/
nonrtric.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
Rejecting EI types with no schema
[nonrtric.git]
/
enrichment-coordinator-service
/
src
/
main
/
java
/
org
/
oransc
/
enrichment
/
controllers
/
ErrorResponse.java
diff --git
a/enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java
b/enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java
index
20e9f76
..
921b807
100644
(file)
--- a/
enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java
+++ b/
enrichment-coordinator-service/src/main/java/org/oransc/enrichment/controllers/ErrorResponse.java
@@
-1,9
+1,9
@@
/*-
* ========================LICENSE_START=================================
/*-
* ========================LICENSE_START=================================
- * O
NAP : ccsdk oran
- *
======================================================================
- * Copyright (C) 2020 Nordix Foundation
. All rights reserved.
- *
======================================================================
+ * O
-RAN-SC
+ *
%%
+ * Copyright (C) 2020 Nordix Foundation
+ *
%%
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
@@
-27,6
+27,7
@@
import com.google.gson.annotations.SerializedName;
import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;
import io.swagger.annotations.ApiModel;
import io.swagger.annotations.ApiModelProperty;
+import org.oransc.enrichment.exceptions.ServiceException;
import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpStatus;
import org.springframework.http.MediaType;
import org.springframework.http.HttpHeaders;
import org.springframework.http.HttpStatus;
import org.springframework.http.MediaType;
@@
-34,11
+35,12
@@
import org.springframework.http.ResponseEntity;
import reactor.core.publisher.Mono;
public class ErrorResponse {
import reactor.core.publisher.Mono;
public class ErrorResponse {
- private static Gson gson = new GsonBuilder() //
- .create(); //
+ private static Gson gson = new GsonBuilder().create();
// Returned as body for all failed REST calls
// Returned as body for all failed REST calls
- @ApiModel(value = "error_information", description = "Problem as defined in https://tools.ietf.org/html/rfc7807")
+ @ApiModel(
+ value = "ProblemDetails",
+ description = "A problem detail to carry details in a HTTP response according to RFC 7807")
public static class ErrorInfo {
@SerializedName("type")
private String type = "about:blank";
public static class ErrorInfo {
@SerializedName("type")
private String type = "about:blank";
@@
-82,13
+84,18
@@
public class ErrorResponse {
this.message = message;
}
this.message = message;
}
- public static Mono<ResponseEntity<Object>> createMono(
Exception
e, HttpStatus code) {
+ public static Mono<ResponseEntity<Object>> createMono(
Throwable
e, HttpStatus code) {
return Mono.just(create(e, code));
}
return Mono.just(create(e, code));
}
- public static ResponseEntity<Object> create(
Exception
e, HttpStatus code) {
+ public static ResponseEntity<Object> create(
Throwable
e, HttpStatus code) {
if (e instanceof RuntimeException) {
code = HttpStatus.INTERNAL_SERVER_ERROR;
if (e instanceof RuntimeException) {
code = HttpStatus.INTERNAL_SERVER_ERROR;
+ } else if (e instanceof ServiceException) {
+ ServiceException se = (ServiceException) e;
+ if (se.getHttpStatus() != null) {
+ code = se.getHttpStatus();
+ }
}
return create(e.toString(), code);
}
}
return create(e.toString(), code);
}