Code Review
/
ric-plt
/
e2mgr.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
review
|
tree
raw
|
inline
| side by side
[RIC-587] Upgrade Release Version to 5.4.1
[ric-plt/e2mgr.git]
/
E2Manager
/
handlers
/
httpmsghandlers
/
add_enb_request_handler.go
diff --git
a/E2Manager/handlers/httpmsghandlers/add_enb_request_handler.go
b/E2Manager/handlers/httpmsghandlers/add_enb_request_handler.go
index
92afb33
..
6f7fcd6
100644
(file)
--- a/
E2Manager/handlers/httpmsghandlers/add_enb_request_handler.go
+++ b/
E2Manager/handlers/httpmsghandlers/add_enb_request_handler.go
@@
-34,13
+34,15
@@
type AddEnbRequestHandler struct {
logger *logger.Logger
nodebValidator *managers.NodebValidator
rNibDataService services.RNibDataService
logger *logger.Logger
nodebValidator *managers.NodebValidator
rNibDataService services.RNibDataService
+ ranListManager managers.RanListManager
}
}
-func NewAddEnbRequestHandler(logger *logger.Logger, rNibDataService services.RNibDataService, nodebValidator *managers.NodebValidator) *AddEnbRequestHandler {
+func NewAddEnbRequestHandler(logger *logger.Logger, rNibDataService services.RNibDataService, nodebValidator *managers.NodebValidator
, ranListManager managers.RanListManager
) *AddEnbRequestHandler {
return &AddEnbRequestHandler{
logger: logger,
nodebValidator: nodebValidator,
rNibDataService: rNibDataService,
return &AddEnbRequestHandler{
logger: logger,
nodebValidator: nodebValidator,
rNibDataService: rNibDataService,
+ ranListManager: ranListManager,
}
}
}
}
@@
-71,16
+73,21
@@
func (h *AddEnbRequestHandler) Handle(request models.Request) (models.IResponse,
}
nodebInfo := h.createNodebInfo(addEnbRequest)
}
nodebInfo := h.createNodebInfo(addEnbRequest)
- err = h.rNibDataService.
SaveNode
b(nodebInfo)
+ err = h.rNibDataService.
AddEn
b(nodebInfo)
if err != nil {
if err != nil {
- h.logger.Errorf("#AddEnbRequestHandler.Handle - RAN name: %s - failed to
save nodeb
entity in RNIB. Error: %s", addEnbRequest.RanName, err)
+ h.logger.Errorf("#AddEnbRequestHandler.Handle - RAN name: %s - failed to
add eNB
entity in RNIB. Error: %s", addEnbRequest.RanName, err)
return nil, e2managererrors.NewRnibDbError()
}
return nil, e2managererrors.NewRnibDbError()
}
- _ = h.createNbIdentity(addEnbRequest) // TODO: add call to ranListManager
+ nbIdentity := h.createNbIdentity(addEnbRequest)
+ err = h.ranListManager.AddNbIdentity(entities.Node_ENB, nbIdentity)
- return models.NewAddEnbResponse(nodebInfo), nil
+ if err != nil {
+ return nil, e2managererrors.NewRnibDbError()
+ }
+
+ return models.NewNodebResponse(nodebInfo), nil
}
func (h *AddEnbRequestHandler) createNodebInfo(addEnbRequest *models.AddEnbRequest) *entities.NodebInfo {
}
func (h *AddEnbRequestHandler) createNodebInfo(addEnbRequest *models.AddEnbRequest) *entities.NodebInfo {